Received-SPF: pass (google.com: domain of linux-kernel+bounces-99553-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 11 Mar 2024 22:12:02 +0100
From: Pavel Machek <pavel@ucw.cz>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Hou Tao <houtao1@huawei.com>, Sohil Mehta <sohil.mehta@intel.com>,
	Alexei Starovoitov <ast@kernel.org>, tglx@linutronix.de,
	mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
	x86@kernel.org
Subject: Re: [PATCH AUTOSEL 4.19 1/4] x86/mm: Move is_vsyscall_vaddr() into
 asm/vsyscall.h
Message-ID: <Ze9zol7kZucywfOy@duo.ucw.cz>
References: <20240229204208.2862333-1-sashal@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="J1nK2iNWXPRkPHfT"
Content-Disposition: inline
In-Reply-To: <20240229204208.2862333-1-sashal@kernel.org>


--J1nK2iNWXPRkPHfT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> Move is_vsyscall_vaddr() into asm/vsyscall.h to make it available for
> copy_from_kernel_nofault_allowed() in arch/x86/mm/maccess.c.

This seems to be just part of a patch -- it does not move anything --
and we should not really need it for 4.19, as we don't have those
copy_from_kernel_nofault_allowed changes.

Best regards,
								Pavel
							=09

> +++ b/arch/x86/include/asm/vsyscall.h
> @@ -4,6 +4,7 @@
> =20
>  #include <linux/seqlock.h>
>  #include <uapi/asm/vsyscall.h>
> +#include <asm/page_types.h>
> =20
>  #ifdef CONFIG_X86_VSYSCALL_EMULATION
>  extern void map_vsyscall(void);
> @@ -22,4 +23,13 @@ static inline bool emulate_vsyscall(struct pt_regs *re=
gs, unsigned long address)
>  }
>  #endif
> =20
> +/*
> + * The (legacy) vsyscall page is the long page in the kernel portion
> + * of the address space that has user-accessible permissions.
> + */
> +static inline bool is_vsyscall_vaddr(unsigned long vaddr)
> +{
> +	return unlikely((vaddr & PAGE_MASK) =3D=3D VSYSCALL_ADDR);
> +}
> +
>  #endif /* _ASM_X86_VSYSCALL_H */

--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--J1nK2iNWXPRkPHfT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZe9zogAKCRAw5/Bqldv6
8hbCAJ90bmk+FFZg/PTzuaLCwvZ7uaouHACfSIPDNgnMYXrB2dTvZ2dSQb5mO4g=
=OE+O
-----END PGP SIGNATURE-----

--J1nK2iNWXPRkPHfT--