Received-SPF: pass (google.com: domain of linux-kernel+bounces-99612-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240309132710.1055941-1-retpolanne@posteo.net>
 <CAM9d7cjhiua5rBj=CTDJJC-XJN6PzKxQ5DsooJGEz0QcQAry7w@mail.gmail.com>
 <m2il1sbocg.fsf@posteo.net> <m24jdcbmg3.fsf@posteo.net> <Ze9hH5UzmnkFrTmB@x1>
In-Reply-To: <Ze9hH5UzmnkFrTmB@x1>
From: Namhyung Kim <namhyung@kernel.org>
Date: Mon, 11 Mar 2024 15:29:13 -0700
Message-ID: <CAM9d7chSavuxXJG8M9LMVWZfJXJPjQ3M4aLTKGsixmKef0-bkw@mail.gmail.com>
Subject: Re: [PATCH v1] perf lock contention: skip traceiter functions
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Anne Macedo <retpolanne@posteo.net>, Peter Zijlstra <peterz@infradead.org>, 
	Ingo Molnar <mingo@redhat.com>, Mark Rutland <mark.rutland@arm.com>, 
	Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, 
	Ian Rogers <irogers@google.com>, Adrian Hunter <adrian.hunter@intel.com>, 
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 11, 2024 at 12:53=E2=80=AFPM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> On Mon, Mar 11, 2024 at 07:25:16PM +0000, Anne Macedo wrote:
> > Anne Macedo <retpolanne@posteo.net> writes:
> > > Namhyung Kim <namhyung@kernel.org> writes:
> > >> I think it depends on the kernel version and configuration.  I remem=
ber
> > >> I saw a different symbol on old kernels.  But it'd be hard to handle=
 all
> > >> the cases.  Let's have a single trace text section in the struct mac=
hine
> > >> and use __traceiter_contention_begin only.  If it's not found you ca=
n
> > >> fallback to trace_contention_begin.
>
> > However, if we fallback to trace_contention_begin, we won't be able to
> > filter out both __traceiter_contention_begin and trace_contention_begin
> > at the same time.
>
> I think for ARM we need to skip both, no? I.e. I agree with Anne.

I haven't tested it on ARM, please go ahead if it is needed.

Thanks,
Namhyung