Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp722611lql; Mon, 11 Mar 2024 15:51:40 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXCPB6FxKeITUQR1Fy883YaDAyLdGVnczmlcmOnzaarjqxswsYbQRr+eEmcKzlBkNOhWc8fDq7IWMUjyM7AGnkhiG2fSIVejmuJX9gRvg== X-Google-Smtp-Source: AGHT+IG+k3ixCI2uz0fvssdhJ5zInegLICvJy6d7XGA/VtWIBXryr3zu+C3Fw81i9cdeuaXBOXlw X-Received: by 2002:a05:6808:220d:b0:3c2:2dd1:cbb9 with SMTP id bd13-20020a056808220d00b003c22dd1cbb9mr2389189oib.5.1710197500497; Mon, 11 Mar 2024 15:51:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710197500; cv=pass; d=google.com; s=arc-20160816; b=S1XkRXQVeJ8rY5pVoiVmCu6MZa6Z0Rz9j/LGXUfZTDIq1dxbH9VRFej5iV6SvDh6Xs 70bFH8pqDa5oBsGf+t83R2CFnq8VrpNtfnYDL7oKqBfE9JkVtyaMyfRNUi2B9Nrvl6yf Aa0m1JgvA5ozeDwDhyRpLQ60uhL1O9zgBDMfFbnyiUklfe9Wc3au1VynF7xy7nsK1B2q 1htSb1wcTSJdBJJrUCz92yljX62GQa2IUFVGjfi4JL/7Q3iUezbRrh+6zjEzZhlNCWrP SZp8JMRj8+SZbLplOOWIqkIM59ZVwnfgjr3EKYNYI1z1UgNQwD+E+Q1FgfVP4rl8rzXR /DUg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=LMoLZDTZ9w38XZbw+wvsD9KU7HwLnveuxNXtvXR3LVs=; fh=w/QzIdP0uQ/mAC+VHZ0hZ6PMf/rHWF2qKsPwXswFKts=; b=TLyA2bVsAxK7SqBBQQrbZzqtiY8Rwf9w67r96rqnWdWqgPiMuJxy5RehECH4Z8xznN CHLvTXLx6y+fCYe6cEm255Od0q9K6lKVCqjT3B4SJ22y3O8I8EcwgEK9VbQPUc1bbOCk 0PkdhwfWlsMaUDWeRsnEAgZNJv2qUaiWJ3DpFob/bKh07CmaOCUBzThYLniiu34R9IQs M/L8EKAQI3JmtQdagvQXqGqQ2g5sXsZElYFLhek0vZerqJvtdruoI7j3s/lW6rcqIwJ7 /3s4u1fwlDcquvVlDohgbIinYvnPljUtDrqAS/Z1qFm5H819KMI7EHQrgHkYzaSlcggp YITw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=RZ2gRqkj; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-99630-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-99630-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id c31-20020a630d1f000000b005e498065660si5746441pgl.322.2024.03.11.15.51.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 15:51:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-99630-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=RZ2gRqkj; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-99630-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-99630-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 2B3A228243A for ; Mon, 11 Mar 2024 22:51:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2CA755820E; Mon, 11 Mar 2024 22:51:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RZ2gRqkj" Received: from mail-vk1-f170.google.com (mail-vk1-f170.google.com [209.85.221.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D92EB58119 for ; Mon, 11 Mar 2024 22:51:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710197468; cv=none; b=M075rrCZLUqi1qJGXt82nFX9gDbefca6ras+RUTMplnPh1xBYXofNmMCu5BfccxkAbCNxBiYJNODHO21Gzy549eCvTRFvtC/gmHI0RjaWWps928Qnmyve6EAIyl6tmGWzsaOpF91gIdMMboAx8ZrzS2QFdy/SLPbXp1wgmtt8/c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710197468; c=relaxed/simple; bh=LMoLZDTZ9w38XZbw+wvsD9KU7HwLnveuxNXtvXR3LVs=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=mwXAlUZzPwP407qPa/kDbxnfHUXwLLQaorV2XCrHssSP/z2VJZY9UFw4qPGqIuVftBe78RCyIF3cHTKRSmQkIoxZsQKIC4Wncl0bvtYTiovMw3s8I99xfRcIPEOrRYfX7Q4a+dj4m2wVRKWEAxocipplBWpTgr2tYwHrnydJXUo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RZ2gRqkj; arc=none smtp.client-ip=209.85.221.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vk1-f170.google.com with SMTP id 71dfb90a1353d-4d35ab44ba9so861621e0c.1 for ; Mon, 11 Mar 2024 15:51:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710197466; x=1710802266; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LMoLZDTZ9w38XZbw+wvsD9KU7HwLnveuxNXtvXR3LVs=; b=RZ2gRqkj+FbLzoowUMILf81x82p80DKM84+zrnmSF/rEstRFVAjAtR3q0zhqdaXTQ/ NKaHJGRH0jKhJkcoj2ncNVXfX/qaqvN+T29RqHnj40+gNmd8FHfBng2W+ygHvXQ2Bujl knju1R5V2Db8IEf/RglR43+pwZ7HbS5ADHX+mf8sYufriDnRph+DPwQnCb9RB0nzb/fc /5MvCzMbZ9k5nATC8DaaAn/5mFCGzwtNG7vlvUOYJHrHO1360MRPY0KcC3PKsDNoJ24a O7z6j7nejZZFnA5Mr3mUeDedlQ1Kb02DBuWghRzaItCx4DeTsDm+i+OyBanVcxSk56BJ AZOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710197466; x=1710802266; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LMoLZDTZ9w38XZbw+wvsD9KU7HwLnveuxNXtvXR3LVs=; b=VwNWGa+M8vtVYpcc2XooEQ56sMlQ5iwGAL7kyITRqo2TWO6rSUOUPgy164KMHHrcDE acXw3/aKvGC0B9btnTp+z0Iw3zXtMCJxP5jfBpr90Kv8v7dyeLls3lZuRCqPm7GajHW7 dG+XFI1OcReXqVDOOG+UsVRyHl7Y3+L+/10RpeSqrYebhT/GL982fTaijSSikpn6FcTk NWxgJyYbaEVFl8bONXs+KGrZbIXDKETaZkKnYShJH5ckPB9UMqaYuG9P/+672UMYDSiu CErAahSWvT8rxDo+2WyawB6bgPpprCA+xQGeKaXz/t9Zx2UwCyQlZDaJZL82i2ypLdxS Ys8w== X-Forwarded-Encrypted: i=1; AJvYcCXEKQKqdjhfp3mEQhqEu7uApvP5sW7/P+zM9Uoc+W+3k1/hrMOCGor9aeezU8LHUywhGyJ+WCs4yv5zgw4dfKNCtH2/BrClD7s7MGFu X-Gm-Message-State: AOJu0YzsYQsoT2TCiFZ6YBU5a/sYu2lufCTLLYrg4990eLW+WmvizKji MMsf80gw/F1+Y/ocFOTkmx0JkVDsW22crZu1DENyUfDEYe3k+znDVt2d2IgcLwvt/nLayA+0T2v xZPLTDNvS2VSc2rHX+P5eMsNY2iU= X-Received: by 2002:ac5:cce8:0:b0:4d1:3f5a:75f3 with SMTP id k8-20020ac5cce8000000b004d13f5a75f3mr1397449vkn.15.1710197465671; Mon, 11 Mar 2024 15:51:05 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240228181850.5895-1-apais@linux.microsoft.com> In-Reply-To: From: Allen Date: Mon, 11 Mar 2024 15:50:54 -0700 Message-ID: Subject: Re: [PATCH] kernel: Introduce enable_and_queue_work() convenience function To: Tejun Heo Cc: Allen Pais , jiangshanlai@gmail.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Tejun > > The function accepts a target workqueue and a work item as parameters. > > It first attempts to enable the work item using enable_work(). If the > > enable operation is successful, the work item is then queued on the > > specified workqueue using queue_work(). The function returns true if > > the work item was successfully enabled and queued, and false otherwise. > > > > This addition aims to enhance code readability and maintainability by > > providing a unified interface for the common use case of enabling and > > queuing work items on a workqueue. > > > > Signed-off-by: Allen Pais > > I'll apply this together with the rest of the series once v6.10-rc1 opens. > Could you please let me know once this is applied or point me to the branch. I have all the conversion based on this. I have a series ready for review(a set of 10 patches): https://github.com/allenpais/for-6.9-bh-conversions/tree/for-6.9 A series that still needs some work(testing and cleanup): https:/github.com/allenpais/for-6.9-bh-conversions/tree/for-6.9-wip (This series contains changes to all the files that use tasklets in drivers/*) I am working on cleaning it up and also testing. They should be ready for review soon. Thanks.