Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp766445lql; Mon, 11 Mar 2024 17:53:47 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVVm6pVPRe3bzkbUKsQtXbmXWZW7yMf1G46sVxp6JnUZ7DW6suiZW1en5RYMHh0vV5uIwbtsY4SwREwopYAhnVcCaTcLLDDKdmDiXJuYQ== X-Google-Smtp-Source: AGHT+IEnmQsNoIa5/X7wQO03hGTp290dkKcqX7VsMOu/3L7milDG9LpiRni7VU1OozXGEGvKNbkb X-Received: by 2002:a05:620a:40d3:b0:788:777e:5cbe with SMTP id g19-20020a05620a40d300b00788777e5cbemr2241811qko.33.1710204827161; Mon, 11 Mar 2024 17:53:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710204827; cv=pass; d=google.com; s=arc-20160816; b=J1TdgkwhVzkTiQcu70nSZz9K33gJVVwGarcTXvlxZ2ZCUwUjLNBUWZnsz6SbBj9UWI JGx4KCIwGQA32YZg34nEF40yuOiUicdgrn/ONRtObSA9/4lbsj4yJPwO8Al9wszcXG5A ohEWKoQVjftO5U2gYhSoDyOwVzXJYacT/qaqev6NLoZEHWweJAUqO1m/3A9ynuO5nuPr MkS2mGSRiRCIUrQK3yATdnOx8veAClqnK9JNNxHsuwBpgx9J3bRJJ+K9zdzP+eBFcUyV YuZKoxuU6jE798Lrw+NDVwhzKXBhu1aVk+ap17Uly1nI+fIi17ErFbetxpGS7mg0Py4M +0ww== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=XAXtTfEXGKv53KCC9cMlFPbHyVA7kEAHQrIVYEVEo1E=; fh=iixN/KRuvsQs/ZfLQ7dQYayp2Sx/iwEOWj9MlOhJXT0=; b=x23/y6suToBUWWnjvFdsyP+qFPuUnMq1ry4VP/jfKcX+u40N+SUqw5RgvNeNXtGGL4 NMf1imFzJYg/MoWZn1juKUH1/KB9RlAvCz3TaWBjeR60qqwN4yw24CO1uosGpYK417M7 DGEwNU31rk7bhB6JLb/vDtnJPCP0vh9/pMp/0N/hyi9SSOJUWH8to+rMKDtZp2YbekED bPpfk5DZgBo0XQNkdOHel66qQWGiirseAgO+lQG04sX8csyHqkCQse8B9KSztrSAtqBD 9L+kvVaIaeURrMnqDMhGKlGcvGHLM1i+/Pq6tzH6fc+RvbKXydd5mkuRGZYE157dJsy6 B5yw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=FlVzYSDY; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-99709-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-99709-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id h22-20020a05620a10b600b007885a7c32bdsi6337103qkk.201.2024.03.11.17.53.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 17:53:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-99709-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=FlVzYSDY; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-99709-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-99709-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id D0D441C218AC for ; Tue, 12 Mar 2024 00:53:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 060A46FBF; Tue, 12 Mar 2024 00:53:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="FlVzYSDY" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D11695CAC for ; Tue, 12 Mar 2024 00:53:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710204820; cv=none; b=XYegMGSndNktvY25lN5Pyrevca0h+eXLFbBWXdJjxaDd2HIAZp6CJEEE51Lwrr74vqEVdDVFb3z1KsGCNJ5I1R+mSwySHOlWBUeLs6M3YqjqxbW5OzONRaC/qTdkCgnm+Tf3DEYoT0WK8OZVkum5OthGl5QGcfuI/ImLtSNY574= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710204820; c=relaxed/simple; bh=C6LtKzzQJay8DHvjH/vS7Shki8otvBwfa/Ly0CnqENw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oWTrlkbPQ2VxwvfwTVEopMZZmUdwl4E4Ux6E4kCkVAwHBSgCaYdgzTsRo4HKl7vu4RygRH3ovX1c38qn58/fn4xXn4B3MY1E0YP7EF9RhKzUHEYE4fnbFr6ASjS3U4pRJYwKTm066hVJNdEln78/En0q82szK6cjWVqHKmC22s8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=FlVzYSDY; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710204818; x=1741740818; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=C6LtKzzQJay8DHvjH/vS7Shki8otvBwfa/Ly0CnqENw=; b=FlVzYSDYh6Rr7kN3X2hZtOopvTM/ygQqE6ZMoGAFuqt/774ajO3Akgn8 bGJCXkkiKQaESnUCIHTwkyhHBmR0fU1Lx83Nz6yuQki4rqtbmNrjMSEI4 bBd/LkgaK0OGtLCic/ZSzjlaWP4bGXCFu9KSP5YcbhqyGvx0xSeIsXAjJ rsLHkfVreN/RFpN1Zh2xyNBJ4dPX2RzBPwxLWLsAm4RVvM/zdLG0QQRHC 8S2bxFKfoeVzZij33YAOL4UXgfZSJJpH6Gpx+ICblYDRyRWYSmtOB9Op4 JLUwV6CZjDNi9SMaDrr4veZ2O5/k3TLExWqR/fevzucxTUje1PI5bOP2N Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11010"; a="5501215" X-IronPort-AV: E=Sophos;i="6.07,118,1708416000"; d="scan'208";a="5501215" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2024 17:53:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,118,1708416000"; d="scan'208";a="11422641" Received: from siverson-mobl1.amr.corp.intel.com (HELO [10.209.94.13]) ([10.209.94.13]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2024 17:53:32 -0700 Message-ID: Date: Mon, 11 Mar 2024 17:53:33 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 11/14] x86: add support for Dynamic Kernel Stacks Content-Language: en-US To: Nadav Amit , Andy Lutomirski Cc: Pasha Tatashin , Linux Kernel Mailing List , linux-mm , Andrew Morton , the arch/x86 maintainers , Borislav Petkov , Christian Brauner , bristot@redhat.com, Ben Segall , Dave Hansen , dianders@chromium.org, dietmar.eggemann@arm.com, eric.devolder@oracle.com, hca@linux.ibm.com, "hch@infradead.org" , "H. Peter Anvin" , Jacob Pan , Jason Gunthorpe , jpoimboe@kernel.org, Joerg Roedel , juri.lelli@redhat.com, Kent Overstreet , kinseyho@google.com, "Kirill A. Shutemov" , lstoakes@gmail.com, mgorman@suse.de, mic@digikod.net, michael.christie@oracle.com, Ingo Molnar , mjguzik@gmail.com, "Michael S. Tsirkin" , Nicholas Piggin , "Peter Zijlstra (Intel)" , Petr Mladek , Rick P Edgecombe , Steven Rostedt , Suren Baghdasaryan , Thomas Gleixner , Uladzislau Rezki , vincent.guittot@linaro.org, vschneid@redhat.com References: <20240311164638.2015063-1-pasha.tatashin@soleen.com> <20240311164638.2015063-12-pasha.tatashin@soleen.com> <3e180c07-53db-4acb-a75c-1a33447d81af@app.fastmail.com> <08EFDEDB-7BBB-4D9C-B7E5-D7370EC609BE@gmail.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <08EFDEDB-7BBB-4D9C-B7E5-D7370EC609BE@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 3/11/24 16:56, Nadav Amit wrote: > So you can look on the dirty-bit, which is not being set > speculatively and save yourself one problem. Define "set speculatively". :) > If software on one logical processor writes to a page while software > on another logical processor concurrently clears the R/W flag in the > paging-structure entry that maps the page, execution on some > processors may result in the entry’s dirty flag being set (due to the > write on the first logical processor) and the entry’s R/W flag being > clear (due to the update to the entry on the second logical > processor). In other words, you'll see both a fault *AND* the dirty bit. The write never retired and the dirty bit is set. Does that count as being set speculatively? That's just the behavior that the SDM explicitly admits to.