Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp770275lql; Mon, 11 Mar 2024 18:03:28 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW/NF3rhFU/52WVCoT4+ATYJ/Iy2koW8AbPQ534lZ7fOu4VM658jq4M60zfKDzTXHo27QJF0AhW/stHQ4xEy/EVlg838jvQ5AfTdmkxMw== X-Google-Smtp-Source: AGHT+IHoH524zEZe0s1F5RnwRb+en8u85W0fJhwEyB4PtkPr3ZDhLJuXXVV0VJ2erlwLXWNOYrYe X-Received: by 2002:adf:fa91:0:b0:33e:11c3:7ebf with SMTP id h17-20020adffa91000000b0033e11c37ebfmr5363934wrr.62.1710205408025; Mon, 11 Mar 2024 18:03:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710205408; cv=pass; d=google.com; s=arc-20160816; b=TEofMu0i1sA1wnbVAGaClKtGM56+dAKKAg+fHqKeIdSmnMNqtOGfBrzZ4C5IcBmtZh 3yo9f3cphyvk4OyYJTJ0xinNr6T9rdBj/m3jUtg2lSNCoi7F3NFXwUvG7n8AYc3SLlYB 3We6h4Xp3wUjOfOLw9hyLn7PH1g0CQ2TXdla1kKjGLbl5YlMu1fFcaxiN41O5r2Pvo5O 3nmbbNbYKQTGAqdjO7XA4N0ckRmnIlNE50X4CBdMRQpK7wkovtw4fvQbHnu31xzwgt6I LxagqMsiutRAEigQV9xMTyN/TKH65wgha0z2NR65iXMhiMG+G9wEOb/rD5F/icCOzesS eOug== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=8OttdZlrG4D6n3/bWArb231lKpBo0dIW6y37zc5CZQ4=; fh=X4C3tV5/BZ8v78qlR5JAf21OFUiYe6wCTNYQObcx42E=; b=mY1nGd0pCuJWKVWTP7VbzvlyrNnweh4vhpEIXwod7BFIADyyzU/EVsyajepNvliPxr ol+gbIr3r4xI2PkLFYgpbyWRq9G8j7PhuT1RGNREtf9hbjiBWQy8UtfEmeYYO3hqLcNd J9XNAF5T4Raio/lftbptUyHy5jt4yCpYfLHt/BOXc91L5D+e7b7CnxV8Rlk11L/SPudl EFwAWHJgPFQUx7Kdy+SDXVPtoYNa32RCM3tmZ5D4SfKsYtRbPU7/HhsKM2rscZGSjXSx pEYAKRdLCBLD7OxgXEoTwwhvmg5wCjRxW54Cq+jI0joxcgYQoiZEuNJ2dwG4B8LPRk+S DEiA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=Kr3vSSyP; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-99711-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-99711-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id v8-20020a056402348800b00566becd157csi3012222edc.662.2024.03.11.18.03.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 18:03:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-99711-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=Kr3vSSyP; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-99711-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-99711-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 93F441F217F2 for ; Tue, 12 Mar 2024 01:03:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5690817FD; Tue, 12 Mar 2024 01:03:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Kr3vSSyP" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4961653; Tue, 12 Mar 2024 01:03:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710205398; cv=none; b=S2mQwskGk3x9rpf7uocujA+l68gxnmlf4q/27Hq9Fxp9tmdR0YVG3vhDyKrfflI2KUPW2Y2efE786oUQ9sJ0yokHUwNQlgNmjq7JDZoB+cveX4IofoifSCM83FWk5CpStxrDg7+yTawlc5/sd57jr9fs84+T1vYPTbdaNOH8qos= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710205398; c=relaxed/simple; bh=4EA1F03Y5lBS4e+B0GkGj9LBCoZMKjVs2nvhaANcl3s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HKn4ItCb1FHzvUUfYuZRGJhY3WFJywNaTnFYkyHzt8MGaXDVopnp5h+pfBXQQLM4/feh0BDL89GQM4IsksqfpmF5d4fm8SvniJ0NGxxO7tZwLovjgLICkjjJLahg6NlZE6whPNO0ndltXmmFxL7Ux5H+xTj7H73Dzf69k4x8D60= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=Kr3vSSyP; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=8OttdZlrG4D6n3/bWArb231lKpBo0dIW6y37zc5CZQ4=; b=Kr3vSSyP3usEfrbHqWqNQT6C3v p8ShX6NQ0jQ0h6m7vLjc0kJjht6nXakuEFxRF0jMi95vopHMnAJK96GYqyHC6vlvrPH1hh27rTUwW FbNrpLsqLKooJJhCEjSJTbW26m8N8loFhsU10SR0qFZaTnBBI561QPHuuJQ6vh9baJ3k=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rjqY5-00A0Ed-2W; Tue, 12 Mar 2024 02:03:21 +0100 Date: Tue, 12 Mar 2024 02:03:21 +0100 From: Andrew Lunn To: Justin Swartz Cc: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Daniel Golle , DENG Qingfang , Sean Wang , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] net: dsa: mt7530: disable LEDs before reset Message-ID: <0793ba6a-6cc9-4764-a2eb-f2766d860315@lunn.ch> References: <20240305043952.21590-1-justin.swartz@risingedge.co.za> <6064ba52-2470-4c56-958c-35632187f148@arinc9.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > (b) When a cable attached to an active peer is connected to > Port 3 (lan4) before reset, the incorrect crystal frequency > selection (0b11 = 25MHz) always occurs: > > [7] [8] [10] [12] > : : : : > _________ ______________________________________ > ESW_P4_LED_0 |_______| > _________ _______ > ESW_P3_LED_0 |_______| |______________________________ > > : : : : > [9]...: [11]..: > > [7] Port 4 LED Off. Port 3 LED Off. > [8] Signals inverted. (reset_control_assert; reset_control_deassert) > [9] Period of 320 usec. > [10] Signals inverted. > [11] Period of 300 usec. > [12] Signals reflect the bootstrapped configuration. Shame the patch has already been accepted. The text in this email would of made a cool commit message. Andrew