Received-SPF: pass (google.com: domain of linux-kernel+bounces-99713-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 11 Mar 2024 18:08:53 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Yang Xiwen <forbidden405@outlook.com>
Cc: Yisen Zhuang <yisen.zhuang@huawei.com>, Salil Mehta
 <salil.mehta@huawei.com>, "David S. Miller" <davem@davemloft.net>, Eric
 Dumazet <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>, Rob Herring
 <robh+dt@kernel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
 Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>,
 Russell King <linux@armlinux.org.uk>, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof
 Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH net-next v11 4/9] dt-bindings: net: convert
 hisi-femac.txt to YAML
Message-ID: <20240311180853.5e3a6a41@kernel.org>
In-Reply-To: <SEZPR06MB69596EB6D2097DB14FF5C9C6962B2@SEZPR06MB6959.apcprd06.prod.outlook.com>
References: <20240309-net-v11-0-eb99b76e4a21@outlook.com>
	<20240309-net-v11-4-eb99b76e4a21@outlook.com>
	<SEZPR06MB6959090F2C45C3E5D6B3F9F496262@SEZPR06MB6959.apcprd06.prod.outlook.com>
	<20240311090341.32509303@kernel.org>
	<SEZPR06MB69596EB6D2097DB14FF5C9C6962B2@SEZPR06MB6959.apcprd06.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 12 Mar 2024 08:49:21 +0800 Yang Xiwen wrote:
> >> Still not very correct here. In downstream the core can also have an
> >> external PHY. The internal phy is also optional. So maybe this clock
> >> should be optional.  
> > You are responding to yourself 4 min after posting?
> > What is the purpose of your comments?  
> 
> Just to remind others or myself this can be improved. But i think it's 
> ready to be applied. There won't be similar design in mainline soon i think.

It's a fairly uncommon thing to do, normally such notes should either
be comments in the code or notes in the commit message.

In any case - the merge window for v6.9 has started, we won't be able
to merge these changes for the next 2 weeks :(