Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp793998lql; Mon, 11 Mar 2024 19:13:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVCgXnWG5HOdTE9QpJwwsHb4EbtIWcgOne1ZLDaL4k7PSzrSWpQqnMU3YduyyiSjATxgLtbwI5p1OR9JG7o5HSbWuvVsZOaN3hBCa7t3A== X-Google-Smtp-Source: AGHT+IGktpQZYmYaKN7gEkLzU8dVIOhUSeZQtteNBwenp4yToF17LzFS3S+68DlHi+uD2ys/79Pt X-Received: by 2002:a17:906:6a18:b0:a45:f7f9:94fb with SMTP id qw24-20020a1709066a1800b00a45f7f994fbmr6312585ejc.73.1710209605649; Mon, 11 Mar 2024 19:13:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710209605; cv=pass; d=google.com; s=arc-20160816; b=anD3D/7wFuOb6ckUz7IIlkqzU18M8/UeZArkLKpiJpVLLwzyIQWiRRb5SbONpOx09K X6MA09ETa0kje1EfRzGRZCVH+lmFFeSjjsI14BwrQ8PrwRZNaWap5lA3m2PrE4Ytp1ZB WVON8kM4TiTAbagY68UCpY5cESFoSqUk+zEMk6/WzkF2GXN1UTnTzG+wBqkCd05TxAfm L7mjW3um3ubcG9bMuIfqaXhhqo4T/bOpGcIefxFiakZdqhYk2RyzJyo4mL0L1DdjC6hz Rnxh1Etrd/4pDjUOzGP8KSNlCA8Yb5tctNPh+fVqYSwOe0WRhTMEFMfJwBZK4yyEpstQ yr0A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=d4vuO+P0IaUZQ15PJm7E7b1fno/LzB/UdIJ/5WWrlvk=; fh=yR0OKOZYR5uT6lPlcfR3OW2TPNx4xmmV3fUq1PiQ8rs=; b=QluqyXCmze4m8UT0QQdS3aOA5+pDxulqZvtQsjoseO84HdncLb6wTr62D9nl7ks8rx qS0CZ1QHvvjLZod+LS3Ggnge8nTm+AUYFVNljNf1QKhfBo18k34uWHARxJFdn8NOxoeh NUdH0DvO9Q7lmVVZOdClONInNX0aWcENSpdUAQ9H+aewDLBdR1kBeSwNRd96Mz2nOnD7 q9XtrSEZ0M3v7WbUPzEX6vWf9MbzoUDzHFN8hVsDmko4X3hYpTuZcrHwEvshnzmWK1Ce tAwCgeMxQQ0p2/xvUzhGLecXYFW1OyhVq4JcXkYMDg/P5T0Ac1KM3Js/qPwLaFs9UAQd sl0w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BfGb9Gjn; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-99757-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-99757-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id l9-20020a170906794900b00a43b6d6fd4asi3080509ejo.923.2024.03.11.19.13.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 19:13:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-99757-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BfGb9Gjn; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-99757-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-99757-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5F2471F21C96 for ; Tue, 12 Mar 2024 02:13:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 67667C8DE; Tue, 12 Mar 2024 02:13:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BfGb9Gjn" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D26EBE47; Tue, 12 Mar 2024 02:13:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710209590; cv=none; b=ZjSYVdEdd5qFmrMtEz91p3jgujl0Hed4PGvPnq5j9bhusV3tDJZ5EKJQm2mgNuze6Sw7FktBz3SBbg9DbQzp4V8DXZSKdFrbb/hQMkHdJWxCbnL8kaZJ0Lu+f5KbzopSnV0nlkZheOxFP7pm5Kp6Oagt2Y39XP3TlR82x/i15rQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710209590; c=relaxed/simple; bh=M13j/FiOeQLQqYn62WVaTaw1CEpghTNC1+EUk79X6eU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kaDvJ2S6ZfXjT3IqLMCuXRiqQ7Nid+W3NNIV7nqz5WEiq33pjGXeqTZBZlZTyZGKprwPjwMp+oEW1RcE2XhdnRKjNSQQUSWsTaMFXyhW1/NCKLKqPMsss0EOua7DJuWkNXhzPS1qHbnQaT1Kz5Vum0KaTDwROJZwnE0ld/DJ1uc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BfGb9Gjn; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6B36C433F1; Tue, 12 Mar 2024 02:13:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710209590; bh=M13j/FiOeQLQqYn62WVaTaw1CEpghTNC1+EUk79X6eU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BfGb9GjnsUqVbDazG2+BcDsVSoSxIPPza6GM7U3qpAT9gQZNQnFEPzczM0t2s+J5Q KjtScZOrbjh2nMkg6VTS5l1uwmF/p8M1q2ybCJqJNyanau+y2km7Rwh4504OybAxph JldRAGuflPm+s5U2MxYCDMLA2Yit5IJcWA04eSBQtpZ67PQ7LicCSoRPYT1tA4+PNE 0JVuVVG59n1qHDweMwby7Rifq9v0zQrbYUk0HoW3+ZlRYBgE3t1ewklthlzGf9IYW9 kk1jM7gSm5jKdutK+s/kERPz9fdfsvGzweNSiUgogxeHjjCKGcwR1+F4+0wAcz+MT6 mBq74rhtHN4YQ== Date: Mon, 11 Mar 2024 19:13:08 -0700 From: Eric Biggers To: Kent Overstreet Cc: linux-fsdevel@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Josef Bacik , Miklos Szeredi , Christian Brauner , David Howells Subject: Re: [PATCH v2] statx: stx_subvol Message-ID: <20240312021308.GA1182@sol.localdomain> References: <20240308022914.196982-1-kent.overstreet@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240308022914.196982-1-kent.overstreet@linux.dev> On Thu, Mar 07, 2024 at 09:29:12PM -0500, Kent Overstreet wrote: > __u32 stx_dio_mem_align; /* Memory buffer alignment for direct I/O */ > __u32 stx_dio_offset_align; /* File offset alignment for direct I/O */ > + __u64 stx_subvol; /* Subvolume identifier */ > /* 0xa0 */ > - __u64 __spare3[12]; /* Spare space for future expansion */ > + __u64 __spare3[11]; /* Spare space for future expansion */ > /* 0x100 */ The /* 0xa0 */ comment needs to be updated (or deleted). - Eric