Received-SPF: pass (google.com: domain of linux-kernel+bounces-99764-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <c7be9930-26e7-454c-87f6-c8cdf2fce481@intel.com>
Date: Tue, 12 Mar 2024 10:21:28 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v19 022/130] KVM: x86/vmx: Refactor KVM VMX module
 init/exit functions
Content-Language: en-US
To: Isaku Yamahata <isaku.yamahata@intel.com>
CC: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<isaku.yamahata@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>,
	<erdemaktas@google.com>, Sean Christopherson <seanjc@google.com>, Sagi Shahar
	<sagis@google.com>, Kai Huang <kai.huang@intel.com>, <chen.bo@intel.com>,
	<hang.yuan@intel.com>, <tina.zhang@intel.com>,
	<isaku.yamahata@linux.intel.com>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <11d5ae6a1102a50b0e773fc7efd949bb0bd2b776.1708933498.git.isaku.yamahata@intel.com>
 <aa5359e5-46a3-48d0-b4af-3b812b4c93ae@intel.com>
 <20240312021524.GG935089@ls.amr.corp.intel.com>
From: Yin Fengwei <fengwei.yin@intel.com>
In-Reply-To: <20240312021524.GG935089@ls.amr.corp.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDJnR2M1SExOUnZEemk1U1UxSFVCYnRURHB3SjJZL3VqeDduNXJzNW1hMThw?=
 =?utf-8?B?WXQzUy9mYUgxdXdOWGM4WTNCUTUzN0QwV04yb3YzdmNUZkVzenNUSHNUUVE2?=
 =?utf-8?B?ZndIbzhtVXh2aTg1eW9SU0RNSk52U3JPbUhSamxBZC9iWHdTaGZ1SWNObVFo?=
 =?utf-8?B?OXJQMll3VDdBS3puQXZXQUw4SCtjL1FzTDE1T25rNWFoKytzd09SNWRkSHZI?=
 =?utf-8?B?NWR0b2xCVkV4TytGOERzZnJKaVByQ08ySDlqVDBKSWVLTlB0VFlrT0k1ZStt?=
 =?utf-8?B?N0FZMmFaemRCSjNFeVEvMjMyY0ROMlFlZkNMcVcxb3lPeE1XSGRjOGRRNkNT?=
 =?utf-8?B?MUVFelJIRkR6bUVXTlhqY3lyN2VibHJWenQ3K1JqNkxUTC9xMWZHdS91emNV?=
 =?utf-8?B?M3dQV1RYZHJNSE5MR2FacCtvRW5zeWhsa0wrVjQ0SGRRVGZCQmRFS0lrK0Z0?=
 =?utf-8?B?d3JJZnhwaU02SDh3bFBWQUxlS0RJY2hzc2JBdzU0L1JETFN1bk1HTGFQQlNp?=
 =?utf-8?B?c2s0VWRISHVTQU9QWjNNb05Mc1NlZVRFWFlWd20vZXhDb3NuNndiYU02K015?=
 =?utf-8?B?bzZIZ3Q0djRVNk5jaTZ6ZFIwNkRUSWNveUVyUHl4Um81dG5ldGh0NWpqVXZp?=
 =?utf-8?B?bERCaEx5d1FQMXR6UlhHWFVtQkRqOG1tK1RjdnNNdVJSdHpXTG1BN2cxZktI?=
 =?utf-8?B?VGtUZkJHcWduVWJlaXNCbjR4TG5UNGtXZGRKbU9jZW5zc0NhQUFJdUh6VUJB?=
 =?utf-8?B?a1c2Tk1FZDFVMGd4UXBqTFNpUEkrdzAvMEY4YThOd21oajNBYm5keUt2a29Z?=
 =?utf-8?B?YjRQRWhLc2xZUko5cDRKOGxLUU1GWmtKakFqSEIrMzh1VjhkeExWTnZrdW1q?=
 =?utf-8?B?QVJub0s0U3R4RDdLS0hpbkdTYTd1MU5venNjaEs2Z1J1cTFmeVcwbk0vMXRk?=
 =?utf-8?B?T0dTcEkrenJhdnpQZWxtQmxQcklBL0t6TW5acjRNMW0rMHlYQ3NPVjY4Yk9N?=
 =?utf-8?B?THAxeFF3dytkcUVuRVdZZWdJek51U1czMDRZV040a0hsSmZ0ZG05S0hYMEg4?=
 =?utf-8?B?UEVRbTRieHMxbWRjYVNWOW0zMVZwL25peVE4cVgwN0M1QStraTljdlRLc3k4?=
 =?utf-8?B?UGhQaXZQRVE3NVFoNTZOeTJSMlprVjZnVm5qcW44c2YxUUhzbmNpWXZsa29j?=
 =?utf-8?B?R2VrZXh1Q3RtUE9POXAzMHhtdUdSdTUycjJPejRiZ08wY294NFNlZ1I0KzY2?=
 =?utf-8?B?OHQrTHhoUVZLTWVkYXhRcGsydlp3YjlwdzdlcVZYbXVrRW9Dc1JoWURtM2wz?=
 =?utf-8?B?RTlkN1o3NlZUTHRaWllCeGY5TlJOYzhMeDlESWpyem1OMnBFUGdzVXZ6UVlD?=
 =?utf-8?B?dXZlcjlKZHFJc0pwTTdiSVpKSGNuWVh0Vy9uY3hwbEVWb1BkRld4NkVWZVVi?=
 =?utf-8?B?SUNNVUtmVzkrTk5EeHZEQ0Q4bERrQ050OWgwQUIvZUNFcDl6dFBRalVjWEZk?=
 =?utf-8?B?Tklua2Q3b1dJbXllR01XZXU1WDQzaEJZYUJMazU0QkdqdWZIWFRaQm1YV1ZM?=
 =?utf-8?B?MlFJZEx0eFZ6d2VLQ1p1MzRaWFhyemJVcTlEZUEzVWhHb0FvQnowcHFYZ3NB?=
 =?utf-8?B?UU54NmJoRWhxRHlJRWxQMHFuR1A3d0xmdThoSjgxWWJXRDAvU2lKRWN5aitD?=
 =?utf-8?B?V1VPY3V4cDN1cmVmNm52d0RpWE4yK09udHZ5Wjgra2Z1d1VXNFdxOTZGczJH?=
 =?utf-8?B?YnJtcmRGTjV4dEx3SWs2dzRjVDVZSzUrYmYvOTRlS1Facm5oa1VFdlBjaFM3?=
 =?utf-8?B?T25KaHBkZ0JzUGRsc2s1SWZjUGI4bEsxd0l1cjQvZmNuSEVHdS9MUXpwcVBa?=
 =?utf-8?B?bkVzMzVJUElJYUc5OUxFUWY1UjNYelZOYXhZOVBlUXJ0Ti95Yjh1cHRZcEJU?=
 =?utf-8?B?VnU2dFp4MFl5Lyt2NzduMnNmNG12azhQcnhYdEVCVTJZUUJlMy9RcFdxSlhK?=
 =?utf-8?B?T1VCRWI3MW5pL3VFcTRoMU1zeFhORHhmR1U3UlBycENRMlBIbVBISGZHZkU5?=
 =?utf-8?B?eXFNSFU5Q29pSmdmV1d0RFEvRTVBZkJRNlMxWjRTQlIwQXVEeWFqOFJXRXEy?=
 =?utf-8?B?NFlIWVU4YXdtSUtDdFRsVCtyWkYzR0ZTUW1iOWJ5UGFkTnlrLzlxK3Y0eEZy?=
 =?utf-8?B?MWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cc98b6e7-d243-4882-6d13-08dc423b1e32
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2024 02:21:25.8297
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QNz3A3vBbJupSw1mNU5kqvlpRsUtGvGMdTycAlcRg5KvUjSvkZWuCWD72EZ3h2UKq4HEaspy0s0Zi36YCqnIGw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5233
X-OriginatorOrg: intel.com


On 3/12/24 10:15, Isaku Yamahata wrote:
>>> -
>>> -	__vmx_exit();
>>> -}
>>> -module_exit(vmx_exit);
>>> -
>>> -static int __init vmx_init(void)
>>> +int __init vmx_init(void)
>>>   {
>>>   	int r, cpu;
>>> -	if (!kvm_is_vmx_supported())
>>> -		return -EOPNOTSUPP;
>>> -
>>> -	/*
>>> -	 * Note, hv_init_evmcs() touches only VMX knobs, i.e. there's nothing
>>> -	 * to unwind if a later step fails.
>>> -	 */
>>> -	hv_init_evmcs();
>>> -
>>> -	/* vmx_hardware_disable() accesses loaded_vmcss_on_cpu. */
>>> -	for_each_possible_cpu(cpu)
>>> -		INIT_LIST_HEAD(&per_cpu(loaded_vmcss_on_cpu, cpu));
>>> -
>>> -	r = kvm_x86_vendor_init(&vt_init_ops);
>>> -	if (r)
>>> -		return r;
>>> -
>>>   	/*
>>>   	 * Must be called after common x86 init so enable_ept is properly set
>>>   	 * up. Hand the parameter mitigation value in which was stored in
>> I am wondering whether the first sentence of above comment should be
>> moved to vt_init()? So vt_init() has whole information about the init
>> sequence.
> If we do so, we should move the call of "vmx_setup_l1d_flush() to vt_init().
> I hesitated to remove static of vmx_setup_l1d_flush().
I meant this one:
 "Must be called after common x86 init so enable_ept is properly set up"

Not necessary to move vmx_setup_l1d_flush().

Regards
Yin, Fengwei


> --