Received-SPF: pass (google.com: domain of linux-kernel+bounces-99766-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <a4bdcf74-5c6f-4483-a4f0-8ad6558a3c8d@infradead.org>
Date: Mon, 11 Mar 2024 19:24:16 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [GIT PULL] EDAC updates for v6.9
Content-Language: en-US
To: Linus Torvalds <torvalds@linux-foundation.org>,
 Borislav Petkov <bp@alien8.de>
Cc: x86-ml <x86@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
 linux-edac <linux-edac@vger.kernel.org>
References: <20240311155651.GAZe8pw0urOnUZj1y_@fat_crate.local>
 <CAHk-=whTBKoHrBpMxh7OHQ=pcdy6K2zqqsJOZeCC4xSqRXb5Bg@mail.gmail.com>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <CAHk-=whTBKoHrBpMxh7OHQ=pcdy6K2zqqsJOZeCC4xSqRXb5Bg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 3/11/24 18:12, Linus Torvalds wrote:
> On Mon, 11 Mar 2024 at 08:57, Borislav Petkov <bp@alien8.de> wrote:
>>
>> -       return topology_die_id(err->cpu) % amd_get_nodes_per_socket();
>> +       return topology_amd_node_id(err->cpu) % topology_amd_nodes_per_pkg();
> 
> Ho humm. Lookie here:
> 
>     static inline unsigned int topology_amd_nodes_per_pkg(void)
>     { return 0; };
> 

and there's an extra/trailing ';'.

> that's the UP case.
> 
> Yeah, I'm assuming nobody tests this for UP, but it's clearly wrong to
> potentially do that modulus by zero.
> 
> So I made the merge also change that UP case of
> topology_amd_nodes_per_pkg() to return 1.
> 
> Because dammit, not only is a mod-by-zero wrong, a UP system most
> definitely has one node per package, not zero.
> 
>                Linus
> 

-- 
#Randy