Received-SPF: pass (google.com: domain of linux-kernel+bounces-99925-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Rex Nie <rex.nie@jaguarmicro.com>
To: james.morse@arm.com
Cc: fenghua.yu@intel.com,
	reinette.chatre@intel.com,
	ilpo.jarvinen@linux.intel.com,
	linux-kernel@vger.kernel.org,
	Rex Nie <rex.nie@jaguarmicro.com>
Subject: [PATCH v2] fs/resctrl: fix domid loss precision issue
Date: Tue, 12 Mar 2024 15:53:49 +0800
Message-Id: <20240312075349.977-1-rex.nie@jaguarmicro.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?kaMAGe4NFOaCfSoxrEuEeT8T853kctmr8Zw0bJCeP5c5+m+u27/+ngrKTKdN?=
 =?us-ascii?Q?BUI1l2JvGHTP4RGNbwDyCtnVkzOHKYW4LO7XcgTZWtHPK1SvEg5HML5M9zAj?=
 =?us-ascii?Q?Dg4AiXzfxNpIguSx1mX2zNTWDakKIHSilyMNcdJn4Mf+OpcXBwawFoFaFZj4?=
 =?us-ascii?Q?OgcSiJZHFqyymiQ4Co2734VbgUeYXL51P6OmNuJ+UHMwtLotaRZijGbbB+Q6?=
 =?us-ascii?Q?2//pVjO16ZoZ/7giPogCxtu21HPVGxo9G1yP5TWNKcPuQiOQgdFx6iP36tpE?=
 =?us-ascii?Q?Qz1SdXJ8nyLxjvVrZlfAT3l3kt5r9X0nGSREAY49llz6/DG6tRIOwf07+nfE?=
 =?us-ascii?Q?2+1RvalZ2HU4eMnKe6RFyYT56RTy4k2PkMYdttljlsvInbfiQ3bbqO+LNcIP?=
 =?us-ascii?Q?opxeOr4AN9N19k6lHZlmnmZb2T5fiGL6et941Mk5haQfzUuQYmamGhFZJEXi?=
 =?us-ascii?Q?wnqmFXGu3V10IJVyPguyp7kqSY1cU6/G4A0yTtvZhTme4NlryUXNAg93md2G?=
 =?us-ascii?Q?rKjhzxMLCaRgh6R1pw8LvFDh1Ti+l8MfSdYYLB5kls7BwBcnIcnDXT59KLVv?=
 =?us-ascii?Q?c2+FA5SJo21XdhoIR41SWkxY/A8UUfPBoUNyvINNMJwrNbFZx079hXs+zPW5?=
 =?us-ascii?Q?D39PnJdxo8ifPMsvHj06HrZjru4w8HorJkHWFV7frS6oBzMaHG7on+eJdfeb?=
 =?us-ascii?Q?g3tDfc6a0DRuSIHpTmYbRSdVKpQ+EJT6IErQb/vXQw7kIrP3NQPWzDCWfV6a?=
 =?us-ascii?Q?j8nTWZ88J6xJ74iTPI36bwTQgLrktF9i0MIsRurLv6OdYXEffylz5hK9bmgw?=
 =?us-ascii?Q?NN1lDsJRR+c3CnTqjIWcmw52W3xh/XcZUk8q29Lb9tW6SI5+PYR7Sd2IFfHL?=
 =?us-ascii?Q?S4p9nolP7EReaCVuQ6sFpoA5/xGjlz763RxbIIJfSjtkwDa9EVyFOmhoCGfw?=
 =?us-ascii?Q?gRaJiLhi7djq3/W595gOZDTDXPcb22DTsHNZtz3OIC2pTrFt3GIZqtcQSvWL?=
 =?us-ascii?Q?ISq3bYm1z/UGe498o9mTj3nvmfz/vYdDIwjB4LRRD4B5foY63w1fHJAknlh2?=
 =?us-ascii?Q?VYW7E4mSwXVoj6CJoFqSxaDEFqzt8nqdzdAbWPW0nNo20Tp5DHmVmHLg0rY+?=
 =?us-ascii?Q?gOq13e3mO0vV5MdgHs7hlEd2+6YciZSkWW5bA1hsZn5hEGZwgCvzam9JKJuj?=
 =?us-ascii?Q?URZhDrCzDYtv3rcS5RqVutiXX6RshlUQRWFPKwHYbWkbrmBEatAmq8pECD9V?=
 =?us-ascii?Q?PQKpNUvMe8o/TqcV6IAnKhCBfdqECKZek97IgtTs0lcN8OMMdiHMSvqibFA/?=
 =?us-ascii?Q?kYMa5mBuZ+PUjExawoOr/ofglhs1M/tGzuqm4xscfhVnYYLQDSh+8oKUcor9?=
 =?us-ascii?Q?MSVQc7CUP4LCxYSlC2SXiq9abXadkGAc/6FLpfT4qWVNOl3uNcicWRzLLxY8?=
 =?us-ascii?Q?nqXczBiEInzO71XZpz1SOJ/M1GdK+63T5gJf9GOzyq7NXOc/FA9Gj6cu0YGZ?=
 =?us-ascii?Q?wqgp989HTCyBSViYXbnNN3r+x8oHD2liRGpc+txT8NKr2vstrj6zamYwOcuQ?=
 =?us-ascii?Q?eUQtAVjPRyp48c74GeO6MEV/X5OHp5ID45G35+b9?=
X-OriginatorOrg: jaguarmicro.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 63b509c5-8925-4496-f8cb-08dc42698fc9
X-MS-Exchange-CrossTenant-AuthSource: KL1PR0601MB5773.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2024 07:53:53.2619
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 1e45a5c2-d3e1-46b3-a0e6-c5ebf6d8ba7b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: R7KeTaF+PSrHFsecuGEm/RpGG8l1w7bmshQFYY+hviJstNvaMi2A4OPXDMWpk+LCy0/zTc0BCSV77r6V60rkUg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB5250

Below statement from mkdir_mondata_subdir function will loss precision,
because it assigns int to 14 bits bitfield.
	priv.u.domid = d->id;

On some platforms(e.g.,x86), the max cache_id is the amount of L3 caches,
so it is not in the range of 0x3fff. But some platforms use higher
cache_id, e.g., arm uses cache_id as locator for cache MSC. This will
cause below issue if cache_id > 0x3fff likes:
/sys/fs/resctrl/mon_groups/p1/mon_data/mon_L3_1048564 # cat llc_occupancy
cat: read error: No such file or directory

This is the call trace when cat llc_occupancy:
rdtgroup_mondata_show()
	domid = md.u.domid
	d = resctrl_arch_find_domain(r, domid)

d is null here because of lossing precision

Signed-off-by: Rex Nie <rex.nie@jaguarmicro.com>
---
 fs/resctrl/internal.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/resctrl/internal.h b/fs/resctrl/internal.h
index 7a6f46b4edd0..096317610949 100644
--- a/fs/resctrl/internal.h
+++ b/fs/resctrl/internal.h
@@ -94,7 +94,7 @@ union mon_data_bits {
 	struct {
 		unsigned int rid		: 10;
 		enum resctrl_event_id evtid	: 8;
-		unsigned int domid		: 14;
+		u32				domid;
 	} u;
 };
 
-- 
2.34.1