Received-SPF: pass (google.com: domain of linux-kernel+bounces-99929-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 12 Mar 2024 15:49:23 +0800
From: Yujie Liu <yujie.liu@intel.com>
To: Amir Goldstein <amir73il@gmail.com>
CC: kernel test robot <lkp@intel.com>, <oe-kbuild-all@lists.linux.dev>,
	<linux-kernel@vger.kernel.org>, overlayfs <linux-unionfs@vger.kernel.org>,
	Miklos Szeredi <miklos@szeredi.hu>
Subject: Re: fs/overlayfs/copy_up.o: warning: objtool: ovl_copy_up_tmpfile()
 falls through to next function ovl_create_index.cold()
Message-ID: <ZfAJA75rk5qPLWBM@yujie-X299>
References: <202402260556.0rujs05e-lkp@intel.com>
 <CAOQ4uxj-PaBHNjYYVAVc=an3BZTt-C9p9etWAmhZc1udU7PN5A@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAOQ4uxj-PaBHNjYYVAVc=an3BZTt-C9p9etWAmhZc1udU7PN5A@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NTFDcTEvWlRtZXFsSlhaVEdpL281VysyZ0ZyU1Zkbm1wOENFRTR5TWNNcFNB?=
 =?utf-8?B?SGFJVWhjYnlkKzdLMEN0RWpjZ1NNZ3FSUHAxWDU5K3NYWHA2RWV4NVUzQWRG?=
 =?utf-8?B?anVKS1A0ZzJ1UjFSOWdNOVd2MlFhWHhYV0xHcWg2eEp6N1VuOXNSSHQvMEdi?=
 =?utf-8?B?T3hCU0pYNHVoanlJMitIRlZLZ3RBdWlyOUVFcENJV0FuVkVjNWFpVXo1ajlJ?=
 =?utf-8?B?Q1M2YTRnVkx2RWswSlpVcFg0OWhlTXdyUzJIRVZBcUg2eEhoRmhnVnVNd0Vu?=
 =?utf-8?B?Qy9BTjdEb2puNWxRVDQ0K05zODJZWFl1MHp0ZEpUb0lXaGxmLzh3NVdHSGdE?=
 =?utf-8?B?akRFelI4eE82NnQyQjlNTjh0VXU3WURNazNKd3FCQmlwWVJZUlhQeEpXa0F1?=
 =?utf-8?B?UEcyUE5MTXc3VzZSZ3l0Zm1zcEpwSmJIbnpUZGdDS0pGdnVXd0xOcHBTOTRI?=
 =?utf-8?B?dVZSZHc2dXJlUFB6Yk1WVEVOQ3BaNmYxNFJkUmx6UEl2Y3V2cWhqS05OYitR?=
 =?utf-8?B?MHl6TTUzRkd1N3dJMXhSQlYrWWRDNnFrMkRBMyt2YXVjbGlLL1VvNFRMN2FJ?=
 =?utf-8?B?Z3lHRUJrNjQ2cmxxaTVQZGdVR3pJeGlwMGZyL2hNcnBJMmVJaisvVnc1bS95?=
 =?utf-8?B?WFppUW9oS1htb0V1dmJaNHhBTE5yWXJCRUxVaUlpaUl0Y3N6QzdQUDFhSytO?=
 =?utf-8?B?aER3S1hxUENTa2U4cTVaU0pZd3N3NFZVSmlyYWxSWUZCaXZqTkFYdlVrU295?=
 =?utf-8?B?L3NJOHR2NEtzaXpsSkVoZmtkYmRxOTJNVlA1c0xtSDhaVlloVmFWdzBFVGx6?=
 =?utf-8?B?RnlFN0xOYjEzS1hIS1VtdHJwNkpMOUpiSk80OUNFWDBPODFNMDd1LzduWXF2?=
 =?utf-8?B?bWp2K2NVZGRhWjhMLzZwTW9LQmRvQ1g1ZmoxeFVXMHNpT1Z4UUwxeDFoaWlF?=
 =?utf-8?B?cnhLdkdIMW94NWcwK3RicXBuL1h4NFlXelJoVWJzdVhYWlBLNHpqeGpLbG95?=
 =?utf-8?B?RUFwWE1xR0p0eUFNYTVZVFBtVmN4YXVpY2xVY1RKVXFmcm5GV3A4R09JbG13?=
 =?utf-8?B?WVJ6aDB0TU1ZelVUd0tTN1MvU1hSaGpFM2VoT3BQMk1lNVl2T2ZoR3Vld0N0?=
 =?utf-8?B?Y09NbnVZRnh1NEtwWXRWSlNqVklKQzA5WUVhTjMyS21jbjF4WURqYjc4Wkdp?=
 =?utf-8?B?azFDWFVwdDFsbWtnQ1FXa3FsVSs3NmtOZFd3MlpIWndPWmswNnQ2MUM5dHFm?=
 =?utf-8?B?RmtKQlhyTTBPZmpJYlBUYTI5Mjg1QzhvcVRPUlFBZUVXZFAwVFlML0RjQzVK?=
 =?utf-8?B?WjhqcWJMWGEvV2V6WUVNa1NpUkVlNnVRb3Z0dnFwNGtQZys5Vzl5T0dRU2F1?=
 =?utf-8?B?SmdYSllhL3N5M3lwSmlJZCtMT2wwdHBUM0g5QzB4N2RxSGpCNUVEaFYwRlF5?=
 =?utf-8?B?WEpucmxCaitJUi8xU1h2SE9YYWpCcGNRMlRMSDFFQ2hQMjIwWEFhbm90UWtN?=
 =?utf-8?B?QzY5SkZzMjVNUWlBbmpnckdZNkxXU2w1aTcyOElMM0Vpc21ZQzVOMmcvQnA1?=
 =?utf-8?B?OVR5SDBZWkxqY2NuaUFQOFJzUUdNRlBESnlhUFEzT1drbDhwVFlNaWwyQzVU?=
 =?utf-8?B?eC8xL0tRYUhWNk84MFdNVnEwN0V3dkVGSVBMcTAvU2tZVHlySVMyR3hFQ25w?=
 =?utf-8?B?dnlsR1FJVFZUNFh4VjJ0ckgvRVB6OWpRcWRlRXBuVjhqY0QvYWVaOHg4NVI0?=
 =?utf-8?B?eEZrMjJ0SXZUT0taaGFHZzFoclNDY0wwdnhtU21adFFMRFRuSk4vK3ZYT09r?=
 =?utf-8?B?VGtMeWlPaWFROUlQcnMybjZwajJBY1NEcU1iRnBReVRXMWx6WU10L3JHTnpo?=
 =?utf-8?B?ZTY4ck8wRWRZTHNPbTZTcWRxQW9UZ0NENFZFeFZCSHdXOWFTMk0yWG1Ra3kw?=
 =?utf-8?B?aU9qczY2UkoxVnFxcXd1QS9obDBlTVBwQ2dCQjdzRHVGK3RlcXJKODJEdDJL?=
 =?utf-8?B?NUVxZDBSQ3pzanY5bkxyUG4xNkYzM0tPaHpqMXBNNW04OEpuTms1RURmR2tp?=
 =?utf-8?B?RGRxQzMrT2g0b3RoR0dSd25melR6YndndFA1S2JTNzZ2aGNLdnFQTUxZd2dN?=
 =?utf-8?Q?UC9xPNIro0JpO4JvHCrSisAXN?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f72bb2ba-940d-4460-cd0c-08dc4269e131
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6392.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2024 07:56:10.0211
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DClb8/JKjP7rlb9WtiMVSFdrs0B4TK9GWc5PfagECA6LleqMH34HMq2PSPHLkZuCaxMBiAFpH+ksC8W7+UrsmQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6569
X-OriginatorOrg: intel.com

Hi Amir,

On Tue, Feb 27, 2024 at 03:56:53PM +0200, Amir Goldstein wrote:
> On Sun, Feb 25, 2024 at 11:25 PM kernel test robot <lkp@intel.com> wrote:
> >
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   70ff1fe626a166dcaadb5a81bfe75e22c91f5dbf
> > commit: 5b02bfc1e7e3811c5bf7f0fa626a0694d0dbbd77 ovl: do not encode lower fh with upper sb_writers held
> > date:   4 months ago
> > config: x86_64-buildonly-randconfig-r001-20230616 (https://download.01.org/0day-ci/archive/20240226/202402260556.0rujs05e-lkp@intel.com/config)
> > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240226/202402260556.0rujs05e-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202402260556.0rujs05e-lkp@intel.com/
> >
> > All warnings (new ones prefixed by >>):
> >
> > >> fs/overlayfs/copy_up.o: warning: objtool: ovl_copy_up_tmpfile() falls through to next function ovl_create_index.cold()
> >
> 
> I have no idea what this is about.
> Does not seem related to the regressing commit.
> This:
> https://lore.kernel.org/lkml/caa4ec6c687931db805e692d4e4bf06cd87d33e6.1460729697.git.jpoimboe@redhat.com/
> suggest that it might be a compiler bug?

Sorry for our late reply. We rechecked this case and found that this can
only be reproduced by a specific version of gcc. gcc-12.2.0 can
reproduce it while gcc-11.3.0 and gcc-13.2.0 cannot. This may indeed be
a flaw in gcc-12. Attached part of the disassembly of the object file
built by gcc-12. We will configure the bot to ignore this warning to
avoid false positives.

Disassembly of section .text.unlikely:
..

00000000000000e6 <ovl_copy_up_metadata.cold>:
..
 155:   e8 00 00 00 00          call   15a <ovl_copy_up_metadata.cold+0x74>
 15a:   80 fb 01                cmp    $0x1,%bl
 15d:   0f 86 00 00 00 00       jbe    163 <ovl_copy_up_metadata.cold+0x7d>
 163:   e8 00 00 00 00          call   168 <ovl_copy_up_metadata.cold+0x82>
 168:   0f b6 f3                movzbl %bl,%esi
 16b:   48 c7 c7 00 00 00 00    mov    $0x0,%rdi
 172:   e8 00 00 00 00          call   177 <ovl_copy_up_metadata.cold+0x91>
 177:   e9 00 00 00 00          jmp    17c <ovl_copy_up_tmpfile.cold>

000000000000017c <ovl_copy_up_tmpfile.cold>:
 17c:   e8 00 00 00 00          call   181 <ovl_create_index.cold>  <--

0000000000000181 <ovl_create_index.cold>:
 181:   e8 00 00 00 00          call   186 <ovl_create_index.cold+0x5>
 186:   0f b6 f3                movzbl %bl,%esi
 189:   48 c7 c7 00 00 00 00    mov    $0x0,%rdi
 190:   e8 00 00 00 00          call   195 <ovl_create_index.cold+0x14>
 195:   e9 00 00 00 00          jmp    19a <ovl_copy_up_workdir.cold>


Best Regards,
Yujie