Received-SPF: pass (google.com: domain of linux-kernel+bounces-99920-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <b25ce24d-12d1-4112-9c35-30a75634f9fc@quicinc.com>
Date: Tue, 12 Mar 2024 13:18:49 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp: Add missing hs_phy_irq in USB
 nodes
To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring
	<robh+dt@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio
	<konrad.dybcio@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>
CC: <devicetree@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <quic_ppratap@quicinc.com>,
        <quic_jackp@quicinc.com>
References: <20240219075720.640529-1-quic_kriskura@quicinc.com>
Content-Language: en-US
From: Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>
In-Reply-To: <20240219075720.640529-1-quic_kriskura@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 2/19/2024 1:27 PM, Krishna Kurapati wrote:
> Recent binding update [1] indicates that there are hs_phy_irq
> present in primary and secondary usb controllers of sc8280xp.
> 
> Add the missing hs_phy_irq for these controllers. Since the driver
> doesn't use this interrupt, this change has been only compile
> tested.
> 
> [1]: https://lore.kernel.org/all/20231227091951.685-2-quic_kriskura@quicinc.com/
> 
> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
> ---
>   arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index a5b194813079..62e2b99915af 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -3361,10 +3361,12 @@ usb_0: usb@a6f8800 {
>   			assigned-clock-rates = <19200000>, <200000000>;
>   
>   			interrupts-extended = <&intc GIC_SPI 804 IRQ_TYPE_LEVEL_HIGH>,
> +					      <&intc GIC_SPI 805 IRQ_TYPE_LEVEL_HIGH>,
>   					      <&pdc 14 IRQ_TYPE_EDGE_BOTH>,
>   					      <&pdc 15 IRQ_TYPE_EDGE_BOTH>,
>   					      <&pdc 138 IRQ_TYPE_LEVEL_HIGH>;
>   			interrupt-names = "pwr_event",
> +					  "hs_phy_irq",
>   					  "dp_hs_phy_irq",
>   					  "dm_hs_phy_irq",
>   					  "ss_phy_irq";
> @@ -3421,10 +3423,12 @@ usb_1: usb@a8f8800 {
>   			assigned-clock-rates = <19200000>, <200000000>;
>   
>   			interrupts-extended = <&intc GIC_SPI 811 IRQ_TYPE_LEVEL_HIGH>,
> +					      <&intc GIC_SPI 790 IRQ_TYPE_LEVEL_HIGH>,
>   					      <&pdc 12 IRQ_TYPE_EDGE_BOTH>,
>   					      <&pdc 13 IRQ_TYPE_EDGE_BOTH>,
>   					      <&pdc 136 IRQ_TYPE_LEVEL_HIGH>;
>   			interrupt-names = "pwr_event",
> +					  "hs_phy_irq",
>   					  "dp_hs_phy_irq",
>   					  "dm_hs_phy_irq",
>   					  "ss_phy_irq";

Gentle ping for review.
Thanks in advance.

- Krishna