Received-SPF: pass (google.com: domain of linux-kernel+bounces-99945-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <cover.1710194084.git.u.kleine-koenig@pengutronix.de> <44de2d4c1fed6fe96b68ba9ad768d297b8f392a5.1710194084.git.u.kleine-koenig@pengutronix.de>
In-Reply-To: <44de2d4c1fed6fe96b68ba9ad768d297b8f392a5.1710194084.git.u.kleine-koenig@pengutronix.de>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Tue, 12 Mar 2024 09:17:54 +0100
Message-ID: <CAMuHMdVvmN2xns_76zSDpUX-v8V16mSP12A=Y4gght9cdgNb+A@mail.gmail.com>
Subject: Re: [PATCH 3/3] auxdisplay: img-ascii-lcd: Convert to platform remove
 callback returning void
To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Cc: Andy Shevchenko <andy@kernel.org>, Paul Burton <paulburton@kernel.org>, linux-kernel@vger.kernel.org, 
	kernel@pengutronix.de
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Uwe,

On Mon, Mar 11, 2024 at 10:59=E2=80=AFPM Uwe Kleine-K=C3=B6nig
<u.kleine-koenig@pengutronix.de> wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>

Thanks for your patch!

> --- a/drivers/auxdisplay/img-ascii-lcd.c
> +++ b/drivers/auxdisplay/img-ascii-lcd.c
> @@ -279,13 +279,12 @@ static int img_ascii_lcd_probe(struct platform_devi=
ce *pdev)
>   *
>   * Return: 0

Please remove this line.

>   */
> -static int img_ascii_lcd_remove(struct platform_device *pdev)
> +static void img_ascii_lcd_remove(struct platform_device *pdev)
>  {
>         struct img_ascii_lcd_ctx *ctx =3D platform_get_drvdata(pdev);
>
>         sysfs_remove_link(&pdev->dev.kobj, "message");
>         linedisp_unregister(&ctx->linedisp);
> -       return 0;
>  }
>
>  static struct platform_driver img_ascii_lcd_driver =3D {
> @@ -294,7 +293,7 @@ static struct platform_driver img_ascii_lcd_driver =
=3D {
>                 .of_match_table =3D img_ascii_lcd_matches,
>         },
>         .probe  =3D img_ascii_lcd_probe,
> -       .remove =3D img_ascii_lcd_remove,
> +       .remove_new =3D img_ascii_lcd_remove,
>  };
>  module_platform_driver(img_ascii_lcd_driver);

With the above fixed:
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds