Received-SPF: pass (google.com: domain of linux-kernel+bounces-99960-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <tencent_AA5D14EAA36D58807959EE9AFC9E07548108@qq.com>
Date: Tue, 12 Mar 2024 16:42:01 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] KVM: x86/mmu: treat WC memory as MMIO
Content-Language: en-US
To: Sean Christopherson <seanjc@google.com>
Cc: dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org,
 tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org,
 hpa@zytor.com, rdunlap@infradead.org, akpm@linux-foundation.org,
 bhelgaas@google.com, mawupeng1@huawei.com, linux-kernel@vger.kernel.org,
 pbonzini@redhat.com, peterz@infradead.org, bhelgaas@google.com,
 kvm@vger.kernel.org
References: <tencent_4B50D08D2E6211E4F9B867F0531F2C05BA0A@qq.com>
 <Ze8vM6HcU4vnXVSS@google.com>
From: francisco flynn <francisco_flynn@foxmail.com>
In-Reply-To: <Ze8vM6HcU4vnXVSS@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 2024/3/12 00:20, Sean Christopherson wrote:
> On Mon, Mar 11, 2024, francisco_flynn wrote:
>> when doing kvm_tdp_mmu_map for WC memory, such as pages
>> allocated by amdgpu ttm driver for ttm_write_combined
>> caching mode(e.g. host coherent in vulkan),
>> the spte would be set to WB, in this case, vcpu write
>> to these pages would goes to cache first, and never
>> be write-combined and host-coherent anymore. so
>> WC memory should be treated as MMIO, and the effective
>> memory type is depending on guest PAT.
> 
> No, the effective memtype is not fully guest controlled.  By forcing the EPT memtype
> to UC, the guest can only use UC or WC.  I don't know if there's a use case for

Well,it's actually the host mapping memory WC and guest uses WC,
one use case is virtio-gpu host blob, which is to map physical GPU buffers into guest

> the host mapping memory WC while the guest uses WB, but it should be a moot point,
> because this this series should do what you want (allow guest to map GPU buffers
> as WC).
> 
> https://lore.kernel.org/all/20240309010929.1403984-1-seanjc@google.com
> 

yes, this is what i want, but for virtio-gpu device, if we mapping WC typed 
GPU buffer into guest, kvm_arch_has_noncoherent_dma would return false, 
so on cpu without self-snoop support, guest PAT will be ignored, the effective
memory type would be set to WB, causing data inconsistency.

+	if (!static_cpu_has(X86_FEATURE_SELFSNOOP) &&
+	    !kvm_arch_has_noncoherent_dma(vcpu->kvm))
                return (MTRR_TYPE_WRBACK << VMX_EPT_MT_EPTE_SHIFT) | VMX_EPT_IPAT_BIT;


>> Signed-off-by: francisco_flynn <francisco_flynn@foxmail.com>
>> ---
>>  arch/x86/include/asm/memtype.h | 2 ++
>>  arch/x86/kvm/mmu/spte.c        | 5 +++--
> 
> Please use get_maintainers.pl.

sure.

> 
>>  arch/x86/mm/pat/memtype.c      | 8 ++++++++
>>  3 files changed, 13 insertions(+), 2 deletions(-)