Received-SPF: pass (google.com: domain of linux-kernel+bounces-99983-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 12 Mar 2024 12:01:14 +0300
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Alison Schofield <alison.schofield@intel.com>
Cc: "Felix N. Kimbu" <felixkimbu1@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: p80211conv: Rename local foo to decrypt_check
Message-ID: <0ae5c6f0-dfb3-4c98-9798-8379f6206256@moroto.mountain>
References: <Ze9Ie67PCSvBU+og@MOLeToid>
 <Ze+JxSpqc/eHfCKn@aschofie-mobl2>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Ze+JxSpqc/eHfCKn@aschofie-mobl2>

On Mon, Mar 11, 2024 at 03:46:29PM -0700, Alison Schofield wrote:
> On Mon, Mar 11, 2024 at 07:07:55PM +0100, Felix N. Kimbu wrote:
> > This change renames the local variable foo to decrypt_check in functions
> > skb_ether_to_p80211(...) and skb_p80211_to_ether(...), giving intuitive
> > meaning to the identifier.
> 
> 'rc' is typically used for cases like this. If the name of the function
> being called is reasonably intuitive, then 'rc' suffices for the return
> value.
> 
> > 
> > It also indents the parameters to match the the opening parentheses.
> 
> 'Also' signals that this patch is trying to do more than one thing.
> One type of 'thing' per patch please.
> 

The name change did force a re-indent.  The v2 re-indent was wrong too
though.

regards,
dan carpenter