Received-SPF: pass (google.com: domain of linux-kernel+bounces-99995-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240311161214.1145168-1-hannes@cmpxchg.org> <20240311161214.1145168-2-hannes@cmpxchg.org>
In-Reply-To: <20240311161214.1145168-2-hannes@cmpxchg.org>
From: Nhat Pham <nphamcs@gmail.com>
Date: Tue, 12 Mar 2024 16:15:58 +0700
Message-ID: <CAKEwX=N+h4OvNQG_=gBmu7ZF9YMY_9tffcPOMAASotSoaK8PHg@mail.gmail.com>
Subject: Re: [PATCH 2/2] mm: zpool: return pool size in pages
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, Yosry Ahmed <yosryahmed@google.com>, 
	Chengming Zhou <zhouchengming@bytedance.com>, linux-mm@kvack.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 11, 2024 at 11:12=E2=80=AFPM Johannes Weiner <hannes@cmpxchg.or=
g> wrote:
>
> All zswap backends track their pool sizes in pages. Currently they
> multiply by PAGE_SIZE for zswap, only for zswap to divide again in
> order to do limit math. Report pages directly.

I've always found this to be weird. Perhaps the original author of
this API wants to support more fine-grained memory consumption
tracking?

>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>

Anyway, let's just work with realities, rather than hypotheticals :)
With the renaming fixlet:
Reviewed-by: Nhat Pham <nphamcs@gmail.com>