Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp945504lql; Tue, 12 Mar 2024 02:50:54 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVX+dO4XB3/WqSIk9sw2o7A64NlcgnK6BTqU50p8js5lQj+/bkWBKMoNHB8vyigaNGSzKmo2CwVZReVTQ4PqAcDwzQ9XkH7r+dmIoNgDg== X-Google-Smtp-Source: AGHT+IE44qObmZGVlbiRUgr6nwAHbYX85ITZ3QmJIuA/ZjH6ySjPKfEZgpV7ZCRow6+HIZNV5l1j X-Received: by 2002:a0c:ca06:0:b0:690:c678:f867 with SMTP id c6-20020a0cca06000000b00690c678f867mr9803223qvk.45.1710237054702; Tue, 12 Mar 2024 02:50:54 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710237054; cv=pass; d=google.com; s=arc-20160816; b=dDNh7vg+La/d8kQ1FXKHhIc/9dfXmE7D34BEBAq2iXCAfz7gMJrW0IA5WaTg/WwSkl otSlqMgmC4O1/e6/dW1GOp32A5nQG0P6jP73ea9MMpD3htHZgTYLHY8d5/rDEyBhxdsW TmGTl4GAKeIDlNelJn08YIKpz+z5hCcPII4ChjzVsv0GzHFBgfvb1SCH7vABiPkSM+/H knJW+v9p6ZQKi1QFHCOhCg9Ar986Bk+ERFFpvlXgchFCKganqYUWLyT7nn+OSjXbGp+E 4/sE3WQ0p/btXFYMQ10g7bRnQQKFV+s8DtGdjB5U2LfzvU+F009QIOAxkov6KWJ6hv3y wunw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=7f1RnSPnddBT/E4wa1mDT+80nYIww3idRlE1zBBWP20=; fh=rfZQOZRfJbKEkle8mV+Sl0ZUEvWrUuOowIPK13n80vc=; b=MUjb03EvYSIcZ9yWewmOgH2j41GXcQQHyBkaxCZEASl2hja9GTwV05HkGlbblmavkY kBEfmzc5eTud+zUKZBRMBW0g3S+4kTqdppO9cWmMpuiu4Bqc4/VvIkP2sHXnKm/TCgW8 VVqOizUhFTqPaMdlwtdY/7xkhGJb5lw5oLlTgLEcykGNw4GwF5DFoYVea508ef8vX1ZU OggcLesAJSmBu5Drz6ApDv10Kmyr+bGn6o9YWldhHuUvDQ7iyjb7adOoavucBVmtQ6lA Gtly1AmBTNhB3p7ccMR4ogmHVefte57pqUaR/PsviKPaNFkUYirC7QHyrbW47jzCMOCa IwAA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-kernel+bounces-100069-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100069-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id q6-20020a05621419e600b0068f30e856fdsi7139259qvc.452.2024.03.12.02.50.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 02:50:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-100069-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-kernel+bounces-100069-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100069-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 6FB631C2203E for ; Tue, 12 Mar 2024 09:50:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 110D278683; Tue, 12 Mar 2024 09:49:35 +0000 (UTC) Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BA0B78288 for ; Tue, 12 Mar 2024 09:49:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.154.21.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710236974; cv=none; b=daAHaGrmxtQkZ+31VGp0HOjI7sMcjWXdw/2WccqnlszxTVFSzQ0SEUmu+tzCwRAHrBU+oRAzmfclAModh+LMGr2ydxegxE2LyhQYT+xca+ByXGlEgDN5p0Xmb6Bceytf9De79N8vSjX7HwS/xvep8v7eLorGR6qLixeG3hilQRs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710236974; c=relaxed/simple; bh=TIL3iYxP4zmJ6nFF1TGQYikRpF2lwNTb6W5dM6L1DN8=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=A0h7q+0gPvCJO+MjaskZiJ5I+E3y47nt6jja1+mdFyFqyzZtBprzGPZMlEo/XgsBb+PCWMvXrZN6j6lBJ9pVyFP0CzMr70qruAH5ns/TO1GZaBmX+Bfartk4lV+hUrqtWmOPsw9NRDswmq3xAwBSAiD+a5J06mYLqaO59jVgugQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru; spf=pass smtp.mailfrom=omp.ru; arc=none smtp.client-ip=90.154.21.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from localhost.localdomain (78.37.41.175) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Tue, 12 Mar 2024 12:49:14 +0300 From: Roman Smirnov To: CC: Roman Smirnov , Sergey Shtylyov , Subject: [PATCH] fixp-arith: prevent division by zero in fixp_sin32_rad() Date: Tue, 12 Mar 2024 12:48:52 +0300 Message-ID: <20240312094852.15400-1-r.smirnov@omp.ru> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 03/12/2024 09:25:15 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 184094 [Mar 12 2024] X-KSE-AntiSpam-Info: Version: 6.1.0.4 X-KSE-AntiSpam-Info: Envelope from: r.smirnov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 10 0.3.10 53c821b925e16276b831986eabc71d60ab82ee60 X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: 78.37.41.175:7.1.2;127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;omp.ru:7.1.1 X-KSE-AntiSpam-Info: ApMailHostAddress: 78.37.41.175 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 03/12/2024 09:29:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 3/12/2024 6:48:00 AM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit The parameter twopi can have a zero value. It is necessary to prevent division by zero. Found by Linux Verification Center (linuxtesting.org) with Svace. Signed-off-by: Roman Smirnov --- include/linux/fixp-arith.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/fixp-arith.h b/include/linux/fixp-arith.h index e485fb0c1201..434eee8bd9ef 100644 --- a/include/linux/fixp-arith.h +++ b/include/linux/fixp-arith.h @@ -118,8 +118,9 @@ static inline s32 fixp_sin32_rad(u32 radians, u32 twopi) /* * Avoid too large values for twopi, as we don't want overflows. + * Also prevent division by zero. */ - BUG_ON(twopi > 1 << 18); + BUG_ON(!twopi || twopi > 1 << 18); degrees = (radians * 360) / twopi; tmp = radians - (degrees * twopi) / 360; -- 2.34.1