Received-SPF: pass (google.com: domain of linux-kernel+bounces-100083-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <ae49f714-24c9-485d-b2f3-a319a53ba1a3@amd.com>
Date: Tue, 12 Mar 2024 15:29:26 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/4] perf vendor events amd: Add Zen 5 core events
To: Ian Rogers <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
 peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
 namhyung@kernel.org, mark.rutland@arm.com,
 alexander.shishkin@linux.intel.com, jolsa@kernel.org,
 adrian.hunter@intel.com, eranian@google.com, ravi.bangoria@amd.com,
 ananth.narayan@amd.com
References: <cover.1710133771.git.sandipan.das@amd.com>
 <0d18c3a93083f12481f27dcc5f5795877fa02b90.1710133771.git.sandipan.das@amd.com>
 <CAP-5=fUV=6my-+z0Qc+TS2+CbKT1DqsLbpHZrZLitqpAnDd2-A@mail.gmail.com>
Content-Language: en-US
From: Sandipan Das <sandipan.das@amd.com>
In-Reply-To: <CAP-5=fUV=6my-+z0Qc+TS2+CbKT1DqsLbpHZrZLitqpAnDd2-A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VytFQW96eHl6dnBqY2VMM3ZjYVRwaW1vaWpUMWg5UnFnRTJBUGlieHAwQS9j?=
 =?utf-8?B?dVJmMnJBdm9hT3M5eVMzcnhzUHhvT0RvenE0a1hIcTZuZXFMVnU0VmpOQ1BL?=
 =?utf-8?B?bWY0b2t1STFjd01kSllOVC95cWpuWTBtcE1FU0xNWjg1TmNXVll3d2xoODN3?=
 =?utf-8?B?MTE4N0c2SEl0OVEraGI2TXQ3OXV0TllkcDUvSzZ0MjhZNFIxeGJ3RXJ3alNF?=
 =?utf-8?B?T0lmTkpFTURNQ3RiYWVTZmFNUzMybC9lRXgrVmMxUkF6OGdoRXA1RWlhekZs?=
 =?utf-8?B?Y1RoS0ZySmpVUTFXRG11TTZXUk9rRktvZmlzSTA2K1VHMXRlOXYrYXcwMUd6?=
 =?utf-8?B?Y1BQZEZFZUdHNGllVkVDOVBCUitFR3dJS1pDM0JnNVliZ0d6Njg1U1lscHpo?=
 =?utf-8?B?ZzEvb2NDWUpVUG9YaEJqZE9MVk45cEN4L2JleElwNVFqeXBqQk1iVXNINDF3?=
 =?utf-8?B?NElEZXZ4Nk5tam52NG5FUFhUSDVSdlF0VWpmMy85Y1VOUDF6Q1QrZklwWjVF?=
 =?utf-8?B?Uzc4Z09reXNUdU5NRUhuSXJhMElwQXpHQzdnVnVCMnRBZi93eEIzb08xUXVZ?=
 =?utf-8?B?dWl3VFEwM21Oa2xpZjQzM3U3YUpaU1ZpS3k2c1ljVmJBYTd0Sm5iOWRRM1Nr?=
 =?utf-8?B?dS9zTTQ1dnA2dUpkUmRaamNWckdncHFtQk1Uc0ZJLzVBYWlCYUZNM3p6eHJ5?=
 =?utf-8?B?K08zQ1F5ZkJTRGhrUWFoc1ExbDMxQ3B5ZlNxV2xPK3huSlZOYjhiZTZDSHYw?=
 =?utf-8?B?bFJSWkwwbm9sMnVIa211YnJUWis3NW8rVTN0anFPVXU4MFBQMDFzQ0dlOXUr?=
 =?utf-8?B?VHM3anVXNDF6blRsRnFxK251bDFoNWZLVVV2eFVUVW9ubUNlNHJQTU1URm40?=
 =?utf-8?B?N2xOOE1iRzh5ZGpCSHc0NzNYZ2RONnV5MDFTQkh5SUxGZjdEcnhGd0szd0dY?=
 =?utf-8?B?MEtGY2dNdE43aWZlcUVjMWtleGdEWmo2Zk5oRm1iaUprL2xQaUtGRTRydGlR?=
 =?utf-8?B?dmpvdlBCeHZNWkowS2ZlUHhqZUhMdUx4VlkrRlVmWkwwQUFtby9ZNWtuUFM5?=
 =?utf-8?B?S0g4cnRIeUZORldMQ2R0dERFN1RwMStWd21JdFVqM3F2em1FR2YwcHpBSDhy?=
 =?utf-8?B?THBqcTdrY3JHZnZVWE40NFhhUzFuSjJ6d0FUQ1J1QTE0Z1JYT0dQUmxWVjRz?=
 =?utf-8?B?Uk50VHl0cERHWVZXQW4vYXZvamgwKy9CYWNpeXZCb1JVTWZZdWVUUWlkZ25S?=
 =?utf-8?B?QzVBTjNwWEx6WG14MHJXNmViN21UWW5ld3IyV1IwWTYwZlRhbERJcEI4dEpl?=
 =?utf-8?B?SENQVStmSG9xbCt5L0wyMW1uVzNWWmJ5TDM2NDI5SllyZWV5djZwWUFWN25D?=
 =?utf-8?B?YnBONDB6eW5GRWovbTBBRTNvRWUzNzl0K3BDSnlVZ3BGUXUxakVlVmxDbTkv?=
 =?utf-8?B?MHFxMUIvQmpnUG01cWEzMWZVMjR3Tno3ZDdpMVdJNm9SanEzWUovVExjL0Fv?=
 =?utf-8?B?eWp0OVArYWg3N0tPZG52SWI4YzY1VStHZkNZYXJ0Und5cUh3L2Y2bjY5eDN1?=
 =?utf-8?B?K2FoU0RvVVNIalJkWnNUdTZPb0U2MFNGUEFHTTdJVko5eXo1c3F5VUR1NlNG?=
 =?utf-8?B?V0lNNFYvRm5VYWZFM0dlNDJudzdNQms2VEVQTHZtSXdtTVV4STQ2Sld3UTh1?=
 =?utf-8?B?V0x1eHVkTlltUmt5dVNFdmVidjRHUWhVSGZFN0xiYXZEc1FoYkh4YmlQd1Jj?=
 =?utf-8?B?SFM5RG5SL0djSndUdkRibUFnVDFkV2Rua1JTc3krZXhsQnd6SXhvcWxWQ21h?=
 =?utf-8?B?aEtldHpBbERVUFZ5YUdNbjZ6K3lRS0RGN1ErYkVyWDZaVkVqSmU2ZWcvYngx?=
 =?utf-8?B?ZWZYSzE1blA4NmkzRDBIWlN5VENBWmFyajFnQTBlVVBVQ3FWWXZENWdSVG9r?=
 =?utf-8?B?RFRPME5xUDBUMW41T0lYZFBXandxODRRejU4aTVlRVFNY3FwZTUxcVBFWVg3?=
 =?utf-8?B?c1M3cmt4cUZTUjZXM2tBNGhmdm45RDlVa0E3L0N6aFhsRHp2d1hkRWJDSHFM?=
 =?utf-8?B?RG9ZcnVGRnNTUlY5NzRoQkNIeDIrdWh1QjR6Z1BGdE1RSDYraEUwOVpuNUNO?=
 =?utf-8?Q?Bq6J/k8AiNdR4Lv1wvdYnFtQj?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c10d07fa-a2b9-43c1-21c1-08dc427b2044
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5712.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2024 09:59:37.3010
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FaSI+3+CAwBJpDLnEr+Uzr3UytnIM3rLBMvX7+g2znsx1Pxs4V2NlU9hpUTUMR83HuRlXG25+mmKUQVljEATFw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7542

On 3/11/2024 11:10 PM, Ian Rogers wrote:
> On Sun, Mar 10, 2024 at 10:23 PM Sandipan Das <sandipan.das@amd.com> wrote:
>>
>> Add core events taken from Section 1.4 "Core Performance Monitor
>> Counters" of the Performance Monitor Counters for AMD Family 1Ah Model
>> 00h-0Fh Processors document available at the link below. This
>> constitutes events which capture information on op dispatch, execution
>> and retirement, branch prediction, L1 and L2 cache activity,
>> TLB activity, etc.
>>
>> Link: https://bugzilla.kernel.org/attachment.cgi?id=305974
>> Signed-off-by: Sandipan Das <sandipan.das@amd.com>
>> ---
>>  .../pmu-events/arch/x86/amdzen5/branch.json   |  82 ++
>>  .../pmu-events/arch/x86/amdzen5/cache.json    | 605 +++++++++++++
>>  .../pmu-events/arch/x86/amdzen5/core.json     | 122 +++
>>  .../arch/x86/amdzen5/floating-point.json      | 830 ++++++++++++++++++
>>  .../pmu-events/arch/x86/amdzen5/memory.json   | 180 ++++
>>  .../pmu-events/arch/x86/amdzen5/other.json    | 168 ++++
>>  6 files changed, 1987 insertions(+)
>>  create mode 100644 tools/perf/pmu-events/arch/x86/amdzen5/branch.json
>>  create mode 100644 tools/perf/pmu-events/arch/x86/amdzen5/cache.json
>>  create mode 100644 tools/perf/pmu-events/arch/x86/amdzen5/core.json
>>  create mode 100644 tools/perf/pmu-events/arch/x86/amdzen5/floating-point.json
>>  create mode 100644 tools/perf/pmu-events/arch/x86/amdzen5/memory.json
>>  create mode 100644 tools/perf/pmu-events/arch/x86/amdzen5/other.json
>>
>> diff --git a/tools/perf/pmu-events/arch/x86/amdzen5/branch.json b/tools/perf/pmu-events/arch/x86/amdzen5/branch.json
>> new file mode 100644
>> index 000000000000..208c646c59ca
>> --- /dev/null
>> +++ b/tools/perf/pmu-events/arch/x86/amdzen5/branch.json
>> @@ -0,0 +1,82 @@
>> +[
>> +  {
>> +    "EventName": "bp_l2_btb_correct",
>> +    "EventCode": "0x8b",
>> +    "BriefDescription": "L2 branch prediction overrides existing prediction (speculative)."
>> +  },
>> +  {
>> +    "EventName": "bp_dyn_ind_pred",
>> +    "EventCode": "0x8e",
>> +    "BriefDescription": "Dynamic indirect predictions (branch used the indirect predictor to make a prediction)."
>> +  },
>> +  {
>> +    "EventName": "bp_de_redirect",
>> +    "EventCode": "0x91",
>> +    "BriefDescription": "Instruction decoder corrects the predicted target and resteers the branch predictor."
>> +  },
>> +  {
>> +    "EventName": "ex_ret_brn",
>> +    "EventCode": "0xc2",
>> +    "BriefDescription": "Retired branch instructions (all types of architectural control flow changes, including exceptions and interrupts)."
>> +  },
> 
> So the "bp_" prefix means branch predictor, but here this is an "ex_"
> prefix. You've put them both in the topic "branch".
> 
> [ ... snip ... ]
> 
>> diff --git a/tools/perf/pmu-events/arch/x86/amdzen5/other.json b/tools/perf/pmu-events/arch/x86/amdzen5/other.json
>> new file mode 100644
>> index 000000000000..9d49a23622e9
>> --- /dev/null
>> +++ b/tools/perf/pmu-events/arch/x86/amdzen5/other.json
>> @@ -0,0 +1,168 @@
>> +[
>> +  {
>> +    "EventName": "bp_redirects.resync",
>> +    "EventCode": "0x9f",
>> +    "BriefDescription": "Redirects of the branch predictor caused by resyncs.",
>> +    "UMask": "0x01"
>> +  },
> 
> Here is a branch predictor "bp_" event but the topic is "other", why
> isn't it a topic of branch?
> 
> Given the number of events categorized as topic "other" wouldn't it be
> better to regenerate the events just using the prefix to set the
> topic?
> 

Sure, I'll reorganize them.