Received-SPF: pass (google.com: domain of linux-kernel+bounces-100086-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <82d5ada0-7963-4b1a-bae7-f2fce2befb57@amd.com>
Date: Tue, 12 Mar 2024 15:32:11 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/4] perf vendor events amd: Add Zen 5 uncore events
Content-Language: en-US
To: Ian Rogers <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
 peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
 namhyung@kernel.org, mark.rutland@arm.com,
 alexander.shishkin@linux.intel.com, jolsa@kernel.org,
 adrian.hunter@intel.com, eranian@google.com, ravi.bangoria@amd.com,
 ananth.narayan@amd.com
References: <cover.1710133771.git.sandipan.das@amd.com>
 <e100c902fd9e1e4f58e3a9c175d572962a9cdd50.1710133771.git.sandipan.das@amd.com>
 <CAP-5=fU=gO49ASVVLUbT5bFPoOE3qi3+xJqvRD3tA=upVUT_aQ@mail.gmail.com>
From: Sandipan Das <sandipan.das@amd.com>
In-Reply-To: <CAP-5=fU=gO49ASVVLUbT5bFPoOE3qi3+xJqvRD3tA=upVUT_aQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aG8wSkpVbWRGNlZ2cFNzY2VkajZUcGdZY282MHhqNUE1eSt3MGVobXVTVVJR?=
 =?utf-8?B?RDY4eEVGZWM2OE03aUpLenJlREFDbHhXalNMWHg1TkRNQlNFc1JtQjZUTHhZ?=
 =?utf-8?B?L1RpY3R0UndTN1BHd29id28rTHVyYzdqM0lQMWdZL2JyVFB4SzJ3MnVTeXNO?=
 =?utf-8?B?OXVjYkNPcDB1YmNRc0JBWHVqYWtuWDA4YlFUTC9sRExYSm80WFFTSEltdUZm?=
 =?utf-8?B?ZGlENDZIMExyYk9jNFJqekMzcHg1NmlxVXFLcmd2WFRaNCtuZ0dyWjF0MG9X?=
 =?utf-8?B?NWlDbjRPandpMmIwMkNjTFNIVlVlUFJuQ0Q5VjcrNkRVcU5ZdzMzWnlMV2l4?=
 =?utf-8?B?WmdxMlh6TXNOM2JITFZMYytqSUNIUFk0bkpqam1Vd1lnK2NVV3gwSlVjVWpr?=
 =?utf-8?B?WnZIcnUzSTZ3Y0hUSXJsanRBc29iK2JiQ05xd3drL09wK0tRNEplUU9QRXdM?=
 =?utf-8?B?R01xV0dIakllczR6dnlTazcydkppTG1JSUlIM3VhUEV5SE11azAxRnhKaXp4?=
 =?utf-8?B?ajBSdEpjUFNIamd5ZGtHRWpWMlpFV1VKaHNOUGdOb3BiODdXTHMwcmdLNHUy?=
 =?utf-8?B?ZEZzbVQzbis5QlJYdFYxY1R0Rk4wTXJnWi9oZ281eHQ5WkVnNTFIWEttUENl?=
 =?utf-8?B?aXJVRHlEcCttSzBaWjNCODdUR2tDV21ZS0c4d3daeVBLQWVtNzExUXRtc0Vo?=
 =?utf-8?B?VTAzdmkvVHlkTDNlMERLMnYxZ1B6bktCcnBiV0h4ckw3bWJBZ2xTYnE3RHFw?=
 =?utf-8?B?MTl1RFlBYUs1emhlQzRCZFBEdUFkOW5DK3B1UEZNKy9adExQUE9FZkVPMUE0?=
 =?utf-8?B?bTRJVEdHOEc4MTU4NlFvL2NVZGFHWmJIV1BsS2s1OEFodDd2YkpVTjl0MnQz?=
 =?utf-8?B?TU5qMndwQjZwWDI0dnlhY0pxMXB0ZmVwNzlxQ08rZExXV0N1QjR1dzlreElS?=
 =?utf-8?B?WWdqZnlqNnI3M3BCM05LTHFEUlMvdysrR0pHRkN2VTRDUzB4NlFZNFNxMmxj?=
 =?utf-8?B?SitrTWVDUFZ2SnNoK2RGWHlrc0oya3B5RlZhZFdTb3RVRDlwMEN6Q1hrRXli?=
 =?utf-8?B?aVgwSG03YnlZcXg4TVNSUm5CYXlwWnAzZllQZXhxVTA5MERCQ25Bck02UUNh?=
 =?utf-8?B?QTJidE1JdWJGZjExMktUZ2NJckdlc2ZYZTc2eHk1MzhHQ3E4NTk1a0pMNXUw?=
 =?utf-8?B?WmFrbkRObGdIUmdNRU13dis5SUV2MFNUUjVVbS9ucFhQaHhPcU1OQmVwR002?=
 =?utf-8?B?REVQcU8wTXorc2d6Y21YTytKVklwR2RheG15eVV5UmVHVGI4eVFmY3VNc0RX?=
 =?utf-8?B?eUhhR2RMM0JSZFRFdWpqRmJ4Z3plQTkvRnNLTGRKYjhaNzBxRlJTS1M1UkVk?=
 =?utf-8?B?VG1aMFNrS2VmMW5heWpRVlhRR0o1U0lTd2dOcFNTS0pwYXdvUlNGdm5ySUVN?=
 =?utf-8?B?WUpvNVJRZVlQQm9MY0oyNjhZN3czc1c2WmVCVkg5bll6UG10cmVnZjRuZXNj?=
 =?utf-8?B?QkhDWit2R3gyRmRKQjNiR2grOXhscjJ4QTFvb2wxSFBNYktramhQVExoMjAz?=
 =?utf-8?B?ajNOdUJKVFpZU1Y0eG1pMGxLRmVtUzI2RCt5dnVQb3AwMUZMTThzNnQvQlJN?=
 =?utf-8?B?eWo4a2R4Rk15dG0ya0d4N2ppL2sxSzBZODJ5QmxqRXhWZnBuODYvM1U4TFc1?=
 =?utf-8?B?dTRBWllNekUydmpTcUltN0R1ZzdMMm50aXhja3pBMVNoMTl3b09JWEZKNmhJ?=
 =?utf-8?B?UWNBN3RPWjNIUHdMQkFnWHlOL1JxNXhhLzRxNkw2WTRQMWJXRUZEOWFtSGFT?=
 =?utf-8?B?TFhHcVlVYmdrYk5mS0s4dEZsMFFNQUhrVmZha1VaeWJVUDYySzc3NEpTeCtt?=
 =?utf-8?B?OVp4bkdzVnhHOXhRTC9BMDVXK1BSRzNUZ0FCYVorK3AyRkpyS3RobEpyK2hB?=
 =?utf-8?B?QllOY2x4TUttNVpvR29ydFdQSEhCMEFaaVJCMEFKcnp3SWpFblYvMHQxVzJO?=
 =?utf-8?B?VkliMy9qUml6Z0lmcThGeHFTcFZkY0lvd3Y3R2J5ZTZYc1VJbGZHc3RtVFpS?=
 =?utf-8?B?KzdjcXAyQi85a2FFTmFSd2NxN0lmaGZ5bi9wbUJmYUoxR0J0cmg4TUU0Y212?=
 =?utf-8?Q?NTOiFO3ChYUrAGIMt/ES9LCcY?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e8d54fc9-fc8e-41ac-189f-08dc427b822a
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5712.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2024 10:02:21.5209
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UQH5j2docTGRtLuNX62Mpt6NRC1ruS227YQq92m+9XCpKyp5WL/kQn+t7zebJwFAf45xBNkNHJ6WFpHKSj/MPA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7542


On 3/11/2024 11:13 PM, Ian Rogers wrote:
> On Sun, Mar 10, 2024 at 10:24 PM Sandipan Das <sandipan.das@amd.com> wrote:
>>
>> Add uncore events taken from Section 1.5 "L3 Cache Performance Monitor
>> Counters" and Section 2 "UMC Performance Monitors" of the Performance
>> Monitor Counters for AMD Family 1Ah Model 00h-0Fh Processors document
>> available at the link below. This constitutes events which capture L3
>> cache and UMC command activity.
> 
> Why do the L3 uncore PMU events go in the same topic as the core/cpu
> events, but the memory controller events not? Could they both go in
> separate files to make better use of the topic?
> 

Sure. I'll move the L3 events to a separate file.

> 
>> Link: https://bugzilla.kernel.org/attachment.cgi?id=305974
>> Signed-off-by: Sandipan Das <sandipan.das@amd.com>
>> ---
>>  .../pmu-events/arch/x86/amdzen5/cache.json    | 175 ++++++++++++++++++
>>  .../arch/x86/amdzen5/memory-controller.json   | 101 ++++++++++
> 
> [ ... snip ... ]