Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp954433lql; Tue, 12 Mar 2024 03:10:32 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVCUFX3lynurU33Cg18mZ4FfBMuincO6QY/vaIsBBfuXUAwHlhbxxJohY5oRIQOUEKoopId7z4jbBoKD/Jkq7vQK97RRzegqk5vCujiMg== X-Google-Smtp-Source: AGHT+IE7BF1rQxnxpY49mGgyoC8ikXYmqIpzGAlAA/q8YiVexNY/Oe8qoYOxV6V8UCg0Tmt4kgvp X-Received: by 2002:a05:6358:650e:b0:17b:f51e:9960 with SMTP id v14-20020a056358650e00b0017bf51e9960mr14665294rwg.13.1710238231973; Tue, 12 Mar 2024 03:10:31 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710238231; cv=pass; d=google.com; s=arc-20160816; b=dbBSu7G7nsUpn4hNObjuBKucJWZSsnu0hExmdydQFHObG41MO5R+sMEyQzq3emgyqE gQfvIWxUEXoWd/s1d21AYH15QTXTFDSVm8gax+C/8OQ/DTEOwfpf/XNgSgs8kLe6WKKh o4RhSZxeFeLrvQzMpCVqe8ZvJVNiV6HFdkrKj/GorGbS8KXQiMQcxDiNxYRZATLtLbJs aZwcD0FG8SR9Ibvgu3LGFxlAaFGhNMb1YhEgOhxrLjSVlKpNNLILMnzfq9uUyfY+cQUB DZ0tRi23pL0G5KqYyjLHcjoYnWxc7ZEbtALOu8ZkeJg03km+Vfqvol0X2q/aiFD7EUaf 721A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:autocrypt:references :in-reply-to:date:cc:to:from:subject:message-id:dkim-signature; bh=YAJHhP3n6I2K3l6DHHJqd7XuLcnDmh4Em6R7NQKSbxo=; fh=J8Zm0pTZzfBfWntdvFRZwln7t6A5na3Q76Q6Jd51Fx4=; b=isn1Lc8FJCdWHvaysJYlTHUFdnNWd8K9cYF9/tjLoOmUB0KkRnCKILXco4UVqIVlsD 78k+ReHh06fIfqdmYk5HdRA+msmRIBmPeg/oRj6zhi3rd/V3YbF6fFt8EqGmetcN+38M PPn3Edx2uj3JupjIfiqj/XXeo/KMwBJDbCIFm7JmVxuC5OehwjfcI/WTu+6E9zpf0JT3 MZaanqQ7oXUbZDaDrL+bHo/KyZFYoEeI5wdZGL2KbdYz7WLu6mO9Gzih1CKrXTAverml VGybB39Rvny2Bu3h76MznAxkykIUNA5hiyggZrdo4Tv57Is8hoM60gph3MUeopim3Coj /C7Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CjwJBy8b; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-100084-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100084-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id g4-20020a63dd44000000b005e49cde1b64si6709296pgj.190.2024.03.12.03.10.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 03:10:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-100084-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CjwJBy8b; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-100084-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100084-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 62AA8B20FE6 for ; Tue, 12 Mar 2024 10:02:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 83D4678663; Tue, 12 Mar 2024 10:01:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CjwJBy8b" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D18BC33994 for ; Tue, 12 Mar 2024 10:01:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710237715; cv=none; b=A5X2vaQ67v+9pBAVC2Mvob+j1n3NWyrvkOLvsUpRv9Gpqk8DvZfsz0Oyov6WQguy4CsYYSxqlrzHHG7IiwT85YFYfqJeJFkS8Q8jgnpdl1JxXnKYei1rmAaDPoB+SQTSAY0DY2RPGbCKWHgP1OAd6XN+DG8JWZUNjJwInTZAzeE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710237715; c=relaxed/simple; bh=qQj1njXXAO92ahlxvCg8MTG2ryYI0K3G7GyvOHga0I0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=HSNaPbw1b0GYi4Y+jBG/VqU+xUo5KYyPekYhp+h3wNSvc3boPq/WIbrfP4Xtra6Fis0DhYk2NvlyQZfI/JtmrsKfNhs4wzZbR0In9FqS6HEeZ7kVwStCa9ymhfBrZiVN7pnQpN52CFkOouwFcO88yyWg0zb9jEjSxtkH1aUlcXo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CjwJBy8b; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710237712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=YAJHhP3n6I2K3l6DHHJqd7XuLcnDmh4Em6R7NQKSbxo=; b=CjwJBy8bUZfLAbXyE5OO5ST33MZVawkiFXSemHZldsGpTr8wNo0SLYoCk4DV/V2haB/OaH VdrR2ybpS9NkDeZYQwZm9nQpUUAmFx3vtwoM9yAIgRuEUS0g2PW9b6A2+wQOj5WjuO5DIy i9rMV0CYUMVoNeo0BwJcf4oD6QVE0aw= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-160-5ig4w-kaPU6PBeeV65tqdA-1; Tue, 12 Mar 2024 06:01:51 -0400 X-MC-Unique: 5ig4w-kaPU6PBeeV65tqdA-1 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-567eb0397e3so1563133a12.1 for ; Tue, 12 Mar 2024 03:01:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710237710; x=1710842510; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YAJHhP3n6I2K3l6DHHJqd7XuLcnDmh4Em6R7NQKSbxo=; b=CvyKBVKkoeekJIsUK6RHqOHKAkMGrBgY/YvmUI8fzAWta5zNn2IgMpkjfMUmJ6AUCm t1FqsSliv73w80g4xl/RaIK4jWVQL3TKIsPI8HZzCvd2Bo5lEy6KJf6iXh7lvtxuWKYx yYpsRvVogTdXYLpCtlwclJJ4idbrOLKc/4KVGBUzcgxbb+RyI44V/PzHEPG8FRxZoUgZ whRx3qegnmDHaxs+svxF/LWkT6mjQU8pg6tl8E8nMQs+nDayt+DkOLET0QkzzQtEIThM aheSJ8CneUtpovdZVcm34OL6I7XyHRkoMZnHg9ybCOE0Pwq+APcb7h5+BnqZQ6krHB2v Cc/A== X-Forwarded-Encrypted: i=1; AJvYcCVJOl1lcDd7EWAu0C1SU5H5ikVcRqOD/enG91XTbFeG+o3P3+0sAMWz/4Kx91ubVacLDKNwr14LaqAU3/n14Qs9K9nmXD2V5hkXnEyu X-Gm-Message-State: AOJu0YzqCSlHt6jnSvrQ40uz9F2QHuf0F8LdVqpXA6IJU6Csc47zRiNO b5bBE6IdBW0wJsMRSNPWGP5WcyTV7+X7ZKVsUwkWZdBdnVvxfjfopVeoIqH+/joahhX+bhgXle4 f5ADmhOG0/p6decjvNweQdI6fJRqCFKed6H/OmF2Xm4wtywX6sdDfb3G7zkhzOg== X-Received: by 2002:a17:907:775a:b0:a45:bde4:c131 with SMTP id kx26-20020a170907775a00b00a45bde4c131mr5526270ejc.6.1710237710250; Tue, 12 Mar 2024 03:01:50 -0700 (PDT) X-Received: by 2002:a17:907:775a:b0:a45:bde4:c131 with SMTP id kx26-20020a170907775a00b00a45bde4c131mr5526251ejc.6.1710237709931; Tue, 12 Mar 2024 03:01:49 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-226-128.dyn.eolo.it. [146.241.226.128]) by smtp.gmail.com with ESMTPSA id b24-20020a170906491800b00a464104e758sm549790ejq.85.2024.03.12.03.01.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 03:01:49 -0700 (PDT) Message-ID: <7169b33e1e4487370a530fb60d97dc096a24acfc.camel@redhat.com> Subject: Re: [PATCH v3] i40e: Prevent setting MTU if greater than MFS From: Paolo Abeni To: Erwan Velu Cc: Erwan Velu , Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 12 Mar 2024 11:01:48 +0100 In-Reply-To: <20240312094259.770554-1-e.velu@criteo.com> References: <20240312094259.770554-1-e.velu@criteo.com> Autocrypt: addr=pabeni@redhat.com; prefer-encrypt=mutual; keydata=mQINBGISiDUBEAC5uMdJicjm3ZlWQJG4u2EU1EhWUSx8IZLUTmEE8zmjPJFSYDcjtfGcbzLPb63BvX7FADmTOkO7gwtDgm501XnQaZgBUnCOUT8qv5MkKsFH20h1XJyqjPeGM55YFAXc+a4WD0YyO5M0+KhDeRLoildeRna1ey944VlZ6Inf67zMYw9vfE5XozBtytFIrRyGEWkQwkjaYhr1cGM8ia24QQVQid3P7SPkR78kJmrT32sGk+TdR4YnZzBvVaojX4AroZrrAQVdOLQWR+w4w1mONfJvahNdjq73tKv51nIpu4SAC1Zmnm3x4u9r22mbMDr0uWqDqwhsvkanYmn4umDKc1ZkBnDIbbumd40x9CKgG6ogVlLYeJa9WyfVMOHDF6f0wRjFjxVoPO6p/ZDkuEa67KCpJnXNYipLJ3MYhdKWBZw0xc3LKiKc+nMfQlo76T/qHMDfRMaMhk+L8gWc3ZlRQFG0/Pd1pdQEiRuvfM5DUXDo/YOZLV0NfRFU9SmtIPhbdm9cV8Hf8mUwubihiJB/9zPvVq8xfiVbdT0sPzBtxW0fXwrbFxYAOFvT0UC2MjlIsukjmXOUJtdZqBE3v3Jf7VnjNVj9P58+MOx9iYo8jl3fNd7biyQWdPDfYk9ncK8km4skfZQIoUVqrWqGDJjHO1W9CQLAxkfOeHrmG29PK9tHIwARAQABtB9QYW9sbyBBYmVuaSA8cGFiZW5pQHJlZGhhdC5jb20+iQJSBBMBCAA8FiEEg1AjqC77wbdLX2LbKSR5jcyPE6QFAmISiDUCGwMFCwkIBwIDIgIBBhUKCQgLAgQWAgMBAh4HAheAAAoJECkkeY3MjxOkJSYQAJcc6MTsuFxYdYZkeWjW//zbD3ApRHzpNlHLVSuJqHr9/aDS+tyszgS8jj9MiqALzgq4iZbg 7ZxN9ZsDL38qVIuFkSpgMZCiUHdxBC11J8nbBSLlpnc924UAyr5XrGA99 6Wl5I4Km3128GY6iAkH54pZpOmpoUyBjcxbJWHstzmvyiXrjA2sMzYjt3Xkqp0cJfIEekOi75wnNPofEEJg28XPcFrpkMUFFvB4Aqrdc2yyR8Y36rbw18sIX3dJdomIP3dL7LoJi9mfUKOnr86Z0xltgcLPGYoCiUZMlXyWgB2IPmmcMP2jLJrusICjZxLYJJLofEjznAJSUEwB/3rlvFrSYvkKkVmfnfro5XEr5nStVTECxfy7RTtltwih85LlZEHP8eJWMUDj3P4Q9CWNgz2pWr1t68QuPHWaA+PrXyasDlcRpRXHZCOcvsKhAaCOG8TzCrutOZ5NxdfXTe3f1jVIEab7lNgr+7HiNVS+UPRzmvBc73DAyToKQBn9kC4jh9HoWyYTepjdcxnio0crmara+/HEyRZDQeOzSexf85I4dwxcdPKXv0fmLtxrN57Ae82bHuRlfeTuDG3x3vl/Bjx4O7Lb+oN2BLTmgpYq7V1WJPUwikZg8M+nvDNcsOoWGbU417PbHHn3N7yS0lLGoCCWyrK1OY0QM4EVsL3TjOfUtCNQYW9sbyBBYmVuaSA8cGFvbG8uYWJlbmlAZ21haWwuY29tPokCUgQTAQgAPBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEoitAhsDBQsJCAcCAyICAQYVCgkICwIEFgIDAQIeBwIXgAAKCRApJHmNzI8TpBzHD/45pUctaCnhee1vkQnmStAYvHmwrWwIEH1lzDMDCpJQHTUQOOJWDAZOFnE/67bxSS81Wie0OKW2jvg1ylmpBA0gPpnzIExQmfP72cQ1TBoeVColVT6Io35BINn+ymM7c0Bn8RvngSEpr3jBtqvvWXjvtnJ5/HbOVQCg62NC6ewosoKJPWpGXMJ9SKsVIOUHsmoWK60spzeiJoSmAwm3zTJQnM5kRh2q iWjoCy8L35zPqR5TV+f5WR5hTVCqmLHSgm1jxwKhPg9L+GfuE4d0SWd84y GeOB3sSxlhWsuTj1K6K3MO9srD9hr0puqjO9sAizd0BJP8ucf/AACfrgmzIqZXCfVS7jJ/M+0ic+j1Si3yY8wYPEi3dvbVC0zsoGj9n1R7B7L9c3g1pZ4L9ui428vnPiMnDN3jh9OsdaXeWLvSvTylYvw9q0DEXVQTv4/OkcoMrfEkfbXbtZ3PRlAiddSZA5BDEkkm6P9KA2YAuooi1OD9d4MW8LFAeEicvHG+TPO6jtKTacdXDRe611EfRwTjBs19HmabSUfFcumL6BlVyceIoSqXFe5jOfGpbBevTZtg4kTSHqymGb6ra6sKs+/9aJiONs5NXY7iacZ55qG3Ib1cpQTps9bQILnqpwL2VTaH9TPGWwMY3Nc2VEc08zsLrXnA/yZKqZ1YzSY9MGXWYLkCDQRiEog1ARAAyXMKL+x1lDvLZVQjSUIVlaWswc0nV5y2EzBdbdZZCP3ysGC+s+n7xtq0o1wOvSvaG9h5q7sYZs+AKbuUbeZPu0bPWKoO02i00yVoSgWnEqDbyNeiSW+vI+VdiXITV83lG6pS+pAoTZlRROkpb5xo0gQ5ZeYok8MrkEmJbsPjdoKUJDBFTwrRnaDOfb+Qx1D22PlAZpdKiNtwbNZWiwEQFm6mHkIVSTUe2zSemoqYX4QQRvbmuMyPIbwbdNWlItukjHsffuPivLF/XsI1gDV67S1cVnQbBgrpFDxN62USwewXkNl+ndwa+15wgJFyq4Sd+RSMTPDzDQPFovyDfA/jxN2SK1Lizam6o+LBmvhIxwZOfdYH8bdYCoSpqcKLJVG3qVcTwbhGJr3kpRcBRz39Ml6iZhJyI3pEoX3bJTlR5Pr1Kjpx13qGydSMos94CIYWAKhegI06aTdvvuiigBwjngo/Rk5S+iEGR5KmTqGyp27o6YxZy6D4NIc6PKUzhIUxfvuHNvfu sD2W1U7eyLdm/jCgticGDsRtweytsgCSYfbz0gdgUuL3EBYN3JLbAU+UZpy v/fyD4cHDWaizNy/KmOI6FFjvVh4LRCpGTGDVPHsQXaqvzUybaMb7HSfmBBzZqqfVbq9n5FqPjAgD2lJ0rkzb9XnVXHgr6bmMRlaTlBMAEQEAAYkCNgQYAQgAIBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEog1AhsMAAoJECkkeY3MjxOkY1YQAKdGjHyIdOWSjM8DPLdGJaPgJdugHZowaoyCxffilMGXqc8axBtmYjUIoXurpl+f+a7S0tQhXjGUt09zKlNXxGcebL5TEPFqgJTHN/77ayLslMTtZVYHE2FiIxkvW48yDjZUlefmphGpfpoXe4nRBNto1mMB9Pb9vR47EjNBZCtWWbwJTIEUwHP2Z5fV9nMx9Zw2BhwrfnODnzI8xRWVqk7/5R+FJvl7s3nY4F+svKGD9QHYmxfd8Gx42PZc/qkeCjUORaOf1fsYyChTtJI4iNm6iWbD9HK5LTMzwl0n0lL7CEsBsCJ97i2swm1DQiY1ZJ95G2Nz5PjNRSiymIw9/neTvUT8VJJhzRl3Nb/EmO/qeahfiG7zTpqSn2dEl+AwbcwQrbAhTPzuHIcoLZYV0xDWzAibUnn7pSrQKja+b8kHD9WF+m7dPlRVY7soqEYXylyCOXr5516upH8vVBmqweCIxXSWqPAhQq8d3hB/Ww2A0H0PBTN1REVw8pRLNApEA7C2nX6RW0XmA53PIQvAP0EAakWsqHoKZ5WdpeOcH9iVlUQhRgemQSkhfNaP9LqR1XKujlTuUTpoyT3xwAzkmSxN1nABoutHEO/N87fpIbpbZaIdinF7b9srwUvDOKsywfs5HMiUZhLKoZzCcU/AEFjQsPTATACGsWf3JYPnWxL9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi, On Tue, 2024-03-12 at 10:42 +0100, Erwan Velu wrote: > Commit 6871a7de705b6f6a4046f0d19da9bcd689c3bc8e from iPXE project is Please use the checkpatch-friendly commit reference: <12char hash> ("") > setting the MFS to 0x600 =3D 1536. >=20 > At boot time the i40e driver complains about it with > the following message but continues. >=20 > MFS for port 1 has been set below the default: 600 >=20 > If the MTU size is increased, the driver accept it but large packets will= not > be processed by the firmware generating tx_errors. The issue is pretty > silent for users. i.e doing TCP in such context will generates lots of > retransmissions until the proper window size (below 1500) will be used. >=20 > To fix this case, it would have been ideal to increase the MFS, > via i40e_aqc_opc_set_mac_config, incoming patch will take care of it. >=20 > At least, this commit prevents setting up an MTU greater than the current= MFS. > It will avoid being in the position of having an MTU set to 9000 on the > netdev with a firmware refusing packets larger than 1536. This looks like a legit fix that should target the 'net' tree, @Tony: do you agree?=20 If so, Erwan, please include a suitable fixes tag in the next revision. Please include into the subj prefix a suitable target tree. I think this should go first via the intel tree for testing, so 'iwl-net' should fit. In any case please respect the 24h grace period when posting on netdev: https://elixir.bootlin.com/linux/latest/source/Documentation/process/mainta= iner-netdev.rst#L399 Cheers, Paolo