Received-SPF: pass (google.com: domain of linux-kernel+bounces-100102-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240311235210.2937484-1-yosryahmed@google.com> <CAKEwX=Oaj=h-Lqk+ZdrB6LpksKF5xhNJkpgUuF-wQ0gk6+pgpg@mail.gmail.com>
In-Reply-To: <CAKEwX=Oaj=h-Lqk+ZdrB6LpksKF5xhNJkpgUuF-wQ0gk6+pgpg@mail.gmail.com>
From: Yosry Ahmed <yosryahmed@google.com>
Date: Tue, 12 Mar 2024 03:22:06 -0700
Message-ID: <CAJD7tkZSz6A2cEdHzMhJZpa8BwxH8iRUZQqKp6GfPaGzBZthRA@mail.gmail.com>
Subject: Re: [PATCH] mm: zswap: remove unnecessary check in zswap_find_zpool()
To: Nhat Pham <nphamcs@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, Johannes Weiner <hannes@cmpxchg.org>, 
	Chengming Zhou <chengming.zhou@linux.dev>, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 12, 2024 at 2:35=E2=80=AFAM Nhat Pham <nphamcs@gmail.com> wrote=
:
>
> On Tue, Mar 12, 2024 at 6:52=E2=80=AFAM Yosry Ahmed <yosryahmed@google.co=
m> wrote:
> >
> > zswap_find_zpool() checks if ZSWAP_NR_ZPOOLS > 1, which is always true.
> > This is a remnant from a patch version that had ZSWAP_NR_ZPOOLS as a
> > config option and never made it upstream. Remove the unnecessary check.
>
> Do we need a Fixes: tag for this? I guess it's not a bug hmmm.

The compiler should be producing the exact same code either way, so I
would say no. It's just a cleanup.

>
> >
> > Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
>
> Reviewed-by: Nhat Pham <nphamcs@gmail.com>

Thanks!