Received-SPF: pass (google.com: domain of linux-kernel+bounces-100116-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 12 Mar 2024 12:25:00 +0200
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Kyle Tso <kyletso@google.com>
Cc: linux@roeck-us.net, gregkh@linuxfoundation.org, badhri@google.com,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v1] usb: typec: tcpm: Correct port source pdo array in
 pd_set callback
Message-ID: <ZfAtfPciw8O6A+uS@kuha.fi.intel.com>
References: <20240311144500.3694849-1-kyletso@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240311144500.3694849-1-kyletso@google.com>

On Mon, Mar 11, 2024 at 10:45:00PM +0800, Kyle Tso wrote:
> In tcpm_pd_set, the array of port source capabilities is port->src_pdo,
> not port->snk_pdo.
> 
> Fixes: cd099cde4ed2 ("usb: typec: tcpm: Support multiple capabilities")
> Cc: stable@vger.kernel.org
> Signed-off-by: Kyle Tso <kyletso@google.com>

Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/tcpm/tcpm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 3d505614bff1..9485f6373de4 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -6858,7 +6858,7 @@ static int tcpm_pd_set(struct typec_port *p, struct usb_power_delivery *pd)
>  
>  	if (data->source_desc.pdo[0]) {
>  		for (i = 0; i < PDO_MAX_OBJECTS && data->source_desc.pdo[i]; i++)
> -			port->snk_pdo[i] = data->source_desc.pdo[i];
> +			port->src_pdo[i] = data->source_desc.pdo[i];
>  		port->nr_src_pdo = i + 1;
>  	}
>  
> -- 
> 2.44.0.278.ge034bb2e1d-goog

-- 
heikki