Received-SPF: pass (google.com: domain of linux-kernel+bounces-100119-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 12 Mar 2024 11:27:37 +0100
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>, 
	Andy Shevchenko <andy@kernel.org>
Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org, 
	Paul Burton <paulburton@kernel.org>
Subject: Re: [PATCH 3/3] auxdisplay: img-ascii-lcd: Convert to platform
 remove callback returning void
Message-ID: <r5ydocz3u3ng6voax2iveoqvvqpuo6s3defjkpqzmuoj222clw@76ilb4kbjlrw>
References: <cover.1710194084.git.u.kleine-koenig@pengutronix.de>
 <44de2d4c1fed6fe96b68ba9ad768d297b8f392a5.1710194084.git.u.kleine-koenig@pengutronix.de>
 <CAMuHMdVvmN2xns_76zSDpUX-v8V16mSP12A=Y4gght9cdgNb+A@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="fuiusb2rlhjutq6u"
Content-Disposition: inline
In-Reply-To: <CAMuHMdVvmN2xns_76zSDpUX-v8V16mSP12A=Y4gght9cdgNb+A@mail.gmail.com>


--fuiusb2rlhjutq6u
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 12, 2024 at 09:17:54AM +0100, Geert Uytterhoeven wrote:
> Hi Uwe,
>=20
> On Mon, Mar 11, 2024 at 10:59=E2=80=AFPM Uwe Kleine-K=C3=B6nig
> <u.kleine-koenig@pengutronix.de> wrote:
> > The .remove() callback for a platform driver returns an int which makes
> > many driver authors wrongly assume it's possible to do error handling by
> > returning an error code. However the value returned is ignored (apart
> > from emitting a warning) and this typically results in resource leaks.
> >
> > To improve here there is a quest to make the remove callback return
> > void. In the first step of this quest all drivers are converted to
> > .remove_new(), which already returns void. Eventually after all drivers
> > are converted, .remove_new() will be renamed to .remove().
> >
> > Trivially convert this driver from always returning zero in the remove
> > callback to the void returning variant.
> >
> > Signed-off-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
>=20
> Thanks for your patch!
>=20
> > --- a/drivers/auxdisplay/img-ascii-lcd.c
> > +++ b/drivers/auxdisplay/img-ascii-lcd.c
> > @@ -279,13 +279,12 @@ static int img_ascii_lcd_probe(struct platform_de=
vice *pdev)
> >   *
> >   * Return: 0
>=20
> Please remove this line.

Good catch, thanks.

@Andy: Should I resend this patch? Or the whole series? Or do you want
to fixup while applying?

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=C3=B6nig         =
   |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--fuiusb2rlhjutq6u
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmXwLhkACgkQj4D7WH0S
/k5WTAgAit22PIgRe2YUSFmwCR4+0SgXL8IxvwWIDEJRo/uWcxwB9Gj3m3Idb6KA
pkRCNFdV4soD5xMNOve/DKy3uqxigYCpJAPo58yulrlHtyfEIWYhdBFCPyi4M4FG
jf7mw/qu5Z8uO9x5WBaJK1ox2ysp6TxdP4m/bgjr1IbRwvpXC3hA2y3qEC9fp+6J
rF+xQ+pz6SYL7wp/wNeK/4fpEnLUzByfq40HNPjRl/Gff+K43KnaXvdJtS7ahxFd
57qY/v6/s3T4jQj5JQUaWo6Gh39+bbX311x4FQeXCuLTwqSWcE0FyKq8zR0ZItOU
K2V75WVRKetnK6aYX8M3/lQQFTp9Zw==
=IZji
-----END PGP SIGNATURE-----

--fuiusb2rlhjutq6u--