Received-SPF: pass (google.com: domain of linux-kernel+bounces-100120-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date: Tue, 12 Mar 2024 11:27:54 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Shrikanth Hegde <sshegde@linux.ibm.com>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Valentin Schneider <vschneid@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 05/13] sched/balancing: Rename load_balance() =>
 sched_balance_rq()
Message-ID: <ZfAuKjZ7pNgE2pc7@gmail.com>
References: <20240308111819.1101550-1-mingo@kernel.org>
 <20240308111819.1101550-6-mingo@kernel.org>
 <f14bf408-8a6d-4213-b922-82f1e8782609@linux.ibm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f14bf408-8a6d-4213-b922-82f1e8782609@linux.ibm.com>


* Shrikanth Hegde <sshegde@linux.ibm.com> wrote:

> 
> 
> On 3/8/24 4:48 PM, Ingo Molnar wrote:
> > Standardize scheduler load-balancing function names on the
> > sched_balance_() prefix.
> > 
> > Also load_balance() has become somewhat of a misnomer: historically
> > it was the first and primary load-balancing function that was called,
> > but with the introduction of sched domains, it's become a lower
> > layer function that balances runqueues.
> > 
> > Rename it to sched_balance_rq() accordingly.
> 
> nit: Can this be sched_balance_rqs()? since load balancing happens 
> between two runqeueus.

Yeah, but we really are primarily balancing *this* runqueue - because it 
got potentially out of balance due to a newidle event, or we are checking 
its balance in the periodic load-balancing tick. So it's really a shortcut 
for 'balance this runqueue' - singular, although internally it will indeed 
search for a source runqueue to move tasks from.

So it's a kind of a pull-balancing model, with a singular target (this_cpu).

> > Signed-off-by: Ingo Molnar <mingo@kernel.org>
> > Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
> > Cc: Linus Torvalds <torvalds@linux-foundation.org>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Shrikanth Hegde <sshegde@linux.ibm.com>
> > Cc: Valentin Schneider <vschneid@redhat.com>
> > Cc: Vincent Guittot <vincent.guittot@linaro.org>
> > ---
> 
> Though one would have been familiar with names(for someone started recently),
> given the correct behaviour and historical context helps why the name changes are making sense. 
> 
> Reviewed-by: Shrikanth Hegde <sshegde@linux.ibm.com>

Thanks! I've added your Reviewed-by tags to the series.

	Ingo