Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758280AbYAGQhl (ORCPT ); Mon, 7 Jan 2008 11:37:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755936AbYAGQhc (ORCPT ); Mon, 7 Jan 2008 11:37:32 -0500 Received: from hp3.statik.tu-cottbus.de ([141.43.120.68]:55132 "EHLO hp3.statik.tu-cottbus.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755916AbYAGQhb (ORCPT ); Mon, 7 Jan 2008 11:37:31 -0500 Message-ID: <47825510.7050306@s5r6.in-berlin.de> Date: Mon, 07 Jan 2008 17:36:32 +0100 From: Stefan Richter User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.11) Gecko/20071128 SeaMonkey/1.1.7 MIME-Version: 1.0 To: Jarek Poplawski CC: David Brownell , Greg KH , Dave Young , stern@rowland.harvard.edu, peterz@infradead.org, davem@davemloft.net, krh@redhat.com, dbrownell@users.sourceforge.net, James.Bottomley@hansenpartnership.com, a.zummo@towertech.it, cbou@mail.ru, dwmw2@infradead.org, linux1394-devel@lists.sourceforge.net, spi-devel-general@lists.sourceforge.net, linux-scsi@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/7] convert semaphore to mutex in struct class References: <20080103055019.GA4885@darkstar.te-china.tietoenator.com> <20080107020944.GA3637@darkstar.te-china.tietoenator.com> <20080107084528.GA8365@suse.de> <200801070101.15168.david-b@pacbell.net> <478227D5.8050402@s5r6.in-berlin.de> <20080107140014.GA2961@ff.dom.local> In-Reply-To: <20080107140014.GA2961@ff.dom.local> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 942 Lines: 24 Jarek Poplawski wrote: >> David Brownell wrote: >> > On Monday 07 January 2008, Greg KH wrote: >> >> Most of the non-driver core code should be converted to not use the >> >> lock in the class at all. They should use a local lock instead. >> > >> > Or better yet, that yet-to-be-written class_for_each_instance() >> > iterator ... :) ... > I hope I'm wrong, but IMHO it should be safer not to mix such changes, > so do the mutexes first or delay them until the end. Otherwise some > false blaming seems almost inevitable. I agree. Sem2mutex conversion should not be mixed with API conversion, even if one or both seem trivial. -- Stefan Richter -=====-==--- ---= --=== http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/