Received-SPF: pass (google.com: domain of linux-kernel+bounces-100151-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Tue, 12 Mar 2024 13:01:00 +0200 (EET)
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
cc: Ike Panhc <ike.pan@canonical.com>, Hans de Goede <hdegoede@redhat.com>, 
    Philipp Jungkamp <p.jungkamp@gmx.net>, Gergo Koteles <soyer@irl.hu>, 
    platform-driver-x86@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>, 
    linux-input@vger.kernel.org
Subject: Re: [PATCH 0/2] map Fn + R key on newer Yogas and Legions
In-Reply-To: <Ze9RU8Mbnl-w8ZUL@google.com>
Message-ID: <3aa59524-1d66-0536-a0e0-264e6b089aa5@linux.intel.com>
References: <cover.1708399689.git.soyer@irl.hu> <170895405312.2243.4199399921923370447.b4-ty@linux.intel.com> <Ze0PSaOQSJMxL_Ln@google.com> <269b8adf-426a-b614-5450-383cde095c75@linux.intel.com> <Ze9RU8Mbnl-w8ZUL@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-859821774-1710241260=:1770"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-859821774-1710241260=:1770
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Mon, 11 Mar 2024, Dmitry Torokhov wrote:

> On Mon, Mar 11, 2024 at 12:53:36PM +0200, Ilpo J=E4rvinen wrote:
> > On Sat, 9 Mar 2024, Dmitry Torokhov wrote:
> >=20
> > > On Mon, Feb 26, 2024 at 03:27:33PM +0200, Ilpo J=E4rvinen wrote:
> > > > On Tue, 20 Feb 2024 04:39:34 +0100, Gergo Koteles wrote:
> > > >=20
> > > > > This patch series adds a new KEY_FN_R input event code and map th=
e
> > > > > Fn + R key to it in the ideapad-laptop driver.
> > > > >=20
> > > > > It affects two WMI keycodes and I couldn't try the 0x0a, but I co=
uldn't
> > > > > find any indication that the refresh rate toggle should not be Fn=
 + R.
> > > > >=20
> > > > > Regards,
> > > > > Gergo
> > > > >=20
> > > > > [...]
> > > >=20
> > > >=20
> > > > Thank you for your contribution, it has been applied to my local
> > > > review-ilpo branch. Note it will show up in the public
> > > > platform-drivers-x86/review-ilpo branch only once I've pushed my
> > > > local branch there, which might take a while.
> > > >=20
> > > > The list of commits applied:
> > > > [1/2] Input: allocate keycode for Fn + R
> > > >       commit: 4e45fa464aeef4e803412b5dcce73aad48c94b0e
> > >=20
> > > I am sorry for the delay, but instead of defining a generic name we s=
hould define
> > > a proper keycode for concrete action even if nothing is printed on a
> > > particular key on a particular device.
> > >=20
> > > Please drop this patch.
> >=20
> > Dropping them at this point would bit of a hassle due to backmerges of
> > fixes branch.
>=20
> You should really wait applying patches affecting other parts of the
> kernel as well as UAPI until all maintainers responsible for them agree
> with the changes.
>=20
> Thanks.

I'm sorry about that. I'll try to be more careful in the future.

I've now replaced those patches in pdx86/for-next.

--=20
 i.

--8323328-859821774-1710241260=:1770--