Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp987810lql; Tue, 12 Mar 2024 04:22:53 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVjIDX/S8zEKAW07/vpljjvKIFA+DHtHHeFOIkwG64yuXbJGarH1sMk47wzwqlpVzaBX6jCieQDz6O+jw4j5w7KhJ5pR80pB/+e2aMkoA== X-Google-Smtp-Source: AGHT+IHre0LPvVlVXIFWLfROuldc9W6mByDWxzXJU7zNBC0xo9ke0JQM62RRJ8BEOD8diUYDli3O X-Received: by 2002:a05:622a:1353:b0:42e:febb:8cf6 with SMTP id w19-20020a05622a135300b0042efebb8cf6mr2049854qtk.36.1710242573457; Tue, 12 Mar 2024 04:22:53 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710242573; cv=pass; d=google.com; s=arc-20160816; b=WR48WUUzxjTk6xiKUF1yZPmJChvHEDu6x95+bhxI+CWU8W8Wwh7Ge3Qf3NsyxbfM8U Kw2vNCU9ss997tQh/Q1KqqSes0Klm7Xh++aSIVdx0rswTkwFVDW/WLlu1HgWluwZl2GR HGwGYmATJe/tSG7d9rXOHONPvYr1fH1v/GK1I+rspMU2jgPk46mZoOzJuQAdmwnXspDk Vb+S3vwXihXK0gXxfgWOF+1/dWP6/tBvnXtbbYEbAtLmRcCkWNMC3XFJnwElfVuEiiDM o8Nlb7CCPG446pJGVQCm2fU88omHmwJfgupgwu7W+zgwTX2kZiFAnzHSTo9HFjx/s5fS PSmA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:autocrypt:references :in-reply-to:date:cc:to:from:subject:message-id:dkim-signature; bh=s5vMBHYZtJxO3NM5if4qDYbHgeTRIkuKGIeNaK3F1jE=; fh=TkufRjY2QvYj4ScragVARkxdEy5q0XePeqvFkRBSUkg=; b=Q5Md3pJvFqt77AxcmPBMaDhth3GdJKIYztp1Z5HecFLHtuR1Hu6j6HZd1BoiD+SBPX XL0WXeBMOKUq7uAq6/ffsVqFmlioUfwrdaCG8iNY5Pym697ZvnA/S9gNAXAguWOwn7Sg mkRfjoEKhqucccyCG59h5kce5WyQse6zaLO6BQxcqvcDUP6Jh3uh8dzwAUHdA7M40JPe TcYP056pHM2QP5VRZWOL8X79h3fzK+CBaErV1OT8k7MceckS/jqsHb8y8XWh8DtEZ+n+ 361i8kZE5+VTsLHLzhVHqCpqv/wTRkdy/3qrMmy5YIPKpabVs5F2TWvCH8i/N/qA2fh5 B8mA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eytkYePv; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-100170-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100170-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id u4-20020a05622a010400b0042e24608caesi649497qtw.654.2024.03.12.04.22.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 04:22:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-100170-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eytkYePv; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-100170-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100170-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id D43391C21666 for ; Tue, 12 Mar 2024 11:22:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D6D2A79DAA; Tue, 12 Mar 2024 11:22:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eytkYePv" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 103E679B85 for ; Tue, 12 Mar 2024 11:22:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710242555; cv=none; b=VRjFQZIM72m6i0cA1C1p3W2rNxTvRmJVvJJmiiOvNdIYLO4BtEj1zIDSR8rgD3Pfu0mBHFNdefs83yV3eZFRNYMVSiEanxTHtMFY36fl0PxjRxlo0R7Z8SrHZnQWK1HwoK55GL+wrDzqQs7DTXrAKnMDvyUDDqkqjwZG7SENPIY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710242555; c=relaxed/simple; bh=NLCXkr5Zuk6kdLKNOJuPB60TG7iCZH6aOKYJBL0V7ik=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=pEg7EOAZoq4d7aDmI1yrXYrGqTjE8bKhoLnTwagb4m2g29LhZ6YsZcgbH8Nom7qQ3NwU3MOK10LIBpG9AkFbbYboB0ZfRc13C3lrVGKwTTtr9aehepOImlzmOoJ+K8cV6kQ1NG9D/mpy4jQ1IGI8VH5x6HRuNg381VrOTcs5MaY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=eytkYePv; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710242552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=s5vMBHYZtJxO3NM5if4qDYbHgeTRIkuKGIeNaK3F1jE=; b=eytkYePvWx6IrcjKeZvNqjyaKlfubt1osedhIk0NsOsUwLnRJmuR4EIt+vKh7aUi/euxzP tBqxvuNCCB2Hf9s/PDtxHnnqBU6VZxbfbh/mnh/EcOxe64FrwloGts2UHL9yWBZXao5OJy jk7NSUDc7eqYFhQZEm0uGV5FEMBJvqQ= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-379-5X3Vva2XOUGsbnSVbZQ20Q-1; Tue, 12 Mar 2024 07:22:31 -0400 X-MC-Unique: 5X3Vva2XOUGsbnSVbZQ20Q-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2d461a51d4aso689741fa.1 for ; Tue, 12 Mar 2024 04:22:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710242550; x=1710847350; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s5vMBHYZtJxO3NM5if4qDYbHgeTRIkuKGIeNaK3F1jE=; b=Z/oF6kQP2zR1+1k/cYqHUZEPSEj7FLR9EUWLp8j0r7Tm19HieQJ3mA6ftJn6BMcVv8 5RjLpShbxM9xeQnL7MkWoLh38o4uFkKGQIjaqNZk/AvNKqTbA9saovwI5fRwo1HC9ong 9LYgLPQNa+QFhzWAcXDqFIR5ge2mg5zogwkoiFJ7EfnA1Ot9JuSzM9mjG1EwU8J2lul1 6dn49qyOR3MQ9R+G5X4qo6X37kv9wSlxNolYIgXwx7k7QhvkvYsLFv/1siFu7U8scS8g mh4v9Omq6Hls2q8RvnmKJAc7W/lY6++0OYvbJBDw6wZNfFFgY0Mby/WZmqXjuErnMx8/ qMSg== X-Forwarded-Encrypted: i=1; AJvYcCWvYaTrbTfljb7cvYMcAJSnRkwLCuq9HRfEEM/2wnJts9x/bCM/m+1hU/siuapBv6FA7w9ZNsXGAoq3YRd4NAaqSmBvqNIjws+wTQlI X-Gm-Message-State: AOJu0YwH0laTun5XB0QDWPrFmxhVVF0jpxIa1qHSDuq96D7hQ2zwMT1O fhWEfOK0PQdR1GE9e7tjqhcD14RmN5FWJ60uqfxz+q2PkENlmIE1v++wQjqu5gvVKhrMLKTXT7u 8WGMtF9/ZCtMlxPWjt9ZpjOknSayqHbHhYhCbR4S+dB9FFxyRHHTOoUD4BG1yfw== X-Received: by 2002:a2e:7e0e:0:b0:2d3:fca:dae6 with SMTP id z14-20020a2e7e0e000000b002d30fcadae6mr5374000ljc.2.1710242549963; Tue, 12 Mar 2024 04:22:29 -0700 (PDT) X-Received: by 2002:a2e:7e0e:0:b0:2d3:fca:dae6 with SMTP id z14-20020a2e7e0e000000b002d30fcadae6mr5373986ljc.2.1710242549618; Tue, 12 Mar 2024 04:22:29 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-226-128.dyn.eolo.it. [146.241.226.128]) by smtp.gmail.com with ESMTPSA id k16-20020a1709067ad000b00a4537466591sm3763609ejo.32.2024.03.12.04.22.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 04:22:29 -0700 (PDT) Message-ID: <570d5e37b84d5e2907e4b195d6c6df8c5e6c8830.camel@redhat.com> Subject: Re: [net PATCH 1/5] octeontx2: Detect the mbox up or down message via register From: Paolo Abeni To: Subbaraya Sundeep , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, sgoutham@marvell.com, lcherian@marvell.com, gakula@marvell.com, hkelam@marvell.com, naveenm@marvell.com, horms@kernel.org Date: Tue, 12 Mar 2024 12:22:27 +0100 In-Reply-To: <1710184612-29027-2-git-send-email-sbhatta@marvell.com> References: <1710184612-29027-1-git-send-email-sbhatta@marvell.com> <1710184612-29027-2-git-send-email-sbhatta@marvell.com> Autocrypt: addr=pabeni@redhat.com; prefer-encrypt=mutual; keydata=mQINBGISiDUBEAC5uMdJicjm3ZlWQJG4u2EU1EhWUSx8IZLUTmEE8zmjPJFSYDcjtfGcbzLPb63BvX7FADmTOkO7gwtDgm501XnQaZgBUnCOUT8qv5MkKsFH20h1XJyqjPeGM55YFAXc+a4WD0YyO5M0+KhDeRLoildeRna1ey944VlZ6Inf67zMYw9vfE5XozBtytFIrRyGEWkQwkjaYhr1cGM8ia24QQVQid3P7SPkR78kJmrT32sGk+TdR4YnZzBvVaojX4AroZrrAQVdOLQWR+w4w1mONfJvahNdjq73tKv51nIpu4SAC1Zmnm3x4u9r22mbMDr0uWqDqwhsvkanYmn4umDKc1ZkBnDIbbumd40x9CKgG6ogVlLYeJa9WyfVMOHDF6f0wRjFjxVoPO6p/ZDkuEa67KCpJnXNYipLJ3MYhdKWBZw0xc3LKiKc+nMfQlo76T/qHMDfRMaMhk+L8gWc3ZlRQFG0/Pd1pdQEiRuvfM5DUXDo/YOZLV0NfRFU9SmtIPhbdm9cV8Hf8mUwubihiJB/9zPvVq8xfiVbdT0sPzBtxW0fXwrbFxYAOFvT0UC2MjlIsukjmXOUJtdZqBE3v3Jf7VnjNVj9P58+MOx9iYo8jl3fNd7biyQWdPDfYk9ncK8km4skfZQIoUVqrWqGDJjHO1W9CQLAxkfOeHrmG29PK9tHIwARAQABtB9QYW9sbyBBYmVuaSA8cGFiZW5pQHJlZGhhdC5jb20+iQJSBBMBCAA8FiEEg1AjqC77wbdLX2LbKSR5jcyPE6QFAmISiDUCGwMFCwkIBwIDIgIBBhUKCQgLAgQWAgMBAh4HAheAAAoJECkkeY3MjxOkJSYQAJcc6MTsuFxYdYZkeWjW//zbD3ApRHzpNlHLVSuJqHr9/aDS+tyszgS8jj9MiqALzgq4iZbg 7ZxN9ZsDL38qVIuFkSpgMZCiUHdxBC11J8nbBSLlpnc924UAyr5XrGA99 6Wl5I4Km3128GY6iAkH54pZpOmpoUyBjcxbJWHstzmvyiXrjA2sMzYjt3Xkqp0cJfIEekOi75wnNPofEEJg28XPcFrpkMUFFvB4Aqrdc2yyR8Y36rbw18sIX3dJdomIP3dL7LoJi9mfUKOnr86Z0xltgcLPGYoCiUZMlXyWgB2IPmmcMP2jLJrusICjZxLYJJLofEjznAJSUEwB/3rlvFrSYvkKkVmfnfro5XEr5nStVTECxfy7RTtltwih85LlZEHP8eJWMUDj3P4Q9CWNgz2pWr1t68QuPHWaA+PrXyasDlcRpRXHZCOcvsKhAaCOG8TzCrutOZ5NxdfXTe3f1jVIEab7lNgr+7HiNVS+UPRzmvBc73DAyToKQBn9kC4jh9HoWyYTepjdcxnio0crmara+/HEyRZDQeOzSexf85I4dwxcdPKXv0fmLtxrN57Ae82bHuRlfeTuDG3x3vl/Bjx4O7Lb+oN2BLTmgpYq7V1WJPUwikZg8M+nvDNcsOoWGbU417PbHHn3N7yS0lLGoCCWyrK1OY0QM4EVsL3TjOfUtCNQYW9sbyBBYmVuaSA8cGFvbG8uYWJlbmlAZ21haWwuY29tPokCUgQTAQgAPBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEoitAhsDBQsJCAcCAyICAQYVCgkICwIEFgIDAQIeBwIXgAAKCRApJHmNzI8TpBzHD/45pUctaCnhee1vkQnmStAYvHmwrWwIEH1lzDMDCpJQHTUQOOJWDAZOFnE/67bxSS81Wie0OKW2jvg1ylmpBA0gPpnzIExQmfP72cQ1TBoeVColVT6Io35BINn+ymM7c0Bn8RvngSEpr3jBtqvvWXjvtnJ5/HbOVQCg62NC6ewosoKJPWpGXMJ9SKsVIOUHsmoWK60spzeiJoSmAwm3zTJQnM5kRh2q iWjoCy8L35zPqR5TV+f5WR5hTVCqmLHSgm1jxwKhPg9L+GfuE4d0SWd84y GeOB3sSxlhWsuTj1K6K3MO9srD9hr0puqjO9sAizd0BJP8ucf/AACfrgmzIqZXCfVS7jJ/M+0ic+j1Si3yY8wYPEi3dvbVC0zsoGj9n1R7B7L9c3g1pZ4L9ui428vnPiMnDN3jh9OsdaXeWLvSvTylYvw9q0DEXVQTv4/OkcoMrfEkfbXbtZ3PRlAiddSZA5BDEkkm6P9KA2YAuooi1OD9d4MW8LFAeEicvHG+TPO6jtKTacdXDRe611EfRwTjBs19HmabSUfFcumL6BlVyceIoSqXFe5jOfGpbBevTZtg4kTSHqymGb6ra6sKs+/9aJiONs5NXY7iacZ55qG3Ib1cpQTps9bQILnqpwL2VTaH9TPGWwMY3Nc2VEc08zsLrXnA/yZKqZ1YzSY9MGXWYLkCDQRiEog1ARAAyXMKL+x1lDvLZVQjSUIVlaWswc0nV5y2EzBdbdZZCP3ysGC+s+n7xtq0o1wOvSvaG9h5q7sYZs+AKbuUbeZPu0bPWKoO02i00yVoSgWnEqDbyNeiSW+vI+VdiXITV83lG6pS+pAoTZlRROkpb5xo0gQ5ZeYok8MrkEmJbsPjdoKUJDBFTwrRnaDOfb+Qx1D22PlAZpdKiNtwbNZWiwEQFm6mHkIVSTUe2zSemoqYX4QQRvbmuMyPIbwbdNWlItukjHsffuPivLF/XsI1gDV67S1cVnQbBgrpFDxN62USwewXkNl+ndwa+15wgJFyq4Sd+RSMTPDzDQPFovyDfA/jxN2SK1Lizam6o+LBmvhIxwZOfdYH8bdYCoSpqcKLJVG3qVcTwbhGJr3kpRcBRz39Ml6iZhJyI3pEoX3bJTlR5Pr1Kjpx13qGydSMos94CIYWAKhegI06aTdvvuiigBwjngo/Rk5S+iEGR5KmTqGyp27o6YxZy6D4NIc6PKUzhIUxfvuHNvfu sD2W1U7eyLdm/jCgticGDsRtweytsgCSYfbz0gdgUuL3EBYN3JLbAU+UZpy v/fyD4cHDWaizNy/KmOI6FFjvVh4LRCpGTGDVPHsQXaqvzUybaMb7HSfmBBzZqqfVbq9n5FqPjAgD2lJ0rkzb9XnVXHgr6bmMRlaTlBMAEQEAAYkCNgQYAQgAIBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEog1AhsMAAoJECkkeY3MjxOkY1YQAKdGjHyIdOWSjM8DPLdGJaPgJdugHZowaoyCxffilMGXqc8axBtmYjUIoXurpl+f+a7S0tQhXjGUt09zKlNXxGcebL5TEPFqgJTHN/77ayLslMTtZVYHE2FiIxkvW48yDjZUlefmphGpfpoXe4nRBNto1mMB9Pb9vR47EjNBZCtWWbwJTIEUwHP2Z5fV9nMx9Zw2BhwrfnODnzI8xRWVqk7/5R+FJvl7s3nY4F+svKGD9QHYmxfd8Gx42PZc/qkeCjUORaOf1fsYyChTtJI4iNm6iWbD9HK5LTMzwl0n0lL7CEsBsCJ97i2swm1DQiY1ZJ95G2Nz5PjNRSiymIw9/neTvUT8VJJhzRl3Nb/EmO/qeahfiG7zTpqSn2dEl+AwbcwQrbAhTPzuHIcoLZYV0xDWzAibUnn7pSrQKja+b8kHD9WF+m7dPlRVY7soqEYXylyCOXr5516upH8vVBmqweCIxXSWqPAhQq8d3hB/Ww2A0H0PBTN1REVw8pRLNApEA7C2nX6RW0XmA53PIQvAP0EAakWsqHoKZ5WdpeOcH9iVlUQhRgemQSkhfNaP9LqR1XKujlTuUTpoyT3xwAzkmSxN1nABoutHEO/N87fpIbpbZaIdinF7b9srwUvDOKsywfs5HMiUZhLKoZzCcU/AEFjQsPTATACGsWf3JYPnWxL9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2024-03-12 at 00:46 +0530, Subbaraya Sundeep wrote: > +bool otx2_mbox_wait_for_zero(struct otx2_mbox *mbox, int devid) > +{ > + u64 data; > + > + data =3D readq((void __iomem *)mbox->reg_base + > + (mbox->trigger | (devid << mbox->tr_shift))); > + > + /* If data is non-zero wait for ~1ms and return to caller > + * whether data has changed to zero or not after the wait. > + */ > + > + if (data) > + usleep_range(950, 1000); > + else > + return true; Since you have to repost, if (!data) return true; usleep_range(950, 1000); will be more readable Side note: this quite huge for a 'net' patch: it would be nice (but not mandatory) if you could break it in smaller pieces or consider a 'net- next' target. In the latter case, please note that 'net-next' is currently closed for the merge window. Cheers, Paolo