Received-SPF: pass (google.com: domain of linux-kernel+bounces-100196-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240311133223.3429428-1-max.kellermann@ionos.com>
In-Reply-To: <20240311133223.3429428-1-max.kellermann@ionos.com>
From: Linus Walleij <linus.walleij@linaro.org>
Date: Tue, 12 Mar 2024 12:54:28 +0100
Message-ID: <CACRpkdYwHyDt9xdLxY5J4jPnX1G0X9DzKr_1jW9CJFNG5HzNwA@mail.gmail.com>
Subject: Re: [PATCH] drivers/gpio/nomadik: move dummy nmk_gpio_dbg_show_one()
 to header
To: Max Kellermann <max.kellermann@ionos.com>
Cc: brgl@bgdev.pl, linux-arm-kernel@lists.infradead.org, 
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 11, 2024 at 2:32=E2=80=AFPM Max Kellermann <max.kellermann@iono=
s.com> wrote:

> When `CONFIG_DEBUG_FS` is disabled, nmk_gpio_dbg_show_one() is an
> empty dummy function; this however triggers a `-Wmissing-prototypes`
> warning and later a linker error because the function is also used by
> drivers/pinctrl/nomadik/pinctrl-nomadik.c, therefore it needs to be
> non-static.
>
> To allow both sources to access this dummy function, this patch moves
> it to the header, adding the `#ifdef CONFIG_DEBUG_FS` there as well.
>
> Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

I made a patch myself yesterday and applied, but I like your patch more
so I took out my patch and put in yours instead.

Thanks!

Yours,
Linus Walleij