Received-SPF: pass (google.com: domain of linux-kernel+bounces-100251-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 12 Mar 2024 13:13:40 +0100
From: Andrejs Cainikovs <andrejs.cainikovs@toradex.com>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: Andrejs Cainikovs <andrejs.cainikovs@gmail.com>,
	patches@opensource.cirrus.com, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>
Subject: Re: [RFC PATCH v1] ASoC: wm8904: enable fll with fixed mclk
Message-ID: <ZfBG9IMFEjjIdgdi@toradex.com>
References: <20240308155831.141229-1-andrejs.cainikovs@gmail.com>
 <Ze7smWSeoCVIcxIo@ediswmail9.ad.cirrus.com>
In-Reply-To: <Ze7smWSeoCVIcxIo@ediswmail9.ad.cirrus.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QNCi58KEAFhGIfjXIkdbF6/gjGJ+OhugXq+2B/qP4znWpm7VnUtUqt9rsx8k?=
 =?us-ascii?Q?brTBALR+ZEZ9oWnYrK5PcvXotJr8jBwl5t/PXv+EKfBrMG53XQr7bvuzrdfs?=
 =?us-ascii?Q?hE5iXvyL1Bqc3zX4lciLpu9UeMm6RjFjxx9wIgpxOgezXQX6YBJk9bYlweNr?=
 =?us-ascii?Q?rVsLPmO10Gj4Vl6DqHlyrCvURUrzmzL8/mz1dhaMqDSVVkKSxM/Aj2RiYVJi?=
 =?us-ascii?Q?KXESBPXYgPyqpRNeQR/Xoqoum/tfE9CaezHF51JjnhBYVCjD8oBrQplqzt+h?=
 =?us-ascii?Q?LX6V/YM/n071aTasLVrU7H9hqFk9V1hVYQwx8gvNA99KdvyWhNOLgXMOVlW4?=
 =?us-ascii?Q?pGvYto132a2bi2bxB9+eih0ta5Yfer/701VFMc4JN9/278o/8iId3JxmtTWY?=
 =?us-ascii?Q?5m7/Y2GYReOVcHo3Cpn5rQBNNVLpq+H9x1VAJ1AHKvu9DVudOFX6EauCyyoz?=
 =?us-ascii?Q?+iYgLupUydKNdieV14Ct7ois3qIvgNtD5IBjZnfiqZYrf73MbmF/OvtK87k3?=
 =?us-ascii?Q?pgp9sw9iqimCOXXHf6NmK6RldJgQiqWJKRmAQRIO01i9141ILH7/RP0k6JRs?=
 =?us-ascii?Q?HKepdaNEztW/gsw5HJjtyia39wSgwUP7fM6SaV74TV6xYw5rpf1UuhMnc1mz?=
 =?us-ascii?Q?GF6jiE2Hhm+VRlBbPUcES5dIYrsadj3iL/wZ9LLcIAoU2k99hdL+i752h7cF?=
 =?us-ascii?Q?SBkIU+lMoT5/Yo7Ytx8r+h5ncEMXMD+lxUWkSqOhb7hDfQRQ8Qi6hBNwvFWl?=
 =?us-ascii?Q?0EaYyYr52r7/1peQPFegvUQTRjqNGwsn5JA+sqvuCnNqOQzNFdnQcHYi3FsU?=
 =?us-ascii?Q?Kz5/IhyoEO0U/DwWnYrEZubvYi3EDu4NMRk2qdZdG0AZ0Um4LzgqKZWR4zGR?=
 =?us-ascii?Q?2wj6nnBQzr+pAQsL5uj/17hYGTxgZHrrng7eaXGI3JkV0FXf7uMv+WGzFP5S?=
 =?us-ascii?Q?KMsAwyhX3YJl6IdudnaZ66H0OCg06aeZnB7PngdSzHy9bH0KvufdPcbaQBqb?=
 =?us-ascii?Q?rz1BIalQNWkL6mQPAo7FrunpIAlyjE45yuVofTdrh65WCT0VC/CIt3kO01t/?=
 =?us-ascii?Q?ROx7oppFWPp3LdzCA4EPUs52pJIdRE/OOwhbqfUeXmpT5cgUk+sZsdgJunpR?=
 =?us-ascii?Q?7xjkAEJ2zBCKcCwwZNPkvv4WdIt7DpPKxMXjYeaiwg1v3nB87Bqw00iTPF9J?=
 =?us-ascii?Q?Z07NsjPs9I1ezxuM52kTTbug/Ma4/mkIKkovEkEadosarMhUoxWWRFTPZV1N?=
 =?us-ascii?Q?YiZGIu5zbd+kKwO1YXtUapDbyS8njCw7mcIAlrtYz3eytGDeBcWhBVwuE+JA?=
 =?us-ascii?Q?BV4ZOWAomhWnWaV2HgNMBBtm/vTiba/kFthbDq+zS9q7jwbLYF6SAyU2pVm3?=
 =?us-ascii?Q?PtwgrrGz7+yOwffS+c7VMxmYig3HRU7JlPChj3/WvOGzTCjFkgR7FO5ZQX26?=
 =?us-ascii?Q?hvt583cZsn7nhGuz1xPRGT5uDfUaU/11IZ2SqmKigPB8ITd8qs9e3tIyht6J?=
 =?us-ascii?Q?dyIH1hBscy2DLMa6fdJuGWxgJuREc8GKTCvB8HTAcf7VUZKj/AMu5NAg+Nzq?=
 =?us-ascii?Q?VlKww+0HF7o7RNgPwbJc9BGxwuLOd8Pr5fiqN7S+3os7qPlWL3aczteBk1c1?=
 =?us-ascii?Q?ng=3D=3D?=
X-OriginatorOrg: toradex.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d2cdae49-b22c-4ebd-a39d-08dc428ddbe7
X-MS-Exchange-CrossTenant-AuthSource: ZRAP278MB0254.CHEP278.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2024 12:13:42.8136
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d9995866-0d9b-4251-8315-093f062abab4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5ZJ6kxyMBZtW3gNSg9Ttq/iyfssdd5g9V1DjjZwdzBVK2qXqQQ8LVcsCWUjsWIofaX7OUbPcWQV9p2tMpEsctfwmk/xXvjVnA9Hw4dzqeAY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV0P278MB1106
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: toradex.com
Content-Type: text/plain; charset=WINDOWS-1252
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 11, 2024 at 11:35:53AM +0000, Charles Keepax wrote:
> On Fri, Mar 08, 2024 at 04:58:31PM +0100, Andrejs Cainikovs wrote:
> > From: Andrejs Cainikovs <andrejs.cainikovs@toradex.com>
> >=20
> > Dear all,
> >=20
> > This is an attempt to change wm8904 for a scenario when reference clock
> > supposed to be fixed to a particular frequency, but is not configured a=
s
> > a fixed-clock. While this change is working fine, I'm struggling to
> > finalize it, not being able to find a proper solution of adding a check
> > whether we want to use fixed MCLK with codec's FLL or not. I could, of
> > course, introduce a new device tree property, but do not feel this woul=
d
> > be a proper way forward. Hence, I'm sending out this RFC patch to gathe=
r
> > your valuable feedback.
> >=20
> > DUT: Dahlia carrier board with Verdin TI AM62 SOM.
> > Audio card configuration can be found in ti/k3-am62-verdin-dahlia.dtsi.
>=20
> At some point one really starts to question if this is really a
> "simple card" any more.
>=20
> > On systems with a fixed reference clock output rate it
> > is impossible to use this clock for all audio frequencies.
> >=20
> > Following is an example of playing a 44100Hz audio on a system
> > with a fixed 25MHz reference clock applied to wm8904 codec,
> > in combination with simple-audio-card without mclk-fs:
> >=20
> > [   27.013564] wm8904 1-001a: Target BCLK is 1411200Hz
> > [   27.013601] wm8904 1-001a: Using 25000000Hz MCLK
> > [   27.013611] wm8904 1-001a: CLK_SYS is 12500000Hz
> > [   27.013654] wm8904 1-001a: Selected CLK_SYS_RATIO of 256
> > [   27.013663] wm8904 1-001a: Selected SAMPLE_RATE of 44100Hz
> > [   27.013671] wm8904 1-001a: Selected BCLK_DIV of 80 for 1562500Hz BCL=
K
> > [   27.013680] wm8904 1-001a: LRCLK_RATE is 35
> >=20
> > This leads to a distorted sound and this configuration is unusable.
> >=20
> > On the other hand, configuring simple-audio-card with mclk-fs will
> > force the system to change MCLK frequency, which supposed to be fixed.
> >=20
> > This change forces to use wm8904 FLL while keeping SoC's MCLK
> > frequency intact:
> >=20
> > [  234.108149] wm8904 1-001a: Target BCLK is 1411200Hz
> > [  234.108304] wm8904 1-001a: Using 0Hz FLL clock
> > [  234.108722] wm8904 1-001a: FLL configured for 25000000Hz->1411200Hz
> > [  234.108794] wm8904 1-001a: CLK_SYS is 1411200Hz
> > [  234.108835] wm8904 1-001a: Selected CLK_SYS_RATIO of 64
> > [  234.108875] wm8904 1-001a: Selected SAMPLE_RATE of 44100Hz
> > [  234.108913] wm8904 1-001a: Selected BCLK_DIV of 10 for 1411200Hz BCL=
K
> > [  234.108955] wm8904 1-001a: LRCLK_RATE is 32
> >=20

Charles,

With or without mclk-fs wm8904_set_sysclk() is called always during probe,
with following parameters:

clk_id =3D 0
dir =3D 0
freq =3D 25000000
mclk_freq =3D 25000000

When mclk-fs is set, wm8904_set_sysclk() is also called before each
playback [1]. In case of 44.1kHz:

clk_id =3D 0
dir =3D 0
freq =3D 11289600
mclk_freq =3D 11235955

In both scenarios, clk_id is always WM8904_CLK_AUTO.

[1]: https://elixir.bootlin.com/linux/latest/source/sound/soc/generic/simpl=
e-card-utils.c#L441

Best regards,
Andrejs

> Hmm... the driver already provides an option to automatically
> configure the clock. Is the issue here that in your fail case the
> machine driver never calls wm8904_set_sysclk? Or if it does call
> it, when and what parameters is it passing?
>=20
> Thanks,
> Charles