Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp1019782lql; Tue, 12 Mar 2024 05:22:46 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXPSBFvoxhZDl8aEO066I7+cxqNkVgqMJkC82IFsCW/3NmoXtFbz/XkbWEOjlD7RP1yiksHmk88Wv2pp8BCCUisN7HcDj36XqjPMyrFag== X-Google-Smtp-Source: AGHT+IGs96HSTRv7qo/vHfQRFtrtJxoEXVjuN8JWqHmyZpjXkC6LqcdaIyDw9CYT/lTquF+fporl X-Received: by 2002:a17:907:1688:b0:a46:13f3:eb84 with SMTP id cx8-20020a170907168800b00a4613f3eb84mr169393ejd.0.1710246166018; Tue, 12 Mar 2024 05:22:46 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710246166; cv=pass; d=google.com; s=arc-20160816; b=tQf7LuyS7KSuMFs9Ol5ga7ynAORuLFd7sZbl2b/dUl4xe+rFWlgIBMAFul369A4EoJ Bv36Y3IokZXcl+TRFs/WsmkbGLecdN3AMZYx3lPdImelURFXpnk7ziSD+G5+APvaLCVH nAZUwUovmlgLUyr2t3S00sOuwdsZJ1EYWMRYFirS3qGjHueXOT+WR7XG/2zli9hY3OXd WLu7GXx31uFUZGjgAk3L+s83U4LFD2C9JsnGzizYzjfkO88C2MgOwoI6BC/VNVXefgya MDqvfeNEf90pVP2vPVkLh/uTaJSVkhaCa3yFNXPZcU1YLJ7S4u7jo2ZqGG2MTNVNAdcj 5/0Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=LO2AKRd8Qpr8cRJXSnq0WdmDa4UEpoucMUOCpS9D1/w=; fh=ZpK2BA/JkmeaJ2rKQyc5Np9nnD5JITGkhkNo7DhWPRU=; b=jlyN/d2wextMdaUL4S4KQSUc8juJXiEZDsGOWUr0+Z7TAFFRTcpORxDaYUx7z3gkk0 u+vxrAknFvq55/g/LgRh3mVrAU6fFTxeKPqiihRt+8OKM/U0AvpjGzWLX+SmN7Ew9bPc 4NooIRTPV0wFiEe09J3G0HSVnSTBZEz/RV5qDWmkoMx2o4SGiNJ8rJ5ZsnDpjnbqhS4D Td4PkxrmOTKTuZH9EQvqQVrAdcJxp7eARIzhR0o7JA49/7YE7DR+49jxAV+LwShCQB0A ejlv0dXPArXaF74x/MtVWx7fzXrwYRJ0nAqoluymocl3nKDBWWNiqCig2aptDBnI78hh GoXA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=XAJMGdVo; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-100253-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100253-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id u22-20020a170906781600b00a444b9d37b9si3258088ejm.408.2024.03.12.05.22.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 05:22:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-100253-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=XAJMGdVo; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-100253-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100253-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B86661F23F77 for ; Tue, 12 Mar 2024 12:22:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A09247A13F; Tue, 12 Mar 2024 12:22:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="XAJMGdVo" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00FF3BA28; Tue, 12 Mar 2024 12:22:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710246154; cv=none; b=pwJXHox0SDINFn5sLC84yuxeExTD+xO7A393s1VCUJuJrKDM37uQaRJpOWJDiYwDY4XKUIqka5HaZDcnBmY52o8Mp31ZVywTLYVFMQjUWzyOuLQcmbSwAdjJ8rqtcl2lV5xEb1ZjElnhCXmGqopgzCxw+5P8KVxLW+BpJ93lvr8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710246154; c=relaxed/simple; bh=zlvLjarZdeEpwMqv3ioOMOVhX7SRgglWVh5Wg6hqAjA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=M9MBguMNNZm+dCE2PzagnLkWm8L33Tv++MzrfFOnQdMt1ulVePLBDHyM4ZyoLLvZWmh51l+s+WCBeo8MXPBMzlra1oLjvp5rp1Zv91yprnh7kU3+f63qZaQf1QGAV6c/TEs8h4TvdZZ1vrhRbuTmGYxDewG3fBu/zbXYTgy2DLE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=XAJMGdVo; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LO2AKRd8Qpr8cRJXSnq0WdmDa4UEpoucMUOCpS9D1/w=; b=XAJMGdVoMdJVsIcluL5gL0GpcA R8o1KBJfBl9KSRy76maI+KMgbm1ozrr6+PVm4yhx0+UWBazHVae8neMc342CHo/QQu4YLsgYkBfxN 9WlZYSBc0g0x6F+80AMgypNg581uxPaQS699A1PTqzBkA3y2SDSYSkeSfpLjt1Qa0K8cx6ovijdHc LSB3WON2jU5fWCDccUTTToMDHcHXpi2ZAYV5EigYSijC7ZqbdIlfrcMV0eHEksvzOEIr2YfQwdR8y bzfcX6/mff9EWVq3dk/At3xu6KryY+D/OIHffPs+BCW/kgKGMhGdeGpa8FSWkVK2R53iqKZTfOT+Z yxj3+ZKA==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rk19M-00000005itK-0dQn; Tue, 12 Mar 2024 12:22:32 +0000 Date: Tue, 12 Mar 2024 05:22:32 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Zhang Yi , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, hch@infradead.org, brauner@kernel.org, david@fromorbit.com, tytso@mit.edu, jack@suse.cz, yi.zhang@huawei.com, chengzhihao1@huawei.com, yukuai3@huawei.com Subject: Re: [PATCH 3/4] iomap: don't increase i_size if it's not a write operation Message-ID: References: <20240311122255.2637311-1-yi.zhang@huaweicloud.com> <20240311122255.2637311-4-yi.zhang@huaweicloud.com> <20240311154829.GU1927156@frogsfrogsfrogs> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240311154829.GU1927156@frogsfrogsfrogs> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Mon, Mar 11, 2024 at 08:48:29AM -0700, Darrick J. Wong wrote: > This change should be a separate patch with its own justification. > Which is, AFAICT, something along the lines of: > > "Unsharing and zeroing can only happen within EOF, so there is never a > need to perform posteof pagecache truncation if write begin fails." Agreed. > > Signed-off-by: Zhang Yi > > Doesn't this patch fix a bug in ext4? Only with the not yet merged ext4 conversion to iomap for buffered I/O, which is not merged yet.