Received-SPF: pass (google.com: domain of linux-kernel+bounces-100293-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <af8acdb7-8cc9-422a-a38d-8a4507ab11a1@amd.com>
Date: Tue, 12 Mar 2024 08:30:24 -0500
User-Agent: Mozilla Thunderbird
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v2 00/17] x86/resctrl : Support AMD Assignable Bandwidth
 Monitoring Counters (ABMC)
Content-Language: en-US
To: Reinette Chatre <reinette.chatre@intel.com>,
 Peter Newman <peternewman@google.com>
Cc: James Morse <james.morse@arm.com>, corbet@lwn.net, fenghua.yu@intel.com,
 tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
 paulmck@kernel.org, rdunlap@infradead.org, tj@kernel.org,
 peterz@infradead.org, yanjiewtw@gmail.com, kim.phillips@amd.com,
 lukas.bulwahn@gmail.com, seanjc@google.com, jmattson@google.com,
 leitao@debian.org, jpoimboe@kernel.org, rick.p.edgecombe@intel.com,
 kirill.shutemov@linux.intel.com, jithu.joseph@intel.com,
 kai.huang@intel.com, kan.liang@linux.intel.com,
 daniel.sneddon@linux.intel.com, pbonzini@redhat.com, sandipan.das@amd.com,
 ilpo.jarvinen@linux.intel.com, maciej.wieczor-retman@intel.com,
 linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, eranian@google.com
References: <20231201005720.235639-1-babu.moger@amd.com>
 <32a588e2-7b09-4257-b838-4268583a724d@intel.com>
 <088878bd-7533-492d-838c-6b39a93aad4d@amd.com>
 <9b20589b-6220-4ae7-bfc4-4a826b7114b1@intel.com>
 <5ddb7031-a828-4001-bfdf-5477cb85e9ed@amd.com>
 <1738493b-3248-4c9e-82a8-1599a033440d@intel.com>
 <369ab28a-f3fa-4359-8e73-4dcf214c9b6e@amd.com>
 <54687d59-d0e4-4fe7-b25f-dc1fead01ea1@intel.com>
 <11487a31-908e-d474-50c6-65617d417deb@amd.com>
 <c73f444b-83a1-4e9a-95d3-54c5165ee782@intel.com>
 <55b545fd-2851-0d0f-ac37-ec59838fb4b4@amd.com>
 <1f366890-d9ff-4ac4-9af9-1ea3128a87fc@intel.com>
 <41ca7504-c3fb-ddb6-e149-4ff82019d678@amd.com>
 <CALPaoCi=PCWr6U5zYtFPmyaFHU_iqZtZL-LaHC2mYxbETXk3ig@mail.gmail.com>
 <1d3e8b68-28fa-419b-b129-0c39df34f718@intel.com>
 <CALPaoChJPkfrMgFDhtZqwK7O8=A71CKLzQjEMG6LbgB9RhdzvA@mail.gmail.com>
 <e90ce54c-a830-4ba5-8b28-aeef06705d01@intel.com>
 <46065d68-8334-4b76-bc68-c2695e7b98de@amd.com>
 <ec15db92-24bb-46eb-963c-e872ff2ac9e3@intel.com>
From: "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <ec15db92-24bb-46eb-963c-e872ff2ac9e3@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ejMyaWlsQ2FqdmhvaE1rQ25WblJZVzE5U0lrSVRWdlFheEdzMlk3NW1XYjZX?=
 =?utf-8?B?WitHRVAxNnJaeTZRYUh2R3NaWXZSK2pCTVk3ek1lUVhzNXo0M0ZBRDFGeWdM?=
 =?utf-8?B?V2FMdEZCd05qSjcybDQwcGFXc3piRjZzbk5hWGsydTdXSHFYSUM0eFkraldh?=
 =?utf-8?B?RjJEZjVyR25sdkJWdXpXaTN3Q01kTmxNTGlnNUdya0hYVk1PTW5Qem1mNXdJ?=
 =?utf-8?B?RDJETkdTZ1Y2WFFKSUxNQ1N1QmtNRWRyT3I1TXBPSEg4Nm11eXkyOEFETzVo?=
 =?utf-8?B?YTI4OGluMG52eDNPZ09DSXdDb24wR1ZySzNvOXY2N0ZOUytoMTBWRTNaWGti?=
 =?utf-8?B?OUZkYmhoamtCVklhWDU5d2dhVzVuQjI2ODB1RVgwV0ZYK1VDb3AwZVFldU9a?=
 =?utf-8?B?aXYzZTRrN0tPZVNnRFcvN2dLTk02a1dnM1lMbnE1dEdTZGJobEZzdlN6UjFq?=
 =?utf-8?B?SFk1K2hkQTFBNVZHUnZBNGpXY1RSY2UxVi96eDk2clJIZG1ETnZKb05GTmhx?=
 =?utf-8?B?bDMvOEQ3ZVA3OTVDOWFkVkhZODdvYnF0TmZXaVNzVUZaRGc2Qkl4aXpPSHpD?=
 =?utf-8?B?NU1XN3ZteEduMW43aU1pM3Q2NHFjR3hVd09BK3ZLNHRQWFE1OUZXcVVONy9m?=
 =?utf-8?B?VXpzNitlcmJySklGaGNQTnJVakhNeXZlYW5UWE9JeHRiS3VIVWQzVkFVSW1w?=
 =?utf-8?B?WEE1SjB4SzZHOUlqTWRvU090NFpMdmRNYm1xZ2pVblJQNXc3eTBKOUp3UlU5?=
 =?utf-8?B?d2c5RG9EK2dEYm9DTjB3QmxwclZ6aHVQOFNUMVpZLzJGd2ZHdnBWSkRZMXVP?=
 =?utf-8?B?dnVnU0NNNXRjMXphU0lBOTN4ajRDYVBxbUl6blJmYnJlcW1SVzl5enVscXpr?=
 =?utf-8?B?VU9NWkJVTGxKVUw5dDVFVk9OUllRcmhOamVWZUdSQWVYcnhBbCs3Mnh2ZnFt?=
 =?utf-8?B?TW1pSm52REdmaGNZelIwdUhoNC9zenNUUmVWRlNMOFdtTGFaRlkvMElqNWpL?=
 =?utf-8?B?KzFROTNQQlg3ZENpdzREa1VJTWlBWkhJSHFLRlFUM0N5VTd3VnFRWVk0RHA3?=
 =?utf-8?B?WWwzOEFVazRIS3B5UGZUR0llSlF4REt3enM5RE9mdUhzdHpqS2JzUzFTZW1v?=
 =?utf-8?B?bURsc29GZHRDWXhDR0lVa05oZUFIYzFwZ3orZFkzQUs1VjhuSWdFKzAzelA3?=
 =?utf-8?B?YnF3ZU5qNjBhR1BlZHNzcFBCaVdDTzVkL3lQVnJNbU94MlM4czk2VEVmdUlN?=
 =?utf-8?B?Nks0dTV3UUQzbWVNT3ZtaW9qZ3hNZ1JPZzlFM0tWaXpnOVN5dktOdEh2TVVZ?=
 =?utf-8?B?TUdpME5HclY2bXU4S0doRldmRVp0SGZTTkgxa2xuV2laK2JSbHhQUTZ6aGxO?=
 =?utf-8?B?THB2NHEzU0Zwd1BqUmttMkpVMlpxV0FjZnlEbnlpblNnL0Rub0RaUENqZmdT?=
 =?utf-8?B?R015OWhKUDJoeFpaVnJOYzgvOHcxSEg0N1dONVAwb2hHbFlWNGFpdUJSQmtD?=
 =?utf-8?B?STRGbFdOalNPVFBMbHBIN1lsVXhRM2Yxd240QUVuWnpPZEdRbEl4LzFtL0Za?=
 =?utf-8?B?MGdCR0Q1MmltbUhvd2RRemh2RXJGcDhieFlFWExDRjluN1RQZldrN0lGKzZp?=
 =?utf-8?B?Y08wSkE3eEZQYU03dVVTS3hYYS9FemRFTlZYeWlYbkR0ckRvbEIvV29la0Ux?=
 =?utf-8?B?VnlDL3JqVmRVZ1NzVXFHbCs4RVN6YXBLd1l1OFpBN1c0NytJOHBUMHV3K2hw?=
 =?utf-8?B?VEJPbGN0eDZaLytWaTJiTG11RlhpbG9xcFBEVTlSNWQzczRZQ29ydGpyM2Js?=
 =?utf-8?B?S0t1MmN3Y2EzN0NtWk5CUGZoUk1KaVFCL2lBWC9VVE5GblZsMnhKVFJaRCti?=
 =?utf-8?B?UnUwYndteElWVklkK000YVhLM1o0RzZvYTVpQTRRZnpQSjY5NnVvRXRHUjh2?=
 =?utf-8?B?azlkakpGS29pUEV6cGN5YURKT2pqVmVFbVlNb3VVTU9SVjF5MXo2aDY3bTlZ?=
 =?utf-8?B?VnI1bWYwNTFEd0xVT04wdzFaTThlT3VNcmduZjBEeCs5VnE1UkVSYXBnTDhw?=
 =?utf-8?B?OEpTNXdWRDRSdXZta21KYVRCSmZmekJGUDRJTXJrVmg2OEx3RDk1UUhhdzJK?=
 =?utf-8?Q?96LY=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2dc0601b-0243-48a9-80b4-08dc429895ee
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2024 13:30:29.9193
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VDKt/H5sAsJ4MZa2Fhuxbk/6NYQfqsWIJtD0jUwE/aSp7OxQFGcJzzxQvTqS2bdy
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8715


On 3/8/24 11:20, Reinette Chatre wrote:
> Hi Babu,
> 
> On 3/7/2024 7:50 PM, Moger, Babu wrote:
>> I am also thinking about replacing the newline requirement for multiple
>> groups. Domains separate by "," and groups separate by ";".
>>
>> Something like this..
>>
>> "/c1/m1/00=_,01=_;/c1/m2/00=_,01=_;/c1/m3/00=lt,01=lt"
>>
>> Thoughts?
>>
> 
> I would prefer that resctrl uses as consistent interface as possible
> between the different files. There are a few files that already
> take domains as input (schemata, mbm_total_bytes_config,
> mbm_local_bytes_config) and they all separate domains by ";".
> I thus find it most appropriate to stick with ";" between domains.
> 
> Regarding separation of groups, in schemata file for example it is
> already custom to separate groups (resources in that case) with "\n".
> 

Ok. Sure.

-- 
Thanks
Babu Moger