Received-SPF: pass (google.com: domain of linux-kernel+bounces-100127-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Tue, 12 Mar 2024 12:35:38 +0200 (EET)
To: Andy Shevchenko <andy.shevchenko@gmail.com>
cc: Kate Hsuan <hpa@redhat.com>, Pavel Machek <pavel@ucw.cz>, 
    Lee Jones <lee@kernel.org>, linux-leds@vger.kernel.org, 
    platform-driver-x86@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>, 
    =?ISO-8859-15?Q?Andr=E9_Apitzsch?= <git@apitzsch.eu>, 
    LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] platform: x86-android-tablets: other: Add swnode
 for Xiaomi pad2 indicator LED
In-Reply-To: <Ze-I63bNzaMkHfgg@surfacebook.localdomain>
Message-ID: <18ef7e97-db6e-2dc4-5728-5a539ae4c9bb@linux.intel.com>
References: <20240306025801.8814-1-hpa@redhat.com> <20240306025801.8814-2-hpa@redhat.com> <Ze-I63bNzaMkHfgg@surfacebook.localdomain>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 12 Mar 2024, Andy Shevchenko wrote:

> Wed, Mar 06, 2024 at 10:58:00AM +0800, Kate Hsuan kirjoitti:
> > There is a KTD2026 LED controller to manage the indicator LED for Xiaomi
> > pad2. The ACPI for it is not properly made so the kernel can't get
> > a correct description of it.
> > 
> > This work add a description for this RGB LED controller and also set a
> > trigger to indicate the chaging event (bq27520-0-charging). When it is
> > charging, the indicator LED will be turn on.
> 
> Ilpo, Kate, please consider the following remarks.
> 
> ...
> 
> >  #include <linux/gpio/machine.h>
> >  #include <linux/input.h>
> >  #include <linux/platform_device.h>
> 
> + Blank line?
> 
> > +#include <dt-bindings/leds/common.h>
> 
> Not sure where to place this, some drivers put it the first, some after linux/*.
> 
> ...
> 
> > +/* main fwnode for ktd2026 */
> > +static const struct software_node ktd2026_node = {
> 
> No name?
> 
> > +};
> > +
> > +static const struct property_entry ktd2026_rgb_led_props[] = {
> > +	PROPERTY_ENTRY_U32("reg", 0),
> > +	PROPERTY_ENTRY_U32("color", LED_COLOR_ID_RGB),
> > +	PROPERTY_ENTRY_STRING("function", "indicator"),
> 
> > +	PROPERTY_ENTRY_STRING("linux,default-trigger",
> > +			      "bq27520-0-charging"),
> 
> It's less than 80, why not on a single line?
> 
> > +
> 
> Redundant blank line.
> 
> > +	{ }
> > +};
> 
> ...
> 
> > +/* B */
> 
> B for red?!
> 
> > +static const struct property_entry ktd2026_red_led_props[] = {
> > +	PROPERTY_ENTRY_U32("reg", 0),
> > +	PROPERTY_ENTRY_U32("color", LED_COLOR_ID_BLUE),
> > +	{ }
> > +};

The name with "red" and LED_COLOR_ID_BLUE are also inconsistent.

> ...
> 
> > +/* R */
> 
> R for blue?!
> 
> > +static const struct property_entry ktd2026_blue_led_props[] = {
> > +	PROPERTY_ENTRY_U32("reg", 2),
> > +	PROPERTY_ENTRY_U32("color", LED_COLOR_ID_RED),
> > +	{ }
> > +};

Here as well.

I think it's better I drop this patch (it's only in review-ilpo) and wait 
for v5 version as there's some much still to correct.


-- 
 i.