Received-SPF: pass (google.com: domain of linux-kernel+bounces-100322-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <Ze9Ie67PCSvBU+og@MOLeToid> <Ze+JxSpqc/eHfCKn@aschofie-mobl2>
In-Reply-To: <Ze+JxSpqc/eHfCKn@aschofie-mobl2>
From: Felix Kimbu <felixkimbu1@gmail.com>
Date: Tue, 12 Mar 2024 15:09:35 +0100
Message-ID: <CAK=vLxKtR_rgU3A=w7AEddM4fbtTtmAQ85aCVHYbqyEXcjP=SA@mail.gmail.com>
Subject: Re: [PATCH] staging: p80211conv: Rename local foo to decrypt_check
To: Alison Schofield <alison.schofield@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-staging@lists.linux.dev, 
	linux-kernel@vger.kernel.org, outreachy@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 11, 2024 at 11:46=E2=80=AFPM Alison Schofield
<alison.schofield@intel.com> wrote:
> 'rc' is typically used for cases like this. If the name of the function
> being called is reasonably intuitive, then 'rc' suffices for the return
> value.

Greetings Alison,
Thank you for the feedback, well noted.

> 'Also' signals that this patch is trying to do more than one thing.
> One type of 'thing' per patch please.

Dan has already address this, perhaps, I did not write the message correctl=
y,
suggesting that the patch does more than one thing.

> The commit message prefixes are off. Please see First Patch Tutorial
> Section: "Following the Driver commit style"
>
> Patch fails checkpatch. Please see First Patch Tutorial Sections:
> "Git post-commit hooks" and "Understand patch best practices"

I will definitely fix these, thanks again immensely.
--