Received-SPF: pass (google.com: domain of linux-kernel+bounces-100335-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <Ze9Ie67PCSvBU+og@MOLeToid> <9bffd12a-afae-45cd-a4f3-451872146bf3@moroto.mountain>
In-Reply-To: <9bffd12a-afae-45cd-a4f3-451872146bf3@moroto.mountain>
From: Felix Kimbu <felixkimbu1@gmail.com>
Date: Tue, 12 Mar 2024 15:16:08 +0100
Message-ID: <CAK=vLxJLOsqECJn+c=Mo0kY2878u1bhRzYEWo+yZZEUbqEee7g@mail.gmail.com>
Subject: Re: [PATCH] staging: p80211conv: Rename local foo to decrypt_check
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-staging@lists.linux.dev, 
	linux-kernel@vger.kernel.org, outreachy@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 12, 2024 at 10:03=E2=80=AFAM Dan Carpenter <dan.carpenter@linar=
o.org> wrote:
>
> With the rename the indenting did need to be updated, yes.  However it
> should have been:
>
>                 decrypt_check =3D wep_encrypt(wlandev, skb->data, p80211_=
wep->data,
>                                             skb->len,
>                                             wlandev->hostwep & HOSTWEP_DE=
FAULTKEY_MASK,
>                                             p80211_wep->iv, p80211_wep->i=
cv);
>
> [tab][tab][tab][tab][tab][space][space][space][space]skb->len,
>
> See my blog for how to resend a patch:
> https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
>
> regards,
> dan carpenter

Thank you for the feedback, Dan, let me correct that.