Received-SPF: pass (google.com: domain of linux-kernel+bounces-100340-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <89afddbe-f285-4830-b3c3-27150852d562@amd.com>
Date: Tue, 12 Mar 2024 15:19:34 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 3/3] spi: xilinx: Make num_chipselect 8-bit in the
 struct xspi_platform_data
Content-Language: en-US
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org
Cc: Mark Brown <broonie@kernel.org>
References: <20240308162920.46816-1-andriy.shevchenko@linux.intel.com>
 <20240308162920.46816-4-andriy.shevchenko@linux.intel.com>
From: Michal Simek <michal.simek@amd.com>
Autocrypt: addr=michal.simek@amd.com; keydata=
 xsFNBFFuvDEBEAC9Amu3nk79+J+4xBOuM5XmDmljuukOc6mKB5bBYOa4SrWJZTjeGRf52VMc
 howHe8Y9nSbG92obZMqsdt+d/hmRu3fgwRYiiU97YJjUkCN5paHXyBb+3IdrLNGt8I7C9RMy
 svSoH4WcApYNqvB3rcMtJIna+HUhx8xOk+XCfyKJDnrSuKgx0Svj446qgM5fe7RyFOlGX/wF
 Ae63Hs0RkFo3I/+hLLJP6kwPnOEo3lkvzm3FMMy0D9VxT9e6Y3afe1UTQuhkg8PbABxhowzj
 SEnl0ICoqpBqqROV/w1fOlPrm4WSNlZJunYV4gTEustZf8j9FWncn3QzRhnQOSuzTPFbsbH5
 WVxwDvgHLRTmBuMw1sqvCc7CofjsD1XM9bP3HOBwCxKaTyOxbPJh3D4AdD1u+cF/lj9Fj255
 Es9aATHPvoDQmOzyyRNTQzupN8UtZ+/tB4mhgxWzorpbdItaSXWgdDPDtssJIC+d5+hskys8
 B3jbv86lyM+4jh2URpnL1gqOPwnaf1zm/7sqoN3r64cml94q68jfY4lNTwjA/SnaS1DE9XXa
 XQlkhHgjSLyRjjsMsz+2A4otRLrBbumEUtSMlPfhTi8xUsj9ZfPIUz3fji8vmxZG/Da6jx/c
 a0UQdFFCL4Ay/EMSoGbQouzhC69OQLWNH3rMQbBvrRbiMJbEZwARAQABzSlNaWNoYWwgU2lt
 ZWsgKEFNRCkgPG1pY2hhbC5zaW1la0BhbWQuY29tPsLBlAQTAQgAPgIbAwULCQgHAgYVCgkI
 CwIEFgIDAQIeAQIXgBYhBGc1DJv1zO6bU2Q1ajd8fyH+PR+RBQJkK9VOBQkWf4AXAAoJEDd8
 fyH+PR+ROzEP/1IFM7J4Y58SKuvdWDddIvc7JXcal5DpUtMdpuV+ZiHSOgBQRqvwH4CVBK7p
 ktDCWQAoWCg0KhdGyBjfyVVpm+Gw4DkZovcvMGUlvY5p5w8XxTE5Xx+cj/iDnj83+gy+0Oyz
 VFU9pew9rnT5YjSRFNOmL2dsorxoT1DWuasDUyitGy9iBegj7vtyAsvEObbGiFcKYSjvurkm
 MaJ/AwuJehZouKVfWPY/i4UNsDVbQP6iwO8jgPy3pwjt4ztZrl3qs1gV1F4Zrak1k6qoDP5h
 19Q5XBVtq4VSS4uLKjofVxrw0J+sHHeTNa3Qgk9nXJEvH2s2JpX82an7U6ccJSdNLYbogQAS
 BW60bxq6hWEY/afbT+tepEsXepa0y04NjFccFsbECQ4DA3cdA34sFGupUy5h5la/eEf3/8Kd
 BYcDd+aoxWliMVmL3DudM0Fuj9Hqt7JJAaA0Kt3pwJYwzecl/noK7kFhWiKcJULXEbi3Yf/Y
 pwCf691kBfrbbP9uDmgm4ZbWIT5WUptt3ziYOWx9SSvaZP5MExlXF4z+/KfZAeJBpZ95Gwm+
 FD8WKYjJChMtTfd1VjC4oyFLDUMTvYq77ABkPeKB/WmiAoqMbGx+xQWxW113wZikDy+6WoCS
 MPXfgMPWpkIUnvTIpF+m1Nyerqf71fiA1W8l0oFmtCF5oTMkzsFNBFFuvDEBEACXqiX5h4IA
 03fJOwh+82aQWeHVAEDpjDzK5hSSJZDE55KP8br1FZrgrjvQ9Ma7thSu1mbr+ydeIqoO1/iM
 fZA+DDPpvo6kscjep11bNhVa0JpHhwnMfHNTSHDMq9OXL9ZZpku/+OXtapISzIH336p4ZUUB
 5asad8Ux70g4gmI92eLWBzFFdlyR4g1Vis511Nn481lsDO9LZhKyWelbif7FKKv4p3FRPSbB
 vEgh71V3NDCPlJJoiHiYaS8IN3uasV/S1+cxVbwz2WcUEZCpeHcY2qsQAEqp4GM7PF2G6gtz
 IOBUMk7fjku1mzlx4zP7uj87LGJTOAxQUJ1HHlx3Li+xu2oF9Vv101/fsCmptAAUMo7KiJgP
 Lu8TsP1migoOoSbGUMR0jQpUcKF2L2jaNVS6updvNjbRmFojK2y6A/Bc6WAKhtdv8/e0/Zby
 iVA7/EN5phZ1GugMJxOLHJ1eqw7DQ5CHcSQ5bOx0Yjmhg4PT6pbW3mB1w+ClAnxhAbyMsfBn
 XxvvcjWIPnBVlB2Z0YH/gizMDdM0Sa/HIz+q7JR7XkGL4MYeAM15m6O7hkCJcoFV7LMzkNKk
 OiCZ3E0JYDsMXvmh3S4EVWAG+buA+9beElCmXDcXPI4PinMPqpwmLNcEhPVMQfvAYRqQp2fg
 1vTEyK58Ms+0a9L1k5MvvbFg9QARAQABwsF8BBgBCAAmAhsMFiEEZzUMm/XM7ptTZDVqN3x/
 If49H5EFAmQr1YsFCRZ/gFoACgkQN3x/If49H5H6BQ//TqDpfCh7Fa5v227mDISwU1VgOPFK
 eo/+4fF/KNtAtU/VYmBrwT/N6clBxjJYY1i60ekFfAEsCb+vAr1W9geYYpuA+lgR3/BOkHlJ
 eHf4Ez3D71GnqROIXsObFSFfZWGEgBtHBZ694hKwFmIVCg+lqeMV9nPQKlvfx2n+/lDkspGi
 epDwFUdfJLHOYxFZMQsFtKJX4fBiY85/U4X2xSp02DxQZj/N2lc9OFrKmFJHXJi9vQCkJdIj
 S6nuJlvWj/MZKud5QhlfZQsixT9wCeOa6Vgcd4vCzZuptx8gY9FDgb27RQxh/b1ZHalO1h3z
 kXyouA6Kf54Tv6ab7M/fhNqznnmSvWvQ4EWeh8gddpzHKk8ixw9INBWkGXzqSPOztlJbFiQ3
 YPi6o9Pw/IxdQJ9UZ8eCjvIMpXb4q9cZpRLT/BkD4ttpNxma1CUVljkF4DuGydxbQNvJFBK8
 ywyA0qgv+Mu+4r/Z2iQzoOgE1SymrNSDyC7u0RzmSnyqaQnZ3uj7OzRkq0fMmMbbrIvQYDS/
 y7RkYPOpmElF2pwWI/SXKOgMUgigedGCl1QRUio7iifBmXHkRrTgNT0PWQmeGsWTmfRit2+i
 l2dpB2lxha72cQ6MTEmL65HaoeANhtfO1se2R9dej57g+urO9V2v/UglZG1wsyaP/vOrgs+3
 3i3l5DA=
In-Reply-To: <20240308162920.46816-4-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QmdONDluSWcwQTZ6OWp1N3ozSkFLanVLRG10R3oxZEQxL2Z1My9nOXFnMHh1?=
 =?utf-8?B?YTBncVdqV1ZNQjlCNlR3S1BROWpLdlJtSEt6eXVnNzFqMzY2Mk1BZjNEaDBu?=
 =?utf-8?B?dUFabWJCS3pSbHhFOUFJUUFMb3RkM3pkemNwK09Udk9PUGpZL1NhWDlZUnVl?=
 =?utf-8?B?dE5KRVlxMGpFUjJXdzVQVjIwU2N6OXRwc005eklIQW1HcElnTDJxS2F5L3Yx?=
 =?utf-8?B?WVlTWWJnSldKbStndXJWa0NsN0pjLzdZQUxYQWpBQXlYa05JcDlQMWZPRHls?=
 =?utf-8?B?SzlRWjRZbVRkYjBsQU51NWNNWDJoeXFLay84eHlVUkxpaUNtS1ZRN3ZmVjFk?=
 =?utf-8?B?OHE0WkxkWktWQVZXcHVJdGhycVV1SzdpdkNyeTZzdzJBdFBNMENQSGZ2T2tG?=
 =?utf-8?B?MWJhM3FoVjlBSFhPMUxBRzlRVjRHOEcweUFqVGNFb0dxU2Nhb0F2MXFUeHM2?=
 =?utf-8?B?MFluVXdFaXhRQUFSek9KU0JEZTd6NExPTFVGSVR1UnZhNnhQQVppbnY1NG1Q?=
 =?utf-8?B?MWNSUm42RkJBMDJmVUFLNFJuVTB5SXBnRXNWdnExc2dzWmQvZy9ndjhxTWpM?=
 =?utf-8?B?YVdBaHVvWE0rNHQxWmhiZGhheXdJQW1yZDdMOENiVURmZmNBQTBFSTM0RTQ4?=
 =?utf-8?B?SkxYVjhIUWZMWGloajFCczgwek9XRzZ3WDBYamNEWUFtMFdCSEcrUS9vRk5U?=
 =?utf-8?B?UW9RWTNOVk9GVXd4Z0JCTmZqeWFTQlcvTFRIODZrMTBXYU5NNVZMN0lrc2ht?=
 =?utf-8?B?UDFBdHdySEsyNDZOaExpWnVRaHVoMU91aTJIOXA1dkxKblFxRUZyQXJhRGFQ?=
 =?utf-8?B?SGZrQW85YzY5MjViOHdZbmVOZ0ZjVlNPZGJxUFdtdzllZkVRYURuWXl2WnNx?=
 =?utf-8?B?YmQ4L3ZkWEdabXhGb2RhV3k2RnloenlPUEhCSFFkcCtKNE9kaW5Ja1ptMzZ1?=
 =?utf-8?B?bXo5eFp1R2Q3WktLRkpHdTVKN0pJbEQ1RzdsOVp5R1JrYkcyb3RrcXpUem14?=
 =?utf-8?B?VmkrSWUvOFh4UUY4M1dpTXdUTkFaY2RDQnJ1dkxMbTRqTkZHSEQ0di92VGNl?=
 =?utf-8?B?bkRKeXlBWENtQ0ZzelI1NXpSbUFDU1lnSXZvZnE1d0pDT29FVmt6ZTFMNHBV?=
 =?utf-8?B?SHRQZW1qL2hWWGNLcDR4TEwzdENsN2tKekJ6cHBNOFNOWjlta3g4YkdEQlJy?=
 =?utf-8?B?ZWVWWUxHT0dqSGwrNGdjci9FdnlRZWpOVkNYaHNOZDlTT0tPRSs0cEZLWGhi?=
 =?utf-8?B?aFdNRmphcC84MCtVanB0Y2hOY0M0RHltRTRCNGpJQzlTV0NjRS9Ya20vak1V?=
 =?utf-8?B?dnBTR2JMV0RXbi8xeGh4QUsySkdOMzl5aHhhUmFlRDNCYTA4M3RneTJ1eTZM?=
 =?utf-8?B?c1NZMFdTU1pSV283ejV6ekdYUDU0SFMzSUZXeHpIVHdRUzE3K0lLRFBUME9M?=
 =?utf-8?B?QkhwT0haS3NTazgwcTRPS1phTktwYnlXLy8yTUFYZnVVU0MrUm9sVFFIOFlq?=
 =?utf-8?B?aUVjdlliNVgvOVlidzBPVFo3VDZ2cXlVSll2VGtJakllY0JNeUpISjdNTzlZ?=
 =?utf-8?B?Q3JtNXAyOVk0S2NtRDFweTEvWlJqVG1sN0xiZ3BCVEJaQUYzOC9zYzhqbUxt?=
 =?utf-8?B?d0RwN0pDd1ArZnF2VlViWjhOV3F6QWlTUW1nRDZkM2lGQWRNSjhiVEcxbUhL?=
 =?utf-8?B?RlpYbWV1YldPVGhSY1RuemxyZEdlRndnWEMxRFloWklYTDh5UU5xblI4TmI0?=
 =?utf-8?B?bFZHWHBQd3BiTCtRZEdqUWdvWm9zdTJtMldCdmlIY0c4Wk15a0U1K0FGUThr?=
 =?utf-8?B?N2RHTXhDNCtrWXgvYzVlQkQ4M3NnZTlwd3laOHBoaG1oZnhaZldjdm5hRXFE?=
 =?utf-8?B?UUdDWkl1VnFFSC9NNkRiSkRPVGROcldoY2JwK3RhN3AyNnZaZ2Qrb3Iza0JW?=
 =?utf-8?B?U3htT21NWjd0Wll2dkFvZzBBWVVTZWxCMkpDYkRWR2JjckNtNnlFYTQ4WEZl?=
 =?utf-8?B?Y1dIRTBJMWtWdms0emxOaklNZjlYbnpkZDgydmhBbmxteGcrSmZobnpaeGVR?=
 =?utf-8?B?R2twYzN3YVRrczc2cllnSDQ3dm9IM09Hc0MyTmFacDFqWHZvNlFKQVNRMllp?=
 =?utf-8?Q?u32G8c21cV8TkEzzwOVHSfWwk?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a3ffc001-c172-46cc-2966-08dc429f71d5
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8109.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2024 14:19:35.7566
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VZRhQuX0bcK5jrLeNwkTDr+Y6tYsJuPSGDE3ETVmCy5jCIrNa8ViBqNzYBsha8Bu
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7719


On 3/8/24 17:27, Andy Shevchenko wrote:
> There is no use for whole 16-bit for the number of chip select pins.
> Drop it to 8 bits and reshuffle the data structure layout to avoid
> unnecessary paddings.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>   include/linux/spi/xilinx_spi.h | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/linux/spi/xilinx_spi.h b/include/linux/spi/xilinx_spi.h
> index 4ba8f53ce570..1b8d984668b6 100644
> --- a/include/linux/spi/xilinx_spi.h
> +++ b/include/linux/spi/xilinx_spi.h
> @@ -8,17 +8,17 @@ struct spi_board_info;
>   
>   /**
>    * struct xspi_platform_data - Platform data of the Xilinx SPI driver
> - * @num_chipselect:	Number of chip select by the IP.
> - * @bits_per_word:	Number of bits per word.
>    * @devices:		Devices to add when the driver is probed.
>    * @num_devices:	Number of devices in the devices array.
> + * @num_chipselect:	Number of chip select by the IP.
> + * @bits_per_word:	Number of bits per word.
>    * @force_irq:		If set, forces QSPI transaction requirements.
>    */
>   struct xspi_platform_data {
> -	u16 num_chipselect;
> -	u8 bits_per_word;
>   	struct spi_board_info *devices;
>   	u8 num_devices;
> +	u8 num_chipselect;
> +	u8 bits_per_word;
>   	bool force_irq;
>   };
>   


Reviewed-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal