Received-SPF: pass (google.com: domain of linux-kernel+bounces-100385-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 12 Mar 2024 14:44:19 +0000
From: Mark Brown <broonie@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Saurabh Singh Sengar <ssengar@linux.microsoft.com>,
	Frank Rowand <frowand.list@gmail.com>, linux-kernel@vger.kernel.org,
	patches@lists.linux.dev, linux-um@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, kunit-dev@googlegroups.com,
	linux-kselftest@vger.kernel.org, devicetree@vger.kernel.org,
	"Gabriel L. Somlo" <gsomlo@gmail.com>
Subject: Re: [PATCH 2/7] of: Create of_root if no dtb provided by firmware
Message-ID: <e83b606a-e34e-423f-b26b-df745052d06b@sirena.org.uk>
References: <20240217060843.GA16460@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
 <CAL_Jsq+Feu9NnzTNx=XU5vgHhibGAQXvkuTeWbpu8gJ3rVrzcw@mail.gmail.com>
 <CAMuHMdUKa-KdWfYswEpFvj3RjQPM+ThhU85myfBGVkXxZqbHWw@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="A8PYQDEZ5U6Pm1op"
Content-Disposition: inline
In-Reply-To: <CAMuHMdUKa-KdWfYswEpFvj3RjQPM+ThhU85myfBGVkXxZqbHWw@mail.gmail.com>


--A8PYQDEZ5U6Pm1op
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 12, 2024 at 03:41:32PM +0100, Geert Uytterhoeven wrote:
> On Wed, Feb 21, 2024 at 3:06=E2=80=AFPM Rob Herring <robh+dt@kernel.org> =
wrote:

>     static int __init regulator_init_complete(void)
>     {
>             /*
>              * Since DT doesn't provide an idiomatic mechanism for
>              * enabling full constraints and since it's much more natural
>              * with DT to provide them just assume that a DT enabled
>              * system has full constraints.
>              */
>             if (of_have_populated_dt())
>                     has_full_constraints =3D true;
>=20
>             ...
>     }
>     late_initcall_sync(regulator_init_complete);

> (The latter looks a bit futile, as have_full_constraints() already
>  contains a check for of_have_populated_dt()?)

Yes, it's duplicated and we should remove it.

--A8PYQDEZ5U6Pm1op
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXwakIACgkQJNaLcl1U
h9A8ewf+MxFaGvrtn8DK977EqCU2BEx8094DvO7eMo0nyAJUm2gxwqKrhgdxDEFY
I0g6tj4LKJmyrLH4jH1T84U85aVm9il1PX4OUNyIHtHqrTvZuxonx1hbMfHWnq4d
varya5+YeCMfo3B8heD4RSSmX4ewG6Jgb+IeDl/Jn8On2Pys75Sh1Bk8mbbunG+H
pOK8gTFj5jOaR6JoX/gsoYsifocZ0s96AqUqmk+i7zxdX6qJhGDaD7azW/qhJAUv
+E/x/KzOuerVx8mX2drUIR9jk/s1+t3mgTJZKAYoGUDW2PwG9wPb8tqtofX2ghXU
ZgSshLDLKjTalXEyonUkGEadKnNxmA==
=/ZcU
-----END PGP SIGNATURE-----

--A8PYQDEZ5U6Pm1op--