Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp1117640lql; Tue, 12 Mar 2024 07:47:46 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVIICtPNHvl/7Y62ytwWakdrJEPWCsHPJ2Z5Ww8Iud+gEAGBLGwprieqAz1O7RvOWsX+BTSpDmfBSFkjUW1NfNB0IZ6Y/7qQkp5zTVl/g== X-Google-Smtp-Source: AGHT+IG048jEtOYVT5fnhemoJyGFOAfaoMn+5BdsCg4+436SKiLPWBGxxVRguGPteM8d3pz2D/7w X-Received: by 2002:a05:622a:1c2:b0:42f:3083:718d with SMTP id t2-20020a05622a01c200b0042f3083718dmr4292550qtw.34.1710254865609; Tue, 12 Mar 2024 07:47:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710254865; cv=pass; d=google.com; s=arc-20160816; b=bNUVCVEruRnYEt67XDxwUgThBbWu5tko6pBzd9TD4N4EPxlLCB9Yk5H10vy2hPq07s /mJtiHnqppT5HPHftZFvgSJ0A6O9VSEcq/0E6iWt+iLFoKSLeYj/LammKO/WjingehHv ihC7r6sKSLMrOMm/2BG0h6u5xwcm2X8MU+Rdy+nwzQaDsMop+/OkncDWWlwC5fEu6liK tFV+/p+elSL7oNUsmrFaG53fpoySL+gVTRNNH4Z/+NNt8/tVd+9llaypjZB/9+YdaQ4R /yxZt8yfTbMTRcsypFYuwsd+WfjPaI5SGv/gEYXsMrr8o1b1pT1V7YDb/p2nbmccA4Kv zetQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=WvqrNBs/dsANsTIam6QxqZAEnFp69mAAp5IdSpFvv0E=; fh=m/voArD2BLLskeiiRV/5PPulxopFbXaCRkeWC5OUZFo=; b=ru2di24d9vCEy/Ufouh9ibg2Izvgg1fWYGvVPAzMxeaETXNM1MugI7pt4iw87GhM16 kIX1fE/y+MjV2BsNa0ePloEoKbWPvjch4E7neMBXl5LGCkmbCF6DpsIIIQYr7Ot76stq 2/RoRxTZrN1nrdTJc2ac5PjhvXHYFYdRmJ758axxaF5r2w+WPMfarMPpOal2QwQsO73C nvTVGTE641pbBRKsqw6/2hAQ5DrqKp5cswuAuQKpdP9JL/IEtuewmqllwMczBunVpMT9 5rguzY0zfeGrkenzjsFsibc8y8l/7+mei41A6N65HjJLdZv7oRa8myJCvHywkXjVeeF0 AETw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Nq8EZpQK; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-100389-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100389-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id p12-20020a05622a13cc00b0042eeae1c18bsi7736021qtk.144.2024.03.12.07.47.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 07:47:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-100389-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Nq8EZpQK; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-100389-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100389-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 2DC6D1C21906 for ; Tue, 12 Mar 2024 14:47:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 02A447B3D7; Tue, 12 Mar 2024 14:47:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Nq8EZpQK" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2014F1DFD8; Tue, 12 Mar 2024 14:47:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710254858; cv=none; b=BV25fmNl/V89MdEb9bsncf6bBxsvD0SE8NZlPZRpoII6iD7rSyrqbCNSung16JDb+N5d/4ccIpjYAHqQjQtG+MuP65kelgIR9uAbVjQC7iXUjTyzHv1InyjYJn/qWOnvQE2s3FNUCULqvD83mzbujoQ1dK1RWLeK1Z/bbwZCnXc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710254858; c=relaxed/simple; bh=WvqrNBs/dsANsTIam6QxqZAEnFp69mAAp5IdSpFvv0E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KaRjs6OyFTwPD1MRI9/hlIe7J+FjPHY6u7Rk0Q898F7FaoyamQfnxgd+zKgNDZi2N9+QQ3+/uYorPKwF8uJbfjcpGObhoMMSePyDSoYvSj1b+k0K1x23X/I5o0seLifr+dqYRiJLK8oJgR2CLzg+OnDgFea4ezZQjGGq7Fd1vMs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Nq8EZpQK; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B277C433F1; Tue, 12 Mar 2024 14:47:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710254857; bh=WvqrNBs/dsANsTIam6QxqZAEnFp69mAAp5IdSpFvv0E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Nq8EZpQKE4/pDtnBVHiu4xlQCU3rbOhVUm4uUXvXZkp72+qmwDkN2Rs/xbli93EsY M4S/nrQ5G9YJdWctw6DU0tFPrYh3C35aTwXmJ0CoUEBBb+Ha2XZ7EEmDIK39l/WlT8 f1oLUfuFaREMLwZdR1MKqPy+/YSY+ECvtuzpn1gCL3bHfMBhKh3LwfYs6hyuXKp0vs aiGDtYP2krSSpWmO/H1+UrUI0RernUS/wBkG23AiOiUWV9G9Gc8DTgdYYrSsdzRTd4 Ni+xHExOA71bHAnKl/Gzvj8nxfJ8rh7KRQagbFBZNxrH2jYlb5WXbO4byQEzCtO63o hy3AYhT1QaP3w== Date: Tue, 12 Mar 2024 14:47:33 +0000 From: Mark Brown To: Kees Cook Cc: Andy Shevchenko , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v3 1/2] string: Convert selftest to KUnit Message-ID: References: <20240301202524.make.800-kees@kernel.org> <20240301202732.2688342-1-keescook@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lWQNWGwaL10PQ4jC" Content-Disposition: inline In-Reply-To: <20240301202732.2688342-1-keescook@chromium.org> X-Cookie: Oh, so there you are! --lWQNWGwaL10PQ4jC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 01, 2024 at 12:27:30PM -0800, Kees Cook wrote: > Convert test_string.c to KUnit so it can be easily run with everything > else. >=20 > Additional text context is retained for failure reporting. For example, > when forcing a bad match, we can see the loop counters reported for the > memset() tests: Reviewed-by: Mark Brown --lWQNWGwaL10PQ4jC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXwawQACgkQJNaLcl1U h9Cljgf/Y4b0Xk1s21KrI6Vdrp5pctZ3Zcpq+u725G5xY+C9ItB3OI2i8k1PxJW1 r+qKuptg01FTkeqlIdzOHImeYmN80iKmZ1xxJC3Fo2EjuHbxWDe58ivfHTfTzJu5 V3aqPLjKoxjaTJ/NccyJH1LqQqIEtGfYfdpIGnLDWfLMOIaY4vNqGYjQgMd9grwq S+f7S9Xz9w+ws4jrYKkrf2LwYBbTjbiOh1VF73GKq93dpLU4kOuT7Atqk+Yu9EDL 9z3i8o8uZ86prK5ceCP9PZBRy/4IfvjVFcTOd+EmKeurQ79dug5ysYBHFTX2SW0q uCay40/O+aASTANo7rOZ2uj/YnA8LA== =A0CZ -----END PGP SIGNATURE----- --lWQNWGwaL10PQ4jC--