Received-SPF: pass (google.com: domain of linux-kernel+bounces-100392-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 12 Mar 2024 14:49:23 +0000
From: Mark Brown <broonie@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: Andy Shevchenko <andy@kernel.org>, linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH v3 2/2] string: Convert helpers selftest to KUnit
Message-ID: <102f201b-2ad3-4b41-b1bc-5280437aa820@sirena.org.uk>
References: <20240301202524.make.800-kees@kernel.org>
 <20240301202732.2688342-2-keescook@chromium.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="XZgOaFjFlqex7GrJ"
Content-Disposition: inline
In-Reply-To: <20240301202732.2688342-2-keescook@chromium.org>


--XZgOaFjFlqex7GrJ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 01, 2024 at 12:27:31PM -0800, Kees Cook wrote:
> Convert test-string_helpers.c to KUnit so it can be easily run with
> everything else.
>=20
> Failure reporting doesn't need to be open-coded in most places, for
> example, forcing a failure in the expected output for upper/lower
> testing looks like this:

Reviewed-by: Mark Brown <broonie@kernel.org>

--XZgOaFjFlqex7GrJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXwa3IACgkQJNaLcl1U
h9CINQf9FZyCr1mwwp0I0ZAvYxN46NqkeDDqh+wPU6w/4KHNRiUlyQfkNRkAA+Xp
J+5TZcZE7OILqEngLybT0YW7vgEfBTGn6NmKimShCJPz1eQkHlpTYJj97IdgSd1x
y1US39o1HeQ2FjJhdDYpPB+oP7x6D/kNirLmwDO3apllBdGOKJdUrRt4op3xX0kE
Ati+hous5ZkNRKCbdk06Esgza2V8KunLQS66F1pamYICOFtvbLce8PwpGa7p4osr
OX1P7ilURCNOTf6f0++n2UI77pwN9cW8a2j9CRneXNcRz3+M7KE09B+XOc6Cee9D
rAns/5JTYWJzFu0SPe/1g2dxpTVBrg==
=pn9z
-----END PGP SIGNATURE-----

--XZgOaFjFlqex7GrJ--