Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp1119228lql; Tue, 12 Mar 2024 07:50:34 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXeeiVc0L7/DxVSwZPFguYCr7ujKx+qNhKoq2hrKVV1fI/YnMLNulfml0CQLTNkHZTgyXw3UX3uldYd7QxruyJT+HZIZ+Ia1KPNHUjEKg== X-Google-Smtp-Source: AGHT+IEAZistyiNsh4BkGsXgFoDXdgKchYqkt8K7yJ9nFDa86Nhws44ga10e2mCPMh4b9nH93gnm X-Received: by 2002:a05:6808:438f:b0:3c2:2a80:17f4 with SMTP id dz15-20020a056808438f00b003c22a8017f4mr3274810oib.47.1710255034618; Tue, 12 Mar 2024 07:50:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710255034; cv=pass; d=google.com; s=arc-20160816; b=Ve7ORjRffnarXKnQ9eGKkKk3Hg+6wS0qt7EsKuci1rT8KZNTOC1EJTLt5ZhXcG/CIl j/aZ5NEyslcx47JZ6IUDXt4pI3exXj3Ih21dkbqIgBtD3hAIU3sBDXY+kyqkEma+3SrP 0JtuC0+sI2Z6O50Q6d1Zmr5qF2apMEotGEkMEsPaQfYvHHl3RIUAZi92lPA4Ip4FyviA AOHEdbLGP9jPrAqaHfHt/S9418ud24VfcQ5zpRiSUYoP2EJvsb9scs/qKgt7m41seH1J Hooz7x2GT6UJv6BqmfGtX2bXOMfs6g+dLtP15E6P+Pq63Is5Elt3+3KGz2LYDaHdkr6B L90Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=cdxOToZtr3MgG8M5yCGfJbtM/oXC1jGaY0CYXkO7JjE=; fh=Y2NGAE1jnhKZ7/AMJKb5B/m5QESm+xUM46nft1vnPu4=; b=khHjgfmUFPozonHUeu6gs/uXH+P3habFUIlAcPaoiB7nLobdRaads2yP6UFio9j/eB OSq4CT4Ha1xEL8bwXvOyGoKajT3F86YbRjRrwfFAbuaXbk7JqxpOPUN4iWGxihfqU67k Tvj2zqAdCHC7KchftNmerAJEMN2cYP6FeEV3898v6hJrpAKDIcyH66wNpsdn3QLvUq2X hgDr+Nfg3sKmGHd+7rjuh5BteCmiCzB397mS8bWXlzaNN+U+3xeQqJgxQs74cRRHhOOK CoQWIeWGVFNICXkMEvCYcnXvp3A7b1fqZDADeRJtTVuuo7N7gdX6fMLLfssrwuIULqsS KZaA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=jeYtFwEV; arc=pass (i=1 spf=pass spfdomain=baylibre.com dkim=pass dkdomain=baylibre-com.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-100393-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100393-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id l20-20020a05620a28d400b0078875079cfbsi3290187qkp.739.2024.03.12.07.50.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 07:50:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-100393-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=jeYtFwEV; arc=pass (i=1 spf=pass spfdomain=baylibre.com dkim=pass dkdomain=baylibre-com.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-100393-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100393-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 542C81C20915 for ; Tue, 12 Mar 2024 14:50:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 58D137BAEC; Tue, 12 Mar 2024 14:50:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="jeYtFwEV" Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 698A756750 for ; Tue, 12 Mar 2024 14:50:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710255023; cv=none; b=CnEELIl/8liofU6HKW0xnNBFNU3qIBnawjInX2KcZQLNuso6GCCgfzeJEHMyNX+5R4YIyTDCmnAj2yqH1av0UbyqVr3Yx5FE+LyxDh4ORVM7ZY2nIsROa7itPCx66ximgAMuSbLUg7Z3+khnrBLfMAztLTcbClyqKsVu2cZR/6o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710255023; c=relaxed/simple; bh=HRKqHTo2coRukof51yfticbZ5DFq9gs/6ILyHCTY6is=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JD1fg7ynHGUEajOWgrQjvhW50f0HCHKDmejEZAvYvZnC80SisuEv0U2MPoLEuEIFCOaFg4fETeMJ5kAix6gaytnwi9eqqrZwJ59LSq2V3CtEFf+xKCHClaVhM/4nQ9VcV7owWqn7u796TOmvr/lOmVUB1f+GKpcDkfrE2q7LKhc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=jeYtFwEV; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5135486cfccso5385990e87.0 for ; Tue, 12 Mar 2024 07:50:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1710255020; x=1710859820; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cdxOToZtr3MgG8M5yCGfJbtM/oXC1jGaY0CYXkO7JjE=; b=jeYtFwEVtAOM2nWoEXkkyKq/6O3SPEL1U5DfyvJEJhsSYNHy1fhgGoGUVXndADKtDM TiyUyJx9H8s7ZxcyGIfjxuo+F1CFn8Ig1tU21ogfubtuvbUtiOVCz3VUO0h/xxk4ShyM EdSZisVPU3BE47YiIzff0Xae4W6zWZFdbjVE66zruczCP3zIp92M2cjEdUfnwchCU2hF WvdLIh5n+/SvCFFilqTcz9MQbge/jKf3/8dBcQnTA54R73/NhBs3gxz0CPSwF1ktc1jF 02VX8pXripZGXmlGFeL2WeIAuX6sgpG74h3vnnb5+fZrtsz6KiiEyoOumXW5j+sh6P6X SL7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710255020; x=1710859820; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cdxOToZtr3MgG8M5yCGfJbtM/oXC1jGaY0CYXkO7JjE=; b=OX+iZ5+xELqMdViEzitMBig/Pi16gU0WyHXrUXNam3fA6ySgR2iEVsaz+W64Rqe6Up abrJxJBHocPrbcqKjVZaN+wLsuv+8InzouLh8TlqpT25eGYQqxXxzyqGfjONJArVrcML rtoCPCcIHZ8yZTHWgwXLeiVLcB56t1gn5PfIrRQQeDgOqB5FKdc8HNA+kzZ1nQPyzlQ0 9F5elTWvdgIf/dbY+YSMKxq+o+n3ipIOrL5RXVPcN1vzBnr7fzLXPzQ30LZejH3Pu8qa hnOJpRpLiaZxAVcTp6F61T93S6dCMGdxq2n2lQXagB6KemG5J6WaGtfJzHBGbjjasS/+ 62Xw== X-Forwarded-Encrypted: i=1; AJvYcCWkuhBjeyw4uDbPZcAVb2Re5f9g+QxHv0Br/jEUtxv7FwCLYeWJHJcS/jk60xYwFBjNtGScFOgI4E6JjdZ3lSWSe7bZsGNIgHCl4a0g X-Gm-Message-State: AOJu0YxBHZI88JwHsMKmCHhyoaqBKWjWs5/znBlp9KqphhjVuQUipANr MBdCMjHEr0CjdS8Xx5j8OdSxAfI3wWyJlyc7gy5TftH/r2MGsPjkR6eyzq0RLag= X-Received: by 2002:ac2:51a5:0:b0:512:bf99:7d80 with SMTP id f5-20020ac251a5000000b00512bf997d80mr6373397lfk.1.1710255019673; Tue, 12 Mar 2024 07:50:19 -0700 (PDT) Received: from [192.168.1.172] ([93.5.22.158]) by smtp.gmail.com with ESMTPSA id u18-20020a05600c19d200b0041316e91c99sm12715808wmq.1.2024.03.12.07.50.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Mar 2024 07:50:19 -0700 (PDT) Message-ID: <253b4b6c-d8ba-40a3-adbb-4455af57d780@baylibre.com> Date: Tue, 12 Mar 2024 15:50:17 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec Content-Language: en-US To: AngeloGioacchino Del Regno Cc: Flora Fu , Liam Girdwood , Lee Jones , Rob Herring , Mark Brown , Matthias Brugger , Conor Dooley , Krzysztof Kozlowski , Catalin Marinas , =?UTF-8?Q?Christian_K=C3=B6nig?= , Sumit Semwal , Takashi Iwai , Jaroslav Kysela , Will Deacon , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, Nicolas Belin References: <20240226-audio-i350-v1-0-4fa1cea1667f@baylibre.com> <20240226-audio-i350-v1-12-4fa1cea1667f@baylibre.com> <1641a853-88cb-43a8-bb95-653f5329a682@collabora.com> From: Alexandre Mergnat In-Reply-To: <1641a853-88cb-43a8-bb95-653f5329a682@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 26/02/2024 16:25, AngeloGioacchino Del Regno wrote: >> +    if (enable) { >> +        /* set gpio mosi mode */ >> +        regmap_write(priv->regmap, MT6357_GPIO_MODE2_CLR, >> GPIO_MODE2_CLEAR_ALL); >> +        regmap_write(priv->regmap, MT6357_GPIO_MODE2_SET, >> GPIO8_MODE_SET_AUD_CLK_MOSI | >> +                                  GPIO9_MODE_SET_AUD_DAT_MOSI0 | >> +                                  GPIO10_MODE_SET_AUD_DAT_MOSI1 | >> +                                  GPIO11_MODE_SET_AUD_SYNC_MOSI); > > Are you sure that you need to write to MODE2_SET *and* to MODE2?! This is downstream code and these registers aren't in my documentation. I've removed the MODE2_SET write and test the audio: it's still working. So I will keep the spurious write removed for v2. :) -- Regards, Alexandre