Received-SPF: pass (google.com: domain of linux-kernel+bounces-100395-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 12 Mar 2024 08:51:30 -0600
From: Rob Herring <robh@kernel.org>
To: Xu Yang <xu.yang_2@nxp.com>
Cc: linux-kernel@vger.kernel.org, festevam@gmail.com, conor+dt@kernel.org,
	gregkh@linuxfoundation.org, s.hauer@pengutronix.de,
	peter.chen@kernel.org, linux-usb@vger.kernel.org,
	kernel@pengutronix.de, shawnguo@kernel.org, linux-imx@nxp.com,
	devicetree@vger.kernel.org, jun.li@nxp.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org,
	linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev
Subject: Re: [PATCH v8 04/10] dt-bindings: usb: chipidea,usb2-imx: move imx
 parts to dedicated schema
Message-ID: <171025508777.2218558.15957052770925895416.robh@kernel.org>
References: <20240312091703.1220649-1-xu.yang_2@nxp.com>
 <20240312091703.1220649-4-xu.yang_2@nxp.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240312091703.1220649-4-xu.yang_2@nxp.com>


On Tue, 12 Mar 2024 17:16:57 +0800, Xu Yang wrote:
> As more and more NXP i.MX chips come out, it becomes harder to maintain
> ci-hdrc-usb2.yaml if more stuffs like property restrictions are added to
> this file. This will separate i.MX parts out of ci-hdrc-usb2.yaml and add
> a new schema for NXP ChipIdea USB2 Controller, also add a common schema.
> 
> 1. Copy common ci-hdrc-usb2.yaml properties to a new shared
>    chipidea,usb2-common.yaml schema.
> 2. Move fsl,* compatible devices and imx spefific properties
>    to dedicated binding file chipidea,usb2-imx.yaml.
> 
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> 
> ---
> Changes in v6:
>  - new patch
> Changes in v7:
>  - not remove ci-hdrc-usb2.yaml and move imx parts to ci-hdrc-usb2-imx.yaml
> Changes in v8:
>  - rename yaml name to chipidea,usb2-common.yaml and chipidea,usb2-imx.yaml
>  - remove common properties from ci-hdrc-usb2.yaml
>  - add new end line to chipidea,usb2-common.yaml
>  - remove fsl,anatop since it's not needed by controller
>  - fix pinctrl-names formats
> ---
>  .../bindings/usb/chipidea,usb2-common.yaml    | 200 ++++++++++
>  .../bindings/usb/chipidea,usb2-imx.yaml       | 193 ++++++++++
>  .../devicetree/bindings/usb/ci-hdrc-usb2.yaml | 360 +-----------------
>  3 files changed, 396 insertions(+), 357 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/usb/chipidea,usb2-common.yaml
>  create mode 100644 Documentation/devicetree/bindings/usb/chipidea,usb2-imx.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>