Received-SPF: pass (google.com: domain of linux-kernel+bounces-100417-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <d594a7e0-e33e-4311-8079-14dd56f6d309@intel.com>
Date: Tue, 12 Mar 2024 08:13:40 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 00/17] x86/resctrl : Support AMD Assignable Bandwidth
 Monitoring Counters (ABMC)
To: <babu.moger@amd.com>, James Morse <james.morse@arm.com>, <corbet@lwn.net>,
	<fenghua.yu@intel.com>, <tglx@linutronix.de>, <mingo@redhat.com>,
	<bp@alien8.de>, <dave.hansen@linux.intel.com>
CC: <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
	<rdunlap@infradead.org>, <tj@kernel.org>, <peterz@infradead.org>,
	<yanjiewtw@gmail.com>, <kim.phillips@amd.com>, <lukas.bulwahn@gmail.com>,
	<seanjc@google.com>, <jmattson@google.com>, <leitao@debian.org>,
	<jpoimboe@kernel.org>, <rick.p.edgecombe@intel.com>,
	<kirill.shutemov@linux.intel.com>, <jithu.joseph@intel.com>,
	<kai.huang@intel.com>, <kan.liang@linux.intel.com>,
	<daniel.sneddon@linux.intel.com>, <pbonzini@redhat.com>,
	<sandipan.das@amd.com>, <ilpo.jarvinen@linux.intel.com>,
	<peternewman@google.com>, <maciej.wieczor-retman@intel.com>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<eranian@google.com>
References: <20231201005720.235639-1-babu.moger@amd.com>
 <cover.1705688538.git.babu.moger@amd.com>
 <2f373abf-f0c0-4f5d-9e22-1039a40a57f0@arm.com>
 <474ebe02-2d24-4ce3-b26a-46c520efd453@amd.com>
 <b6bb6a59-67c2-47bc-b8d3-04cf8fd21219@intel.com>
 <3fe3f235-d8a6-453b-b69d-6b7f81c07ae1@amd.com>
 <9b94b97e-4a8c-415e-af7a-d3f832592cf9@intel.com>
 <1ae73c9a-cec4-4496-86c6-3ffcef7940d6@amd.com>
 <32a588e2-7b09-4257-b838-4268583a724d@intel.com>
 <088878bd-7533-492d-838c-6b39a93aad4d@amd.com>
 <9b20589b-6220-4ae7-bfc4-4a826b7114b1@intel.com>
 <4b3418ed-751d-4e37-8d72-f2b4891eb714@amd.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <4b3418ed-751d-4e37-8d72-f2b4891eb714@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnR2elhTSEpLN2FrV25HZjhiUy9kZHdtbHBKQ1g2TU5JOHQ4RTIwbjNkVVpz?=
 =?utf-8?B?Qk5YRUtBSG1EU1lCRjNzdmoyUGc3b3VONUgyaW5EMHp3MlhDYUlVZ0dkQTM2?=
 =?utf-8?B?VFZXV21zRTc5VnRqRlZKcFFHWDFSUElaY1N3TU5PMEVYL2RQdm11ODVwWFUz?=
 =?utf-8?B?c0xmVVJzcjRQZG0vRzFpTldBZnRDUWpqTUIrckZPc1lkTldpVnpVQ1AxK1p6?=
 =?utf-8?B?Rng2YWN4RGpGekZvWnZGd01nOS94K1YxMTBUd2xzTDRsd24wODBmWVdlVndn?=
 =?utf-8?B?c3R1SmFMUEZNK3U2SXRQTkJYU1IwaXJ5WlBISktuZSthV3VlTVU3MnZnclYx?=
 =?utf-8?B?NGkxVFhoVCtMaDBFczMyWlJCVUdVUUVQd2RsczNkQ1VBQXZlcURyZDVyYk56?=
 =?utf-8?B?V1V4UUNkUjk2SExlWmZubzRrbDdOWDJBTnZIVFJtRnVVb2dRbVJkTGU4OEE5?=
 =?utf-8?B?TTR2YXpuUkpnMFpuNVhxSmVNNEpmVERoMUo3elFuVDNhVjBWb2xiN1ZUZEdI?=
 =?utf-8?B?K0VtQ01wVmREYllnQms5TjB3Vy9XRndQVWdXQWptbnQvVHdVMUg3M3ArUVgr?=
 =?utf-8?B?L2JOVWdJWnBvbGp4VExGWkRYZFdRaGJhZzlBSXhVd2FSVGFtcnRtcVVJMmdi?=
 =?utf-8?B?VTJqMC9WQlI0NndFeE5EUGFnNHl0clFTL29lZ0p4aDY5UTFJMDROWXdaUlo4?=
 =?utf-8?B?VVA1VnlieTA3SHB5aVhqcHE5Yms3OXJYbHVNd0VYMC9PY0FhdCtVQzJST3Rq?=
 =?utf-8?B?dWFBdFdTc2N1aFF3RzlNdjF5MDFxdTlqRkhoV25aY3NrTmQwSU1HVWJpVHRp?=
 =?utf-8?B?SlZiV3o3NkRjelJFLytPb1RkR3V1Qmh0eWxTalRaNS9rbDZKS3dsODlNeVFP?=
 =?utf-8?B?aEZ2QjZUbldBVk1mWUp0QzZKN3lmbUZYQk5KWE9HZ3lNTU1YY20zWUZFVnh6?=
 =?utf-8?B?Y01WdmlBRFhFYUExUmI3WGFTMDJlWUE4RERlSnJnenJIOTN5bHN1cC9IZys4?=
 =?utf-8?B?S1UrRDRYazNkb1hhNXA0M29FSzN6RVlVelVrdVNuTWVuNXVaOEhBM0FueE1o?=
 =?utf-8?B?NEUvbHBFYnRVa0wvWGVPM3JIaXBJTTNsa0tZOFVpSFJWYWZ1b3NxUzB3Ym1q?=
 =?utf-8?B?eERWdFkzM09ZanlsRWdpcTFINUdEa081N2xXL256clRMZXFmYURveTJTWkVz?=
 =?utf-8?B?c1JJYmZGTlRqUHAzYWNCYW9XMFZLZ05nQjFUZWZuTlBOLzIrR2I5Uy9wdEdE?=
 =?utf-8?B?OE1ISHN1VzRRcHpEenEzMjh1WVpwbjM2Rk91clExblpTeGhFSnIzaThqT1lW?=
 =?utf-8?B?SmpFV1AyUU1COTI2T3dydDJOZ1c4Y0FQd055dmN0MHdEdVhCeVJxSmhNK0dv?=
 =?utf-8?B?QUUyZzllQWIwbWJ3MElPc2tnQWZQWlJidlR3bUZRb2xCNjY3cEJodEV6akxy?=
 =?utf-8?B?TTN3b3l6V1RZd3U0dEc2U2xGejAvNEZoc0lZNnVaVklGSUpZWGlrMDQxSERk?=
 =?utf-8?B?UnZhUW95K3VJK0poK3BOTXd4OVYwOWtJUHhHaVNqcU4raHRjL1BlVm9SYmpk?=
 =?utf-8?B?REI3MjkySCtOZHgyc05Tb21aTlhlZVgvREg4alVwa2lDSWR6UlgwMWIvdjF5?=
 =?utf-8?B?M0prdDhSTzVobktUYjZKUGx4VUtFcEdGL1Y4SEdLNUQxWWlqM3lGTll1TmxH?=
 =?utf-8?B?NGl5RDNUdWprTEFtYXYyZ2NBaWJEZmFtblJsTDZOWGhGUHR4NFhqUTVZNllE?=
 =?utf-8?B?UUI0ZGJlczIwVy9DUHJtQVVUVjF3L1I2QmNibExyY2phM1VCcmJEVWlQM1l2?=
 =?utf-8?B?aDR0YTV4ODdOcEp2Q3dMR1J1M2tFK29WSXhhZ01jcnBPdEtYUVBRMndaNlRQ?=
 =?utf-8?B?bjlQVEpiVlh1dC81NnBWTUtmT2c2SlJ1Z0hENU9XQ1BpNHU0d0lGNUNOR3FQ?=
 =?utf-8?B?Z0dOVkhyZWRuWXNtKy9ZU3YzSFlReWdKTEhMYm9aNlNRZERCajlQNldiZFJz?=
 =?utf-8?B?dWROazA3SERoa0t3dWZjaklpN3M3c0JrWHNyLzJFTklHUU8xUlFlblp4QllI?=
 =?utf-8?B?Y1hhc0puNE1FSWw2OHNQaitDZmR6U1N5cVJTd2JYc21RZFMzcEhoWTZ4WUFx?=
 =?utf-8?B?S284cmYrWkkzNmJvaVl1dXJhNUZySnJ3cFZIbjd4NmJiTmNybVA4MlZOalpE?=
 =?utf-8?B?UWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 61464892-99b8-4a36-747f-08dc42a70211
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2024 15:13:44.3433
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: URLCa5LF+avQg5BwLSFyUgjhO90lbDbI3qjofiF2Py23jJ/JcyLQKPQnV2AWBQ2FmBBSpHO4ztoYisT5791YyxNWh1aD3lq/52xyko4jzw0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7618
X-OriginatorOrg: intel.com

Hi Babu,

On 3/11/2024 8:40 AM, Moger, Babu wrote:
> On 2/27/24 17:50, Reinette Chatre wrote:
>> On 2/27/2024 10:12 AM, Moger, Babu wrote:
>>> On 2/26/24 15:20, Reinette Chatre wrote:
>>>> On 2/26/2024 9:59 AM, Moger, Babu wrote:
>>>>> On 2/23/24 16:21, Reinette Chatre wrote:
>>
>>>>>> Apart from the "default behavior" there are two options to consider ...
>>>>>> (a) the "original" behavior(? I do not know what to call it) - this would be
>>>>>>     where user space wants(?) to have the current non-ABMC behavior on an ABMC
>>>>>>     system, where the previous "num_rmids" monitor groups can be created but
>>>>>>     the counters are reset unpredictably ... should this still be supported
>>>>>>     on ABMC systems though?
>>>>>
>>>>> I would say yes. For some reason user(hardware or software issues) is not
>>>>> able to use ABMC mode, they have an option to go back to legacy mode.
>>>>
>>>> I see. Should this perhaps be protected behind the resctrl "debug" mount option?
>>>
>>> The debug option gives wrong impression. It is better to keep the option
>>> open to enable the feature in normal mode.
>>
>> You mentioned that it would only be needed when there are hardware or
>> software issues ... so debug does sound appropriate. Could you please give
>> an example of how debug option gives wrong impression? Why would you want
>> users to keep using "legacy" mode on an ABMC system?
> 
> We may not be able to use "-o debug" option to enable "legacy_mbm".
> With debug option it will always go to legcay mbm even if ABMC is supported.
> 
> For example when ABMC is supported, I cannot mount the resctrl with debug
> option to test ABMC.
> 
> I need to have a way to mount resctrl with ABMC and debug option. I can
> add "-o legacy_mbm" to enable lecacy_mbm.

I do not think it is necessary to add a unique debug option for this.
What if instead the "-o debug" mount option exposes the "original/legacy"
behavior in the control file? This would enable users to only use this
behavior when in "debug" mode while still able to switch between
legacy and assigned counters.

Reinette