Received-SPF: pass (google.com: domain of linux-kernel+bounces-100442-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <e69948c4-756b-4bc6-b543-eeb0028da83f@amd.com>
Date: Tue, 12 Mar 2024 10:33:06 -0500
User-Agent: Mozilla Thunderbird Beta
Subject: Re: [PATCH v12 2/4] dt-bindings: remoteproc: add Tightly Coupled
 Memory (TCM) bindings
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 andersson@kernel.org, mathieu.poirier@linaro.org, robh+dt@kernel.org,
 krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
 michal.simek@amd.com, ben.levinsky@amd.com
Cc: linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
 Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
References: <20240301181638.814215-1-tanmay.shah@amd.com>
 <20240301181638.814215-3-tanmay.shah@amd.com>
 <fb78bdda-2ec7-4fcc-888e-233905a9386c@linaro.org>
 <17d58a39-7d56-4513-8d5f-7c18809c6cfb@amd.com>
 <cc06e895-e0f5-40da-8c29-0e4bf62bcacf@linaro.org>
Content-Language: en-US
From: Tanmay Shah <tanmay.shah@amd.com>
In-Reply-To: <cc06e895-e0f5-40da-8c29-0e4bf62bcacf@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eUFrYXk3d0pwQkxRaXhUTk9jOUN2NU1Ea3pwM2tDN3hEUndsN3NRaDdFSExW?=
 =?utf-8?B?a24wQjFYYUptMlU2VEkyMm5Ca25ZUmZud1p4eXVWY2R5MW1oQm9HbGFGSWZL?=
 =?utf-8?B?YUp6SGxzaFBBT2psckVZRXFmQzhFTXQ2WktBODhyYVA3SEQ3Y0JGZmpqbGdm?=
 =?utf-8?B?YjdDdTc2WWZpTHkway9USTBWdDczR3FtdXBkT0dkQVpTY1BBTDZ4SHJOdkdt?=
 =?utf-8?B?NnFoK0t1Z080WVZvdFZvRnArTnJ6MTh5OE0zcEdCT3VSanZTMmY3cmVDWGhN?=
 =?utf-8?B?TWMyWklIZU8rQUFXd3hFVm9xSlJ4VCtLTUpaNFprMkdUMi9CSXRORzh1OFdB?=
 =?utf-8?B?WStuZlhhdjhaSW9jcC9palNwZHV5VzRselhIbG5QTmc3MzFvQ1VKMDF3QTVn?=
 =?utf-8?B?U1BTUDhnejN0Y3VtdUZhMHplRnRyb0VWT3BzUTA3ZFBnZTBKMCtRYzI5OU9l?=
 =?utf-8?B?c0lpMWxLSXFYMFlhWjZrTUZiYTV1V21qZTFSekJzd0hZZC9sZEhwN1NicGZQ?=
 =?utf-8?B?d2ppeUdBVU0yVjY4ZGJDNzIrb1JWYXI0VDNobzRybEZmbG9la3VENDdUUmZS?=
 =?utf-8?B?b3FZdVBSSEdHQXpKUGxtSVNiV3M1WHJSMGhVTnAyaG01RWxNUDRacEszMkRC?=
 =?utf-8?B?ckpiTHFRRE14RUZ6eUtzc0dSSWdtRGNIYmFHbStsOHYrYzNnQU5ER2FTNnRL?=
 =?utf-8?B?NUcyenhPVVpldEhkVEF0TUphWDhUVzVYT3pkcTBjcnFEVENnc3pNVzNwS3JH?=
 =?utf-8?B?ejNyUUJLRVRRRXl6MmVsM3pocTRSM1VCVVZra3lnVEJBcXM3ZzVXZ3JEeG5o?=
 =?utf-8?B?VmxWYjEyd0dhWHJqUWh3TGptOXI5VjlLRlNoazdRVUxXekwzR04yL3lZeVlH?=
 =?utf-8?B?QXBnS3MzcEQ4MVBBN0VFcXh4KzRraWN6UGEwSTF5VWNDeHBhRUwxUDJqQm1N?=
 =?utf-8?B?bjdLWklrNXRkWWtYZUtSdGFWUUlDNjY1R1czcHJVUTRFWUVHUjNYV2E3Z0dL?=
 =?utf-8?B?UERTN1hhNXJKUXlBdG9YNVZldWUrK2tJcDRjYjBTTGxZY2FaTGJjYkk3RUlt?=
 =?utf-8?B?OTJVa3kzcjBCTGRCdnZHSW1WWmNIdTFXby95U2lHbGRsc2E5NDdVWWlpZjRV?=
 =?utf-8?B?NUJMVGJYUWxITDcyT3dvM2F4aHQrS0tQb3dPN29TNkNWbkh2QWpvQnI1K3JU?=
 =?utf-8?B?R3ZDQXpxUVVxYTFNSWx6TjlnVkxXZW1RbXF0SzV4Tkw5eTY3RW1Sc1dPcVM4?=
 =?utf-8?B?eW5ybHRoS2lSaVdrM3BidHpMd0dtMnVFTEFmbTdvcy9YMW04LzBrZ1I1L2Ur?=
 =?utf-8?B?SmY5QXRKajdwUnAxSHUrUmZ4QzBtRlczVjRmTW1seXJFUy9rRWIvQUJvVjZn?=
 =?utf-8?B?dXhDZHFvREp1aGJiYjZudjkvSG81RXVDaWxwR0VCRlQ2VkJLWXR2b1gvd2xB?=
 =?utf-8?B?OGpDWTZES3NrcnRyZTd2MWVmZXdOUVVnL0VQcU0vMUtNdjkwMWxUU2s1ejZn?=
 =?utf-8?B?bjJVUTJzYzBDUWlUZ2s3d1V4cE9DdTF2bHdJaWhiVzRablp4TWV4am41cmVH?=
 =?utf-8?B?WkZWUDJxVHFEMlgxbXYwTUVNeTl0Q3JHVnVKeU0zR2JxNTVGQzFVRCtxN0xy?=
 =?utf-8?B?am5ISlcvckN2MVdFSWk0WWgyRklaanVYMVlrcS9XRXduSExoUmNJaEs4ZmQw?=
 =?utf-8?B?bTBraUJ3d2RnYWQwTFI3VExGaGt0M1AzdTZZSnY2U0pMTTBHWmdPb2g0cVRL?=
 =?utf-8?B?U2dBWDROSGtIZFZyWnMxQ3NsTUliK0JRT0p3eUNuQTdscGhzR3ZPbXNKUzAw?=
 =?utf-8?B?b0oxTUVFRFhERC9Nc2U0SXdHNG1Kbk1BUWs1L0F5cGFuSlNRRFNHN0tqMHcw?=
 =?utf-8?B?Z05SOHBKZ05JYlF6QnQ4US9LaVVSYnFRQWRaYk4rUEc1eXBjc0dEQXNDZDdO?=
 =?utf-8?B?Y3ByVGt0N1NHOEEwbE9NOHh4RzhQTWpyZTFIcXYwWm9JZERGNVlRVit1Z1NE?=
 =?utf-8?B?WThlYi9SOWh6OFplYmZqYXRPcHVNblhmNmtLL3d2QjZZSkcvZG1RRUxRMWVu?=
 =?utf-8?B?cVJMM3FtenlBcjE0YXcxNnJKYVg4NTdqMWd1SHhiQkU0b25PTHlTWTUrc2FT?=
 =?utf-8?Q?IEbriBF0QVWYA/gjVrlCX684r?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c10c1ab-0bc3-44ff-ea46-08dc42a9b8f1
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5874.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2024 15:33:10.1320
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GQDI4Qvfs0m+lDOk8KcABP5jpdJd3vk+7g9YkcFNJaxBFW92zUJm75Iy3/C5zMEL
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB8139


On 3/12/24 7:10 AM, Krzysztof Kozlowski wrote:
> On 11/03/2024 19:39, Tanmay Shah wrote:
> >>> +
> >>> +    else:
> >>> +      patternProperties:
> >>> +        "^r5f@[0-9a-f]+$":
> >>> +          type: object
> >>> +
> >>> +          properties:
> >>> +            reg:
> >>> +              minItems: 1
> >>> +              items:
> >>> +                - description: ATCM internal memory
> >>> +                - description: BTCM internal memory
> >>> +
> >>> +            reg-names:
> >>> +              minItems: 1
> >>> +              items:
> >>> +                - const: atcm0
> >>> +                - const: btcm0
> >>> +
> >>> +            power-domains:
> >>> +              maxItems: 3
> >>
> >> Please list power domains.
> > 
> > Hello,
> > 
> > Sent v13 addressing both comments.
> > 
>
> And gave me exactly two hours to disagree?

I am sorry, I thought I was addressing the right comments.

It was minor change tempted me to push new revision, will wait longer next time.

>
> Best regards,
> Krzysztof
>