Received-SPF: pass (google.com: domain of linux-kernel+bounces-100471-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <4c1f2341-8cf8-4a5d-8877-9ba1d03defc2@amd.com>
Date: Tue, 12 Mar 2024 10:49:00 -0500
User-Agent: Mozilla Thunderbird Beta
Subject: Re: [PATCH v12 2/4] dt-bindings: remoteproc: add Tightly Coupled
 Memory (TCM) bindings
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 andersson@kernel.org, mathieu.poirier@linaro.org, robh+dt@kernel.org,
 krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
 michal.simek@amd.com, ben.levinsky@amd.com
Cc: linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
 Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
References: <20240301181638.814215-1-tanmay.shah@amd.com>
 <20240301181638.814215-3-tanmay.shah@amd.com>
 <fb78bdda-2ec7-4fcc-888e-233905a9386c@linaro.org>
 <2c45d7fb-06e4-468d-9415-0eaa48c5250b@amd.com>
 <18d34385-fd0b-401c-9ca4-ccf22106bd68@linaro.org>
Content-Language: en-US
From: Tanmay Shah <tanmay.shah@amd.com>
In-Reply-To: <18d34385-fd0b-401c-9ca4-ccf22106bd68@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eit5NUVXbUN2VW9MT25xcVVzdjhBaFpZbVpEeDFsaTNXNDdFSU5sRVVBZ1Zo?=
 =?utf-8?B?b3lJNmVNSnRsbmZmNTdqZit1VkhNcFBHUGowbkw5U1pmcnY3cmFKNUYrS2ll?=
 =?utf-8?B?aFgyODlwZitJRy9WRno1WmFEbHlISWVQYzFPZGFPdjF1Tjh6ZTZ6VmRvVlJN?=
 =?utf-8?B?QmFod2hLdm5DeTlWWUh3ZE82aUFaa3VQQVpNUEgybS9waU9jNTZ6MVUzbjd0?=
 =?utf-8?B?c0J2MHcvVUp3cFY3bENtTGd0Q0dXRTMvZ3FsODVSeUVFeW5WREJyWlMyeG5R?=
 =?utf-8?B?ZUwxc0o3TDdlUEZxL2p0SjBOSjdkcTMreW41U0l5MkxzSUNtZUF6TWgrL3BR?=
 =?utf-8?B?VmNLV2JmZFdOKzA1TmhIU3BKQ09TaDgvYmV1bGtIK1B2cFFEMUZOWW9wUHVx?=
 =?utf-8?B?b1ZSTTY0NXkwQ1g1ZEZEcmhLdStwdVVDb1Y1YkRkLzM5TjhMWEVETlVaRVBD?=
 =?utf-8?B?NTE5am1yZDIxZmY3UVRzUGpaYWxZRmppaDV4emFyQ3kvVEFZaUMzUGFRN1Vt?=
 =?utf-8?B?eHBPQ1FRdEtTZ2szVWVxWmxpaVFFZE1IZjh2M0ZEMFRGbWx1NFJFS3dQMXdj?=
 =?utf-8?B?SGdkT3YyN3gzK09GUGFLcWNUbmtpMzFrNFNXS3RsSjY5TmZScHJIYlcwQWpp?=
 =?utf-8?B?SmpsaGlYUTJkWHIyK21LYk9YZ0h1ZHQxbkpRV0FobmNLV2tzUHg1aS9PSnN6?=
 =?utf-8?B?SzhTQVQrL3dSRTB2QWZNRzI2SFNhRVVlc080d1gyT2g5eGdsNDFlTUFKWVlV?=
 =?utf-8?B?MUVJRUFKOFJRZWZoTUNxeTY2bjQ4MDhxYzl2UFNNT0VvZFVkUWZEbUNlR2Vk?=
 =?utf-8?B?TVlJdVR2N3ROdTVoRW12ZTExWTA0RnByVHBFaDJEeUVqR1RqSXdPSHNUWDA4?=
 =?utf-8?B?R1ZNbnFyOWtHb1gva0F2R280cmliS3UxYTlKbDlSUXNsanR4SE1jNUFsU2Nu?=
 =?utf-8?B?VFgzSFJ4b3NhZlRXTDY1MUoyN0JHZ0loM05GV2MxK0Y2MWg5bDJIYTNVcEJW?=
 =?utf-8?B?ckMvYlNRWnhwSGVrMW1hVHpSdFNGNE9ab2kvbkh6clArN25qNVpEWDdhLzA1?=
 =?utf-8?B?WnpIYTBEV3IrQWx1L0dtVk0wZmtSYTFiQVJNNXQ1WnNiQjZ1cXRMMmw4NEZv?=
 =?utf-8?B?a1hHQmtYVnIrOGx6VmszK3QzS0NrcmR1V3ErTGU2eTAzZmNsUzRRVDkvRkFP?=
 =?utf-8?B?cjB0R1RlWWF6QWJkTm4wM0V4Qk9ydS9SZkw5T0ZwamJiVitTMVl5aW1BSmFS?=
 =?utf-8?B?K1puUDlFOEhjSHdXM20zaDFCS2RSamF3ZEpwZEt4cGJtUjBRQWpmdmZJL245?=
 =?utf-8?B?R1FwV2pVNlRZRUhrUFMzdmgvODBJK25kTDBSQjRvK3cyUjlMWVFueVp4UHlO?=
 =?utf-8?B?dHNILzVTWitDb2VISVVLYzNsTUk4dG1xR1hQY2t6em1SU3hmREtDcjRXTUFR?=
 =?utf-8?B?TG92QndUbmN0TmVtcllhMmxrVFJwaVNZeFlQRUNETDBDRFZaZkhOSnZUQ25U?=
 =?utf-8?B?WnRTYzVHdk9xK0pwU1FmdmpDLzYyTmc3dkp1VkN0RkxSUXh5akZacjZ0UUNt?=
 =?utf-8?B?WHFQVmlmWXIwSEZnNnUrS0FEcElCaDVMWG4xSXpkYjRKZzNVQTdCdDRZMFRa?=
 =?utf-8?B?TXR4QXMzcEtkVXAzYS9JTURwT0hzZmZEeVBXRFRGa3I0MS9aVWw1a1ZJN0tS?=
 =?utf-8?B?d2czSWhEbk55VDFyMDRjZnYrOFdlS0pUam0wRVlwWHp3ZU1Dckw1VGd6V094?=
 =?utf-8?B?QTlkYlhqSVlHZWluOXVoTFNJS2RpSUV5cndkWmNGOE5zMVpvODZUd3JSYVdE?=
 =?utf-8?B?aXRhYmxLVktvYU9oTjJJb3BrTzMrdFUzeDVCYlJXVy9MM2w3MjN4QmdaTklo?=
 =?utf-8?B?RTAzdEFZQk1jVTNIMDdVS1crRzF1c2JENU56T3ZVeXZyY1ZpSzlLYVY2UUc0?=
 =?utf-8?B?aS9uRGc1cGhSTGZsUURmVkF0Y0hZamJuam8wMXRVQVlzMlpYeGJWV2J5V1gv?=
 =?utf-8?B?WHBOaU5jMWRTT29qUWRwcUxzZDZXQ21SaHd2a3VIVmI1SGEwUTBzWFVxT1FR?=
 =?utf-8?B?RXI2QkRXS0lJdkt3Z2R2elJvS0d1QkFFT29mY0hJc3J5MGxuVTgzWFByVWl6?=
 =?utf-8?Q?MI63kG8ECI/UZxWMFBTI0zFnX?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6687b255-9c22-4ce7-bef8-08dc42abf121
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5874.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2024 15:49:03.3539
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Zczf7kykNvxuBHFnCHy6KvG6G5/kKRySYeetIxpW8G3nvxET14sy3QXotcxT6tSe
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4059


On 3/12/24 7:10 AM, Krzysztof Kozlowski wrote:
> On 11/03/2024 17:27, Tanmay Shah wrote:
> >>> +    then:
> >>> +      patternProperties:
> >>> +        "^r5f@[0-9a-f]+$":
> >>> +          type: object
> >>> +
> >>> +          properties:
> >>> +            reg:
> >>> +              minItems: 1
> >>> +              items:
> >>> +                - description: ATCM internal memory
> >>> +                - description: BTCM internal memory
> >>> +                - description: extra ATCM memory in lockstep mode
> >>> +                - description: extra BTCM memory in lockstep mode
> >>> +
> >>> +            reg-names:
> >>> +              minItems: 1
> >>> +              items:
> >>> +                - const: atcm0
> >>> +                - const: btcm0
> >>> +                - const: atcm1
> >>> +                - const: btcm1
> >>
> >> Why power domains are flexible?
> > 
> > User may not want to use all the TCMs. For example, if users want to turn-on only TCM-A and rest of them want to keep off, then
> > 
> > they can avoid having power-domains of other TCMs in the device-tree. This helps with less power-consumption when needed.
> > 
> > Hence flexible list of power-domains list.
> > 
>
> Isn't turning on/off driver's job? Sorry, but what is "user" here? DTS
> describes bindings, not OS policy.

Thanks for reviews.

Correct driver turns on off TCM. However, system designers (users) have option

to not include TCM that is not needed in device-tree. So 

power-domains are flexible, same as reg, and reg-names. ATCM is always

needed as vector table is in ATCM. R5 core power domain and ATCM

power-domain for each core is always required so minItems 2.


> Also, please wrap your replies to match email style.
>
> > I can certainly mention "items:" under power-domains property.
> > 
> > 
> >>
>
>
> Best regards,
> Krzysztof
>