Received-SPF: pass (google.com: domain of linux-kernel+bounces-100499-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <792e956f-eefb-3d2b-ada2-0eaa175ba81e@quicinc.com>
Date: Tue, 12 Mar 2024 21:42:36 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] nvmem: meson-mx-efuse: Remove nvmem_device from efuse
 struct
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
CC: <srinivas.kandagatla@linaro.org>, <neil.armstrong@linaro.org>,
        <khilman@baylibre.com>, <jbrunet@baylibre.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-amlogic@lists.infradead.org>, <linux-kernel@vger.kernel.org>
References: <1709621888-3173-1-git-send-email-quic_mojha@quicinc.com>
 <CAFBinCC2n+Muu2qaAG0PWFj6f+bVFDtHnzm78jSpeodTD47TOg@mail.gmail.com>
Content-Language: en-US
From: Mukesh Ojha <quic_mojha@quicinc.com>
In-Reply-To: <CAFBinCC2n+Muu2qaAG0PWFj6f+bVFDtHnzm78jSpeodTD47TOg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit

Hi Martin,

On 3/8/2024 2:26 AM, Martin Blumenstingl wrote:
> Hello Mukesh,
> 
> On Tue, Mar 5, 2024 at 7:58 AM Mukesh Ojha <quic_mojha@quicinc.com> wrote:
>>
>> nvmem_device is used at one place while registering nvmem
>> device and it is not required to be present in efuse struct
>> for just this purpose.
>>
>> Drop nvmem_device and manage with nvmem device stack variable.
> I'm generally fine with this approach

Thanks.
Sorry for the late reply, was on vacation.

> 
> [...]
>> @@ -223,9 +222,9 @@ static int meson_mx_efuse_probe(struct platform_device *pdev)
>>                  return PTR_ERR(efuse->core_clk);
>>          }
>>
>> -       efuse->nvmem = devm_nvmem_register(&pdev->dev, &efuse->config);
>> +       nvmem = devm_nvmem_register(&pdev->dev, &efuse->config);
> But this doesn't compile for me:
>    CC      drivers/nvmem/meson-mx-efuse.o
> ../drivers/nvmem/meson-mx-efuse.c: In function 'meson_mx_efuse_probe':
> ../drivers/nvmem/meson-mx-efuse.c:252:9: error: 'nvmem' undeclared
> (first use in this function)
>   252 |         nvmem = devm_nvmem_register(&pdev->dev, &efuse->config);

Sent too soon., change was cached never got commited..

v2:
https://lore.kernel.org/lkml/1710259663-14095-1-git-send-email-quic_mojha@quicinc.com/

Thanks,
-Mukesh

> 
> 
> Best regards,
> Martin