Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp1175446lql; Tue, 12 Mar 2024 09:14:53 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW2Ns2gfmM2qjquP3f7rbEq73RCDq5elOnU3YU+uGefFlBiHW1uJzKawJP12IdBG7RUF9TTN61mYU556nRI2ZF9/TlGEVzaGf7wMr3qbw== X-Google-Smtp-Source: AGHT+IGmu6vuScNLltoc44eu3VgKJmr+1SL6dReekNiwldDBwOkZovVSC2BTbDMrEF6seQ8UcHg7 X-Received: by 2002:a17:90a:f0f:b0:29b:c0c1:af25 with SMTP id 15-20020a17090a0f0f00b0029bc0c1af25mr811323pjy.40.1710260093102; Tue, 12 Mar 2024 09:14:53 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710260093; cv=pass; d=google.com; s=arc-20160816; b=GOzacEw0HFa1Cc336CMQo61r8ZFECzzgdOjSx+ddE9BF0hbALIgfJuvW17OgshCCaB e9yLF+WVbJYlsvt1GJVPugDZ0rw/Dk5113WivEpnU2fBQT/ZcQb+B6sPzyz5xW8s3N+Y RuZqV7hYgAGdwvxfRvWcg9Nk5MnNx4N5jCAs5Kr/5zI7+0mrBHjBvgyaTcMT0Rl7XWWd ZUOQbinKVAsHlTFVNFw111wSSR6DsoxznH6uEL03MRBsLhWe+MbQMuf28eZHOFrUpHuK EdzuOc3s69EHXcpStQU59PmA+GRhEhn60y7itZjJ/kq9aFLL6+qy5WyJWaE/kviFHRMh ZkSA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=zLG0VkRk9T+MqlwYSwMr85lswH7UeBe9EKEDGZIjNWM=; fh=3vm8GbQ0vbeJAiQRSKpTRPLLbMbFsvkAddolbisssPc=; b=bYB1oixpe5aZ4MPXHBFPMLV2Z1dusgOINEVLMGklr4vV13IklETLVZ1P5+RDWFaC4q 5hyNCA7QzhQGwdn3+B4OB4wXptUFzbslPaU9te3gC8z/zSiztGJ15aBNlXShuItkheWa S05JtT4mt8F08w0oGZ5UACdIYcvt23TNd4AIsra/Py9JQ5yM/xkgm+WDnpNg4YmmZHYF 19Uddcc9bkNX56WEAiPOVRBW5TzEIjwxb1Hozs9MZerBEI9bO+M0qWdoDPi4UfNK57Vx Mc+zmxiUt0y3y9NkOePKQELdDd3JIPvI9GDqKBHAPbhOvn+WJKD2c7AmnlMGk7Im0lXE 4prg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VkaKbl3O; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-100498-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100498-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id hk2-20020a17090b224200b0029bb6e2b8f9si2902845pjb.57.2024.03.12.09.14.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 09:14:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-100498-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VkaKbl3O; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-100498-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100498-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 8E222B23BE4 for ; Tue, 12 Mar 2024 16:12:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A12757D3E9; Tue, 12 Mar 2024 16:12:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VkaKbl3O" Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CB5D7C08A for ; Tue, 12 Mar 2024 16:12:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710259945; cv=none; b=seZ9UoqkamYYou9TwOPOX3f4uEgGZaEtq/eLwUP4OUsRG8fP4eDoFOxtapEJrgF7ZqtF96nhfh+ADORsmVSBzM0TVNeQlraRj5gsHq+iuoBj+g/G4rLKrljWm8RTBhZQFlGUyKtk+FKURryislP68J6P1h9sn/oo2YNMFjmp1GY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710259945; c=relaxed/simple; bh=rXaL0LJcdegT3oLCAhYYQ90a8sQqF6H95AJnSTlrKSc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lPCaFunRrnum9P2EKSMRvqwVQnZ9RuPoXD9GvwII4wapNY/RPC8X/sfCxKG9vbcbo1yHc+ziRvDxtNEhgDsNO0YzkRt9WhNSyHl5lUhqK9ogwnUKchArzmeshHZaAhljVXc400WxHHyOVzO+RVy9VJve/2RW1hPBUMnsK73mXPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VkaKbl3O; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-5131bec457eso118484e87.0 for ; Tue, 12 Mar 2024 09:12:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710259942; x=1710864742; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zLG0VkRk9T+MqlwYSwMr85lswH7UeBe9EKEDGZIjNWM=; b=VkaKbl3OsvXrFmg4E80Ozyosy3q8c7v0SYE5ZgaVP8kkVtVxnhBaXrSltAxKs7fieN 4iFYDNM/aKYLsliKygdYE5llmP5alF0YBHRVzAsn5ZbgF8yXkW33szIXxRN9aUt2I85W FQty0IIldS6e+jyPuZ60jzeplo6g55x+Du6oD4BLrUSLC9+gha++YwMRPdChAdB88dLd tq8F47vH1P+TDYQ7pkVKdLd633GU9BlVjfbuoUfZGpMJlqJFwW36Ty7s/nbqsankpES6 9XNqGezrepJHGBPwfAhbY1+eks1ZQ8vWvKT9pZUyGDIgENzEQ8p9TXV0Lo6q5edCDu4a k51w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710259942; x=1710864742; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zLG0VkRk9T+MqlwYSwMr85lswH7UeBe9EKEDGZIjNWM=; b=k2xImF527pYQ0ONNseIJs/oEff3PwdTGBNSfM7doCRWjVetnRLNb+5caYD1hlHxnke 7foKsCCNPjqpyrHU8nHYZvfdqj7vmnvn9KWOv2cyLoN1T/RHl+fn8IZ1F6KrsqzGZddU bysK2fNNHW7cBI8ox3PetNkhLIT01kjIbTXS1R7FiKqxaldGy2qv7lHSDQG9j+qqJLex j81vf7iVeW8ZO+vQ4bP1OjQVSW1ao5vE0CBaFyppsTVd9TZ2FboeZmqLNj2bQfbCeMKW rBGh1wbRYP8sLMX9q7PsRPDpmPPcksfFuPGYmVjbXG3xv4NVhhPbRYIjGICnSG/1aY+r bKog== X-Forwarded-Encrypted: i=1; AJvYcCXcSpJzilgPcUkFs1rKYZgajEuNUoW4oHjD0C1HeOlGxd+Zr14amxS+cVBkkxTSMArNdtceE2YRAfE/VhgW2+poGkuLiZEhcKLBdId/ X-Gm-Message-State: AOJu0YxhNBm6JNB5pkdh7TaUQDUtm1wqp4cdPUMYrfOcPUfV/WBqqjsd knsZlteMpNEmq1fiQmT1gbKZJCGSjPFYTM0DdemWhIr0MJBgFY21Lub1SA7mYsI= X-Received: by 2002:ac2:4d0f:0:b0:513:488a:95af with SMTP id r15-20020ac24d0f000000b00513488a95afmr1774lfi.15.1710259942295; Tue, 12 Mar 2024 09:12:22 -0700 (PDT) Received: from [87.246.221.205] (netpanel-87-246-221-205.pol.akademiki.lublin.pl. [87.246.221.205]) by smtp.gmail.com with ESMTPSA id o5-20020ac24945000000b0051321db6a0dsm1634984lfi.139.2024.03.12.09.12.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Mar 2024 09:12:21 -0700 (PDT) Message-ID: <83734790-85c5-446f-b353-f3765cb10d41@linaro.org> Date: Tue, 12 Mar 2024 17:12:19 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/7] clk: qcom: clk-alpha-pll: Add HUAYRA_2290 support Content-Language: en-US To: Trilok Soni , Will Deacon , Robin Murphy , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter Cc: Marijn Suijten , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org References: <20240219-topic-rb1_gpu-v2-0-2d3d6a0db040@linaro.org> <20240219-topic-rb1_gpu-v2-2-2d3d6a0db040@linaro.org> <605d9e50-d61b-b0ce-1664-00554ba70b41@quicinc.com> From: Konrad Dybcio In-Reply-To: <605d9e50-d61b-b0ce-1664-00554ba70b41@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/23/24 23:48, Trilok Soni wrote: > On 2/23/2024 1:21 PM, Konrad Dybcio wrote: >> + /* Wait 50us for PLL_LOCK_DET bit to go high */ >> + usleep_range(50, 55); >> + >> + /* Enable PLL output */ >> + regmap_update_bits(regmap, PLL_MODE(pll), PLL_OUTCTRL, PLL_OUTCTRL); >> +} >> +EXPORT_SYMBOL(clk_huayra_2290_pll_configure); > > Please use EXPORT_SYMBOL_GPL. Sure, I glanced over this! I've also noticed that it's a very common oversight.. would you be interested in extending scripts/checkpatch.pl to suggest the _GPL variant? Konrad