Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp1194867lql; Tue, 12 Mar 2024 09:47:31 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWWOKpNQ24Vh26+wznl9oxgyvx1K2GPpcC50kPnRe92+mce9+IWkvI2d/Xtycjs947WJV6tSUkxfAt8/XCLGsZpgoidYdtlyEuXlCdNng== X-Google-Smtp-Source: AGHT+IF3xs1z071lNOzLeA+pUIVTOttfkVV6uhTSf9jiILRd7pcq6cNw+34WievUVo027rj158af X-Received: by 2002:a05:6830:118e:b0:6e4:ee67:c0ea with SMTP id u14-20020a056830118e00b006e4ee67c0eamr2322634otq.1.1710262051697; Tue, 12 Mar 2024 09:47:31 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710262051; cv=pass; d=google.com; s=arc-20160816; b=xGk5Ec1/I/Xx307gX63MV0PuA5pp6hh1UEB1N1Vnw3Vyxk6sdfyvB26fRle28DTY3T wcEtT2YREJo6QkHxnttORPPcGTSg/L+q7NLVf8Y6IU7dc+sQbHz4+bjdBtnQXT1wmFFF OCNBvsxXgR23Au02Co3U8m1QIFNKFoQaUKyDYe7o9PvnKgDKCcvATUTUfDeOo7YF2zhX dFw9buFKnsUbhlUsrsF6S1w3ywFy4qkit2aKFkPKhL3Ojgs35u8MOFm2KDkBvcPL6s+f i0Is3WJrGWI8ws1vQ9Nw4CPro1TQcnCOVhnGw9lRLDn/+D8uoLXSIxDWMGah5eilh5EO EMVw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=O6NBEa2afYFt2rUYpx/zjCR5QGcdUN6+Sqq0Rlvt2Hk=; fh=6Firt6yO90bdzTPZjDKYXv2572bfOVdoSCtZOox+AHA=; b=FpnRwQTUfAU6+BvkpLnMiyUdGnGy4tUPyOF8CUOhbd3RFArCgR2t80RCrqe8wkKLgs KKkA8gMpf3fA/8JyjGcIzj0CXvZ+mkAzYBaReGihj99YDTeYfAcCZHsRTkfdWgn7x3xl R/EZbDUbPfgYkKn+KUdf8wOzNGRawqrhHBcHYTPDFXh9ww1D3qwxVytqlDxZt6l7QRFl nbKvUKwNm5QVkNCtj2ADtcj9BAOU1SPJlvXedCG21xTuZuLzxS1z+TTVE8Y8mWefLPfe Vqx/sbpdKDvm8PHxKeNsW8HpGepGQxj75gkBE/rTs39cs3qlMe3j0DbOrTDC7X07nKRu M+BQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Pq8ps+Zg; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-100537-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100537-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id s6-20020a05620a080600b0078876ddf731si2631747qks.746.2024.03.12.09.47.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 09:47:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-100537-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Pq8ps+Zg; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-100537-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100537-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 6990D1C21A5D for ; Tue, 12 Mar 2024 16:47:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4D6A47E765; Tue, 12 Mar 2024 16:47:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Pq8ps+Zg" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F80F1CD33; Tue, 12 Mar 2024 16:47:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710262044; cv=none; b=Z2pmTmgRXCxa3GPJsPMxP/li6tWpptvAoyx1tPGu4awDBptK7Nbn5TDV24th0L9RHjdvx00c2BNaMSLVCwNONwmURMC9csF4pYLWlwb81YGxoxAr3VXqu/iiNBLBZCNeoVtBIIA7CSb2od2Pq2zMYdlO8TJPL07zKevI98o4E6U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710262044; c=relaxed/simple; bh=EsvOuyb+HUnPC1GuDXLeMVoVm0gOgiyNVftcb+r99Ro=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OiNEx0E3e/2FuMDK1Rkc6uUMtlLlkJVQHnj7jbM9mafCAi/U0+WhPbVTkwErk5DhXymbqM++i+ZGrEwfTWYUDrWlQxc2FeCT6Vhz72oB08nqRMxtVwtZIzQEJC4/dFWglwzLeKlTOQnxg0ZXh5bL0qtTBiAv4BElYZ7luXeqjA8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Pq8ps+Zg; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79B17C433F1; Tue, 12 Mar 2024 16:47:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710262044; bh=EsvOuyb+HUnPC1GuDXLeMVoVm0gOgiyNVftcb+r99Ro=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Pq8ps+Zg2MNmRP29GQ1BTPW/9+Jw0BvhunHfMiVBWrtpPRbIWievVAhGGyk/y2X8G WWjzUOvgp2/56uyyr1mjUd1VCRwI5hFIP8vQnKy3PxsLFUKMXxtXe+U8hu1ec2poGm yS/oG7Y2vRUNaWns+wI3p8atOOojX0HpIeDvaiRXWutaE/MVSabNqEu8Sdc+PuzTck KIi/rBB8To/F+zVoV5XQHiI2KTS5cpk5R1DYFTGCiAEgengkvaExYOaxSQUX4A6Gzp 4w1jlE81WEJdRk6qsN65C59HwXYaoPxVswc7vpiQYXjYtPtPjZlV+l5LChc2zvWnQ5 5bct/1732il/w== Message-ID: <5abe8292-f9a1-4e47-84a2-3f2ca58ac9e4@kernel.org> Date: Tue, 12 Mar 2024 17:47:19 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] soc: qcom: llcc: Add llcc device availability check To: Mukesh Ojha , andersson@kernel.org, konrad.dybcio@linaro.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240220122805.9084-1-quic_mojha@quicinc.com> <20332b6f-e0cc-4356-83ec-0c9771481083@kernel.org> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/03/2024 17:25, Mukesh Ojha wrote: >>> static struct llcc_drv_data *drv_data = (void *) -EPROBE_DEFER; >>> +static DEFINE_MUTEX(dev_avail); >>> + >>> +static bool is_llcc_device_available(void) >>> +{ >>> + static struct llcc_drv_data *ptr; >>> + >>> + mutex_lock(&dev_avail); >>> + if (!ptr) { >>> + struct device_node *node; >>> + >>> + node = of_find_node_by_name(NULL, "system-cache-controller"); >> >> Why do you look names by name? This create undocumented ABI. > >> NAK (also for any future uses of such of_find_node_by_name()). > > I agree, what if we add a common compatible string like qcom,llcc to all > llcc supported SoCs. I did not dig into the your problem (also commit msg does not really help me in that), but usually relationship between device nodes is expressed with phandles. This also has benefits of easier (future) integration with device links and probe ordering. Best regards, Krzysztof