Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp1219306lql; Tue, 12 Mar 2024 10:26:35 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUofP1lkox7Bd4V5LsxXUhITmSzngTilTrSJcWJDocPV79FjsVm0LPGWGGJROEZSgN7TzrmvX+OBxMvf6CW/xfFtL/vVGsyt8D14N6qLA== X-Google-Smtp-Source: AGHT+IFLxyi49MRuOrcN4U+jwssZnXXuJWJAXLlV5qEjqqunHh/DFucXv8D2azroYsojR4JfVzoP X-Received: by 2002:a05:6358:c011:b0:17e:6a5b:75ba with SMTP id kv17-20020a056358c01100b0017e6a5b75bamr2747654rwc.21.1710264394977; Tue, 12 Mar 2024 10:26:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710264394; cv=pass; d=google.com; s=arc-20160816; b=BQRqDSIGKSIFjaPqXv6XnvuJbbExDZeBKa0MkpzsUiuhU93CJ+NqJAg6DzBx8mxFfO 6mCE5vfQkLwgc26ov6iafYVx6oDCJ3QPfMIp7WVHGjE80oeuZJYZzz8pp5AYlMxM08RB IgLwdVwTW4/V4FujMw7llxyYHtoNrBuDVU5McJu524+OelEoGGa3lqXaojlP7qL26U+6 RPp2Y0SGkdtWc15kRHgycDLdt4WJtsEUcEjFFZTjk8zOb/6KbDSgk/6mnygGjmOlFzWB fYlEJsU6pUxIZLTk/995t+p6WS6M9C3wLm1VEbTFlE73486LwYiXmvKwI2ScpHNwMO3H PSwg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=qcKVSwhTEuhx4u071Ym6ZC+2SVHltmPw9cJib/jvwMQ=; fh=Gt5PrpBMXEc8dGplH6WAGAbrbCLNcRlZyX+fqvnI34s=; b=XunonKPQ/a/ecz9Orgm1B0NF8UNg9Fs3ZjrUc1WU1DWZ6VEi455erVvQALUBTGhrGS mlM3zyWe6k0mplg6pFzaV/bZQpYOyZ40kbfkA5EeFoqATez6cZ4IgoeQzl8xAhcN4lSa zQAKhxSUS08oASoEvn+Mhp0U3nhTFJ1rUCnkZihOHmoCzdowajPuNx+QPYGiOvrkW3hw D3+LpTdOv4N79ShsWTjT3jumyWB/t/Jx2LkLvWwTdpQuUEjdC10qR2WkztfKXP7eFfAw Wh3SatO87H9mgu9ay2a4HSzbrC5/fvoc+6KuhHs4hU4vOKU6kcfa9/1J+ekHTA3gqNJ7 MNgA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XRiwiPAF; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-100587-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100587-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 75-20020a63004e000000b005e4ba7d402bsi7433893pga.808.2024.03.12.10.26.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 10:26:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-100587-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XRiwiPAF; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-100587-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100587-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 9057BB243B2 for ; Tue, 12 Mar 2024 17:17:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A1E951386DB; Tue, 12 Mar 2024 17:16:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XRiwiPAF" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2BD51384AC; Tue, 12 Mar 2024 17:16:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710263810; cv=none; b=YoDug9bRdXFWwNZls/4TzWXE5neQ2rhQXUPFEK4FeEar9u41oIzfAoSPI0egLGG8jJ3/SxQDZzHzPt0njrkyCJSmxpAMwmBaa0DnT9yqG4YKHQ/BZfFn/ojwoUYf4443q58+x/niWKFv3t/6hGCAkombx8CW8fpUmkKySRlEUnE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710263810; c=relaxed/simple; bh=aQeZaK+TULHgRWkvv2I+BpJx4y9OlHXVOYa9vHfBBy4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gvwInpcTYGYlYez6NlcE5Pwi/f8sNGPLyYzfreusnYPC2mQgYgjZmHp4rNEFe8/sri90XbeZtF6qIEIK1hZXWrlaSJBf8rr8NPSpn0eWevU2MlfJCbVsw/FOijLt0PX0wcT4JAnakJ47BaCGC2RmR13kUpe1dkwIemvrWvqp0cg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XRiwiPAF; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85AA7C43399; Tue, 12 Mar 2024 17:16:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710263810; bh=aQeZaK+TULHgRWkvv2I+BpJx4y9OlHXVOYa9vHfBBy4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XRiwiPAFaEGmafJCxxNLa1ivfAv5L1cEU+bXPOJhOxJ2AEqEok7LcfLwCHCcMrMpr 3WSX2S1lnp3wGe/W60SopIDVr2IUXu8vIy5fOq5e/9q3PBzuOvPvnKTZ4u8zKJS4VI duhoG9v/4a6lz+AtB3iYSdRTrS9gLUcDeKW7ZGcBlBQnNSqUJxNfr06SWFS49kdu+8 nsv4m830llErNUPM5km2Uvegj8tX2xgGD8PnZ0eC6fK1KTzJpbDKdSExtAuHMdPnb8 AbPnOffsQXzer7x8Iux1SkXXDod8dhbgN5z1p3ZMw/Kx33PrVJm8mx5wfO1mA8nOT2 Sjb4yxMdXOEig== Date: Tue, 12 Mar 2024 10:16:48 -0700 From: Jakub Kicinski To: Daniil Dulov Cc: Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Doug Berger , Paolo Abeni , , , Subject: Re: [PATCH net-next] net: phy: mdio-bcm-unimac: Cast denominator to unsigned long to avoid overflow Message-ID: <20240312101648.14a23b5c@kernel.org> In-Reply-To: <20240312165358.7712-1-d.dulov@aladdin.ru> References: <20240312165358.7712-1-d.dulov@aladdin.ru> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 12 Mar 2024 19:53:58 +0300 Daniil Dulov wrote: > The expression priv->clk_freq * 2 can lead to overflow that will cause > a division by zero. So, let's cast it to unsigned long to avoid it. ## Form letter - net-next-closed The merge window for v6.9 has begun and we have already posted our pull request. Therefore net-next is closed for new drivers, features, code refactoring and optimizations. We are currently accepting bug fixes only. Please repost when net-next reopens after March 25th. RFC patches sent for review only are obviously welcome at any time. See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle -- pw-bot: defer