Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp1223731lql; Tue, 12 Mar 2024 10:34:36 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWIwXClyNSUrIpr52krvCVnYv9K9H+wTsNQl5XosKDql/vyPKZWwSDQC8qGhmVX90zOanD6ZsmGcMRhObHwcB63xAH+h4A7ZR0bGsRNbg== X-Google-Smtp-Source: AGHT+IHXEpy8hTY9rQEJJa5e75JfdXIcUxZd+gm34Fw2vC4Ra5ezVisvswaDF0eDUWzWOwEaYrae X-Received: by 2002:a2e:9dcf:0:b0:2d2:f394:fc19 with SMTP id x15-20020a2e9dcf000000b002d2f394fc19mr1536530ljj.27.1710264876235; Tue, 12 Mar 2024 10:34:36 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710264876; cv=pass; d=google.com; s=arc-20160816; b=qpYPdoji21NsY/r2zBU9nW6zmIFvk7zf9pKBVuKNS1GyLq/0F/1E21CqozC8TJrIDV vtVwgYW1g2Ry8N/NO1wWgLmMlE5PhJKeFPcAGMsSVRr6DfzsdYbiKXjUEPtNZbwYJZbg xFLRlP9p4o7xQmSPDvPoKQ5B6L0e2MvY7m3esFe55pXJnwglIf+LNPBpV1drAKhRF9E0 ibmpqgTPzno8yHa6WZsDI60Mzl9EJs1XtKWpiuRLBConQ5zqTDUSMeBahBlIoCGPEjfc 4icPuTDxJV1TNzcSMbATJYxqAjW6QL4cSmBqJ58YGHlM8kGKEnuY3zjfKte9YqGHOdZd yYdg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=4Y8apy1giXXPmGE1ExorHlS5/gX4kkESkRKyhXvX9fg=; fh=3SlCtb7gAd2C6Wzcs3sLv5dQhSDlRzf/+NQZwZZwN+Y=; b=V0Yinowk7pB3voDS7lUhxZ5tOGVTigcmk1bwOqSHp59x3o/bfGBUy5uu5oBYkatzA/ D8ZUv1x38WSespV2kom/edc+dYuP7+tWbg0yAMTBmN0K8i5xO/PEFqaV9tRTx59Iem3N A6S96CHp2l3J158AVKuMvSGIk9hsuQPfWwGT/Ul57R+WxrJvSeP0Wf9KGzUnJllCX/OT yqWCI5BpqolknFAUfdjktNpIg2caNIcXYy8lET+ieRE/IQsBg58IuvasNzlWzdMpiEop yuYdv0KgBLhN0rR7d8bzJT/Ij0Zh4B/K9Jj87bWg2MVjUQVdkuk8tQIIJtJ0VEN9rUpu jSTw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-100602-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100602-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id m19-20020a056402431300b0056840dc5c54si3242853edc.267.2024.03.12.10.34.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 10:34:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-100602-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-100602-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100602-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id EC0BD1F232FC for ; Tue, 12 Mar 2024 17:34:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2F6FE1386B8; Tue, 12 Mar 2024 17:34:28 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7BCFE58107; Tue, 12 Mar 2024 17:34:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710264867; cv=none; b=t6fTQcTyxMPESBK93a6vmWFk9OBTBv9Wo5JpXkN85btIvMqNz3xOZIwOUbqx5mjIDG4NahwdUFfJEIrd0obPsXY/oQvPXDxODFgRlym6OXOcff5kx8VGGlTM8pxLDy8XMQbHaV6YT7YCiMwXF6JOuqQnE+txT5bw/bVui59HZR8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710264867; c=relaxed/simple; bh=7drBWCwWabZEy2dYA9+ueo/gCQDbMJkiZFLgldP5+yI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=LLSvl2pBUic+OxCfH3CI6Xurxg3jpNjw2x1XnySKwxPmEpUc/gccodtSdoPhqdrCaUiev1uSxa4kWsEQUCQ3NJCg8ovTB+Tdp5ohpTO7tXw8vWSsyZUY4MKCZ3SaMvrk6SS+oTHXCTpr0797qH2W/oExZMcnw09qr27aJY5fdHY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CDA101570; Tue, 12 Mar 2024 10:35:01 -0700 (PDT) Received: from e121345-lin.cambridge.arm.com (e121345-lin.cambridge.arm.com [10.1.196.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 9BAB63F762; Tue, 12 Mar 2024 10:34:22 -0700 (PDT) From: Robin Murphy To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Will Deacon Cc: Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-perf-users@vger.kernel.org, jialong.yang@shingroup.cn Subject: [PATCH 00/10] perf: Clean up common uncore boilerplate Date: Tue, 12 Mar 2024 17:34:02 +0000 Message-Id: X-Mailer: git-send-email 2.39.2.101.g768bb238c484.dirty Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi all, Since this came up yet again recently, and it's an idea which has been nagging me for years, I decided it was time to see how hard it really would be to start shaving this yak. And it turns out to be refreshingly simple - the core code has quietly become capable of doing most of what we want, the one new functional addition is trivial (patch #2), and the resulting largely-mechanical cleanup seems a pretty nice win. This series is focused on drivers/perf/ as that's where most mess is concentrated, but figured I'd include the arch/ patches as well since they might be reasonable to land with the core changes, at least for x86 (FWIW I did also look at the powerpc drivers but they scared me and I ran away; sorry). The remaining stragglers elsewhere around the tree I'd come back to as a follow-up. (And yes, I appreciate it's mid-merge-window already, but since I do have a tree-wide rename proposed here, may as well give the discussion a chance for a head start before -rc1...) Thanks, Robin. Robin Murphy (10): perf/alibaba_uncore_drw: Use correct CPU affinity perf: Add capability for common event support drivers/perf: Use PERF_PMU_CAP_NO_COMMON_EVENTS perf: Rename PERF_PMU_CAP_NO_INTERRUPT drivers/perf: Use PERF_PMU_CAP_NO_SAMPLING consistently drivers/perf: Clean up redundant per-task checks perf: Define common uncore capabilities drivers/perf: Use common uncore capabilities x86: Use common uncore PMU capabilities ARM: Use common uncore PMU capabilities arch/arc/kernel/perf_event.c | 2 +- arch/arm/mach-imx/mmdc.c | 16 +------------- arch/arm/mm/cache-l2x0-pmu.c | 12 +--------- arch/csky/kernel/perf_event.c | 2 +- arch/powerpc/perf/8xx-pmu.c | 2 +- arch/powerpc/perf/hv-24x7.c | 2 +- arch/powerpc/perf/hv-gpci.c | 2 +- arch/powerpc/platforms/pseries/papr_scm.c | 2 +- arch/s390/kernel/perf_cpum_cf.c | 2 +- arch/sh/kernel/perf_event.c | 2 +- arch/x86/events/amd/iommu.c | 17 +------------- arch/x86/events/amd/power.c | 10 +-------- arch/x86/events/amd/uncore.c | 12 +++------- arch/x86/events/core.c | 2 +- arch/x86/events/intel/cstate.c | 16 +++----------- arch/x86/events/intel/uncore.c | 11 +-------- arch/x86/events/intel/uncore_snb.c | 20 +++-------------- arch/x86/events/msr.c | 9 +------- arch/x86/events/rapl.c | 9 +------- drivers/fpga/dfl-fme-perf.c | 2 +- drivers/perf/alibaba_uncore_drw_pmu.c | 27 +++-------------------- drivers/perf/amlogic/meson_ddr_pmu_core.c | 11 +-------- drivers/perf/arm-cci.c | 15 +------------ drivers/perf/arm-ccn.c | 20 +---------------- drivers/perf/arm-cmn.c | 10 +-------- drivers/perf/arm_cspmu/arm_cspmu.c | 27 ++--------------------- drivers/perf/arm_dmc620_pmu.c | 18 +-------------- drivers/perf/arm_dsu_pmu.c | 22 +----------------- drivers/perf/arm_pmu_platform.c | 2 +- drivers/perf/arm_smmuv3_pmu.c | 15 +------------ drivers/perf/arm_spe_pmu.c | 7 ++---- drivers/perf/cxl_pmu.c | 8 +------ drivers/perf/dwc_pcie_pmu.c | 13 +---------- drivers/perf/fsl_imx8_ddr_perf.c | 13 +---------- drivers/perf/fsl_imx9_ddr_perf.c | 13 +---------- drivers/perf/hisilicon/hisi_pcie_pmu.c | 10 +-------- drivers/perf/hisilicon/hisi_uncore_pmu.c | 20 +---------------- drivers/perf/hisilicon/hns3_pmu.c | 9 +------- drivers/perf/marvell_cn10k_ddr_pmu.c | 15 +------------ drivers/perf/marvell_cn10k_tad_pmu.c | 6 +---- drivers/perf/qcom_l2_pmu.c | 21 ++---------------- drivers/perf/qcom_l3_pmu.c | 21 +----------------- drivers/perf/riscv_pmu_sbi.c | 2 +- drivers/perf/thunderx2_pmu.c | 17 +------------- drivers/perf/xgene_pmu.c | 16 +------------- include/linux/perf_event.h | 6 ++++- kernel/events/core.c | 7 +++++- 47 files changed, 67 insertions(+), 456 deletions(-) -- 2.39.2.101.g768bb238c484.dirty