Received-SPF: pass (google.com: domain of linux-kernel+bounces-100615-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <fdad2198-5d3a-4bce-8249-8b2f9f75f84a@amd.com>
Date: Tue, 12 Mar 2024 12:42:18 -0500
User-Agent: Mozilla Thunderbird Beta
Subject: Re: [PATCH v13 2/4] dt-bindings: remoteproc: add Tightly Coupled
 Memory (TCM) bindings
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 andersson@kernel.org, mathieu.poirier@linaro.org, robh+dt@kernel.org,
 krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
 michal.simek@amd.com, ben.levinsky@amd.com
Cc: linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
 Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
References: <20240311175926.1625180-1-tanmay.shah@amd.com>
 <20240311175926.1625180-3-tanmay.shah@amd.com>
 <d498d76e-b021-4cf7-adca-63f1cd3e1542@linaro.org>
Content-Language: en-US
From: Tanmay Shah <tanmay.shah@amd.com>
In-Reply-To: <d498d76e-b021-4cf7-adca-63f1cd3e1542@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UkQwMUxFdWJOR3VMS0x2SkVuRDNQZWNwQmFnbnpxZXhIRVZBNkNYZ3JBTUIr?=
 =?utf-8?B?R3E3a0NQN3JybEFJQktwb2VHdVh0a29lQ3pPYzZCWFQ0SjYwV1ExeHVTeVl3?=
 =?utf-8?B?Slc5WDRaS2JOYkl5Z1M4b0NJQUVXTVpVQSs3SitJNklCdkRWT21wWnZwdDRI?=
 =?utf-8?B?bnhJT2ZOdVRUVXpvVHdJc2IzdUxuZnYva0pnZ1F3UVFmSS9iVTBXYmFnWk9p?=
 =?utf-8?B?NEh3cUFUbVBwOW42dndEelVTMytlSWhVeFRDL1prSlAzQktWdER5cFFvbDVt?=
 =?utf-8?B?WWVYUGM3NmtmWWdnTy9XbVZ2YjUwaHBlckMwbEtmSFA3dE5BV3crSXRoeUpQ?=
 =?utf-8?B?Q2pYbG4rNW5UcVp2ODQwOUQ2NXdoSTk1VERMMnlybUZ2aFN1dWU2cVVtVm9X?=
 =?utf-8?B?WnJTZFVFeVd5eEhtM0QzZkZJRndyN1o2cGdXNHNZc3pTZkgrWk9HRGJvbXFM?=
 =?utf-8?B?dUt6eDlYcDRXSk5TY1JTdVZmVHoxUVdiY1lGMVdSYk53QkovQ1hRZTFRVTRE?=
 =?utf-8?B?WTZ2Y0hoVXlZWFhIdUxISllreUFMNDdwa1BmVE5hRkNsM1VYVWNzV2FwTWdu?=
 =?utf-8?B?WFBQY01PbjBxNjYrRjFKNS9wVDFhcktRWXo0cTVLWnJlT25PWFBHVlIvMDNO?=
 =?utf-8?B?aFVlU1ZDTWZmN0QvKzc3ckhJb21VdVRpTmc3bzFIaTVZbEkvdU80L1Q1Skc5?=
 =?utf-8?B?SSt1aC9hK2NVdVRHbitCdVp5c0U2STcweDUwNjZWcmF5eXRSQlU5T3pqMHhp?=
 =?utf-8?B?am1Bc0VjWUsyWlNMVWM0THJHVEpqTVY0U0NTQkhDRXhGcmVySTV6T3BseThW?=
 =?utf-8?B?QmNBNlpRa21BdURSQjNHTEZ3ZFJGci9SNVNqaDVzbml3OFRWdDR1bm9pdld4?=
 =?utf-8?B?blRmaExndS8xKzQvTy9ldTNmUzRVcmtCeDk0bWw1dnVlaGdqWUVWbkFRNXpa?=
 =?utf-8?B?dFUyVk16ckRnUHFJSklUdFdrRWlKT3J4bEgwZ0c4eFlFanFETkdtSEJ3Y3Bi?=
 =?utf-8?B?eUxmR1BLVFFaKzRGUDI1UXlOdzRvbG8wdVQ5YkZZL0sxRkhuSHlOMWxiM3VN?=
 =?utf-8?B?NTdrMjNPeDlMc3BmRUkwbmdkSXBGNmtJbTBVV3lpYUNZOHZyQVN3UDJQbHFD?=
 =?utf-8?B?SlpudFowK2JtUFRUekpyQldkZWEyU2wyUUZIVWFpRkhmbWNQancwQmoxRHEz?=
 =?utf-8?B?TWpjaHR6UXU0Smh5ZExnM1NqeGRzWERqUXVQR2pUUmV0RmFkd1VFcGluTTZt?=
 =?utf-8?B?ZTB6aUp6SW1ESUdBWnlWQnhJakl2UVZIdWJjK0d0b1VNMGhiRnRrazU1d0RU?=
 =?utf-8?B?eDRZRFVlV2ZYTmRMQlBvbU9FMHNldkIwVFdtRExWeXhVU05KcEFtZDdjTTR0?=
 =?utf-8?B?U1IxYmF1MURZUDZzRVM3c2RXeUJwdC9MWXJXTTlIMDZhSER6UnoyUHB1Vmp3?=
 =?utf-8?B?OHowb1VIaUlscHY2Vjdjd1JGUHVRUWVPWm1scHlwVENQLzVlbzRGM0t2YkVI?=
 =?utf-8?B?bGZLeGFLdlpOTVN1bW85dXNWa1Babk4rN1lRcHpTS016MlFxeVp0OFJlc1E0?=
 =?utf-8?B?cERtZE9aWEFMUXd1R2JhV2drcFR2WjRGWHg3azNXVFRzdE9nbTFIelhVVEpi?=
 =?utf-8?B?Y2Zjc2xkdS9CelZMQmI0K1BLeUJ0TUcvYWtZRysyakloK3VYUlhxZHFDdHhs?=
 =?utf-8?B?c1JNaGFNMUU4Nms2ZjlwZnhCdWN5YzBwdnYwUzdka2lZbnRuY3JRUkhhUERZ?=
 =?utf-8?B?MVg0K0VuKy85RzZhUVFtMXpDSElDL2VOcVRWUFhMKzVhekdtL0JoK3RRZktq?=
 =?utf-8?B?bTRKMlZWKzVya0VMc05kN3E5WUJmSTdQNUNFQWQwYkowYWt3S01Fcjg1a2RV?=
 =?utf-8?B?TWxvWFZuNTVQQTJTY1hCOUJtRWpFUHExaE04MitCblF2T0VYOUZtMjV1TTd5?=
 =?utf-8?B?TkZQcXZpUWR5RWxBVjBFNlJ6c2NtS0dpQkgxZWl1SUh0ODdadHFiNVY5K1lK?=
 =?utf-8?B?MEtJMVpyWTJmMFZvOTFvdkVURllTazBJSFYxeEZlcUdtVXFKaGRuQk9WQllB?=
 =?utf-8?B?VWQyaXovcVgwdUxFOEp3eWNoOW50eXlEa3NrNTJyOU9rSDRwN2lUdU9uVlM3?=
 =?utf-8?Q?pbLl9ucyTj/lLCZxxYyzBX1pj?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 68cff8aa-2e32-4d78-5b21-08dc42bbc542
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5874.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2024 17:42:21.6866
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: l+xfv/kv2SYGAyA3AoSahMN5DnilhySyOOdaK+Kui2lbzCLDeT5IGLgqr15r4mr1
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8705


On 3/12/24 7:13 AM, Krzysztof Kozlowski wrote:
> On 11/03/2024 18:59, Tanmay Shah wrote:
>> From: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
>> 
>> Introduce bindings for TCM memory address space on AMD-xilinx Zynq
>> UltraScale+ platform. It will help in defining TCM in device-tree
>> and make it's access platform agnostic and data-driven.
>> 
>> Tightly-coupled memories(TCMs) are low-latency memory that provides
>> predictable instruction execution and predictable data load/store
>> timing. Each Cortex-R5F processor contains two 64-bit wide 64 KB memory
>> banks on the ATCM and BTCM ports, for a total of 128 KB of memory.
>> 
>> The TCM resources(reg, reg-names and power-domain) are documented for
>> each TCM in the R5 node. The reg and reg-names are made as required
>> properties as we don't want to hardcode TCM addresses for future
>> platforms and for zu+ legacy implementation will ensure that the
>> old dts w/o reg/reg-names works and stable ABI is maintained.
>> 
>> It also extends the examples for TCM split and lockstep modes.
>> 
>> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
>> Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
>> ---
>> 
>> Changes in v13:
>>   - Have power-domains property for lockstep case instead of
>>     keeping it flexible.
>>   - Add "items:" list in power-domains property
> 
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Hi Krzysztof,

Thanks for RB. I provided explanation of flexible power-domains in
previous patchset. I am happy to send new revision removing
minItems if you dis-agree.

Thanks.

> 
> Best regards,
> Krzysztof
>