Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp1281949lql; Tue, 12 Mar 2024 12:17:58 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUKDGprkhO98L7/Z+QHcORX3rlIwRqwNKoGP5e/pw6EimwfGYPR78qSZZibDm1wp08VW1fYR/WEnJTfw1+I0z8yBgKIPICjFjMwLI+eRw== X-Google-Smtp-Source: AGHT+IFgMj43oqMh4jJVjhENVlEEFjQZQscpXQaNNFrkMf+5M3KtgPxtBM3wmtexhL34j5Scz6gt X-Received: by 2002:a17:906:f156:b0:a46:4800:123e with SMTP id gw22-20020a170906f15600b00a464800123emr818443ejb.73.1710271077947; Tue, 12 Mar 2024 12:17:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710271077; cv=pass; d=google.com; s=arc-20160816; b=q5HzoYDh54jzd6iY2roLTChsxFMzDoqnPb1mJfKs8tYqEPZBsSYOlBPUgy4nkgpAv6 CFbmoRIZZVUvaorrfRrLEc8tvHUm3MZncV9M6THhD2rH12P3RIAJ/oUEvXthfb4SOZar xKy6YKQZBl40H5OeSTAJvvC1x4iefEPi+t33ceHkvWrZrQHAGfwx9e78RypYDXL6zLsV 7tN/9aAkwiiOD7dSdvPDp73c72A7dTsMNVGVzw0RgU9uvSQsfRt0/mI8K4TOlQ4bH107 LIyZ84yK+SihQhNSD+l5oubbTmPRzFYmOiVuMXCEvIavnlwO0lV+5KORAmHA1BL2L5y0 +e2w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=3E+KvORFMKvDm1+B07pZtngBNS1kRcXmmHOQGV6v/ns=; fh=cPfTj2clNvK6BlpPrHLGf4zDR34617AKlPg+GOZXYZE=; b=Tm2VkPY0sg16VysEu0IgW8rfoT7v5pEyIsluHZIZZQ6CXyH9J5b7rkwJ4Si2ZSU9Yo vWj46zA43oECiG+9fb7nDF95KHkBx4/7SgKGwyUm2Sb5ltSj7HMt5+uS9Ng+GxpHEpHo 4PfketV9cttKLe9ALhgMu6ZKom6EBdIgI/h0SmhqWDAUgPIhQCVwbsA0cJ7N6eB4RrH+ U80gdnLuBCS/GYmV5Le/+i1AwVvWdpS6BPmWnrXRsvuisCoR/Xejjk4gaSCkhvmjXSGT 2z8mmbafswZmamtCxz3L+Pmz0ydMzC3Kor375BI9YKPfrTEHwTiCryeeJXyhP13kxbyN Mg4g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=fjLzEIe6; arc=pass (i=1 spf=pass spfdomain=cmpxchg.org dkim=pass dkdomain=cmpxchg-org.20230601.gappssmtp.com dmarc=pass fromdomain=cmpxchg.org); spf=pass (google.com: domain of linux-kernel+bounces-100703-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100703-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id p6-20020a1709060dc600b00a464cd3e462si337334eji.415.2024.03.12.12.17.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 12:17:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-100703-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=fjLzEIe6; arc=pass (i=1 spf=pass spfdomain=cmpxchg.org dkim=pass dkdomain=cmpxchg-org.20230601.gappssmtp.com dmarc=pass fromdomain=cmpxchg.org); spf=pass (google.com: domain of linux-kernel+bounces-100703-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100703-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 82B241F210C1 for ; Tue, 12 Mar 2024 19:17:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 05C70142640; Tue, 12 Mar 2024 19:17:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20230601.gappssmtp.com header.i=@cmpxchg-org.20230601.gappssmtp.com header.b="fjLzEIe6" Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECE6B7E761 for ; Tue, 12 Mar 2024 19:17:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710271050; cv=none; b=VH5wdhHJaa+h9rEHYJLlmI2r8sYfWigM4rD+7rzTSvzAjy1sn2n7F9W6pCucZly8KESrlzLbnx9eAJ6tl83GAghIAp+ORfniecdshbE9+zWwUKRUhystT4q5U6QtSlHPc7ukmphpP5/IBGllGrqCeNN1dtmkEvFEyQO1S3YvHwI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710271050; c=relaxed/simple; bh=cenzjZ+RIAMctKhDW0VVdrYPL4dSxNe5xXKryhs3GRY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QMKEg4/WuWbt9UYZ/8GRPA46tzhXx1JMpPaxLw63Qq2P2YBabJ5/qD37J5rNLj2rExn/Uz3txbniPOrMIY963CDpd0SHL4pvhgeWhhhfk/Jtb2ALrTM40bfB7y+nXkpFB3NygiEffKER9/I46+PRWh/QGYCPTMVxCluIo/juLMM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20230601.gappssmtp.com header.i=@cmpxchg-org.20230601.gappssmtp.com header.b=fjLzEIe6; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-7882d713f6fso294215385a.0 for ; Tue, 12 Mar 2024 12:17:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1710271045; x=1710875845; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3E+KvORFMKvDm1+B07pZtngBNS1kRcXmmHOQGV6v/ns=; b=fjLzEIe6a3423cbFNnJ+RttrSZrn3pMtzjOq0xP40kAampWJfe8mOV7zZe4oYrnzGm hojO2jTTzO1eSNHnIM3opDNuK5sBhps97o8sMugVM0E2itbbq7yrcJPCcKUUPSpPN7cW dEY+yCT4zNPvBZGO4XLw0QT5PP4Hfi6atF8EcLqHDgfby5t3++HUXGuunc/AvZw6tk6X wIAjINCfGbzfZS4KFxvaMPgXI+Ow4RWV6R2AucDBnGTWFUMr9Ssjac2PShe3nH3OGBaP hfloe3RMWIVpc/C0PIC5JRbCE6dBGQw9kHhz6IrEhC+3VYihNEV6lW1sD6V8xhfiaLpy j8JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710271045; x=1710875845; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3E+KvORFMKvDm1+B07pZtngBNS1kRcXmmHOQGV6v/ns=; b=frtEOsavHvSu1EYraoS9NXWm6hS5UcGX+wUyOwFGDN1og2iCNyk4eJP1ounK842E4g BjcdHIO2PCnKkS7fwYclgkpv85VY4xjXBdLkb61h7him1KiF5wGlGM5oaIUvVgQhZtLk WrpETrcQtj8lvLERd/g1v11BCJLDJtIQyzaf39EebvnGcPCN47JgrNfDLS0gP4V3Kcep i9+IPr1LVAN1G/cRp2I4Bq1/HLugQe0Ar6Kf3GNqrDng4mFDeccRYpdBUsgoLhJlJKdV ctpi8SGiFQYb6Nnol9/ULgR0ExbLQGl9duJHzfso4OJLuayhZvAtOQsNZleByrkGldsZ Tjng== X-Forwarded-Encrypted: i=1; AJvYcCWTQNFJ1fTmsd6uox5Qz10NWhDSBggqxi9VQw6GKQv4A/XXYKgdBIUxa2SbW4kvpa+izq9tQO22RVOwrNtnILAzMQgFZruAIvlSv63b X-Gm-Message-State: AOJu0Yz4/tryMGxXp3ZRHoc8hInjlrgmgD+HNOlAijr1o/ePqSV7YIDV aLANuT7PvG3SkloPGqgAeg1TAQWmC1FJL5nQSeKOm0jCwedl61fSWjyBUT4gB3u5dzZBAJWZcCf 9 X-Received: by 2002:a05:620a:2906:b0:789:4844:a229 with SMTP id m6-20020a05620a290600b007894844a229mr2679493qkp.8.1710271044743; Tue, 12 Mar 2024 12:17:24 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-da5e-d3ff-fee7-26e7.res6.spectrum.com. [2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id vw23-20020a05620a565700b0078830d4ef5bsm3935321qkn.107.2024.03.12.12.17.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 12:17:24 -0700 (PDT) Date: Tue, 12 Mar 2024 15:17:23 -0400 From: Johannes Weiner To: Yosry Ahmed Cc: Andrew Morton , Nhat Pham , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: zswap: remove unnecessary check in zswap_find_zpool() Message-ID: <20240312191723.GA65481@cmpxchg.org> References: <20240311235210.2937484-1-yosryahmed@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240311235210.2937484-1-yosryahmed@google.com> On Mon, Mar 11, 2024 at 11:52:10PM +0000, Yosry Ahmed wrote: > zswap_find_zpool() checks if ZSWAP_NR_ZPOOLS > 1, which is always true. > This is a remnant from a patch version that had ZSWAP_NR_ZPOOLS as a > config option and never made it upstream. Remove the unnecessary check. > > Signed-off-by: Yosry Ahmed Acked-by: Johannes Weiner